From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8MB5FpqWTF8KPQAA0tVLHw (envelope-from ) for ; Mon, 31 Aug 2020 06:20:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AF1AEpqWTF/XXwAAbx9fmQ (envelope-from ) for ; Mon, 31 Aug 2020 06:20:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D57EF940A5B for ; Mon, 31 Aug 2020 06:20:09 +0000 (UTC) Received: from localhost ([::1]:34370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCdAl-0005MK-Hx for larch@yhetil.org; Mon, 31 Aug 2020 02:20:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCdAg-0005MC-RQ for guix-patches@gnu.org; Mon, 31 Aug 2020 02:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCdAg-0007P9-IB for guix-patches@gnu.org; Mon, 31 Aug 2020 02:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCdAg-0008MT-Dh for guix-patches@gnu.org; Mon, 31 Aug 2020 02:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43101] [PATCH v2] Add version number in release ISO Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 31 Aug 2020 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43101 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 43101@debbugs.gnu.org Received: via spool by 43101-submit@debbugs.gnu.org id=B43101.159885474832065 (code B ref 43101); Mon, 31 Aug 2020 06:20:02 +0000 Received: (at 43101) by debbugs.gnu.org; 31 Aug 2020 06:19:08 +0000 Received: from localhost ([127.0.0.1]:51347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCd9c-0008Kc-6c for submit@debbugs.gnu.org; Mon, 31 Aug 2020 02:19:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCd9a-0008KQ-GR for 43101@debbugs.gnu.org; Mon, 31 Aug 2020 02:18:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51143) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCd9T-0007MA-SG; Mon, 31 Aug 2020 02:18:47 -0400 Received: from [2a01:e0a:19b:d9a0:24e2:2545:c1f2:cf9e] (port=36044 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCd9T-00069g-Ae; Mon, 31 Aug 2020 02:18:47 -0400 From: Mathieu Othacehe References: <20200829154445.5512d99a@tachikoma.lepiller.eu> <87d038i6uf.fsf@gnu.org> <904ADAD9-76B7-4C7F-A0DF-39CEB6E3477D@lepiller.eu> <87v9h0p420.fsf@gnu.org> <20200830215230.3dd526fd@tachikoma.lepiller.eu> Date: Mon, 31 Aug 2020 08:18:44 +0200 In-Reply-To: <20200830215230.3dd526fd@tachikoma.lepiller.eu> (Julien Lepiller's message of "Sun, 30 Aug 2020 21:52:30 +0200") Message-ID: <87r1rnibi3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: ycSWKyHMt+oH Hey Julien, Thanks for the v2 :) > (inherit iso9660-image) > - (operating-system installation-os)))) > + (operating-system installation-os) > + (partitions (match (image-partitions iso9660-image) > + ((boot others ...) > + (cons > + (partition > + (inherit boot) > + (label (string-append "GUIX_" system "_" > + %guix-version))) > + others))))))) We could maybe factorize this in something like: --8<---------------cut here---------------start------------->8--- (define (image-with-label image label) ...) --8<---------------cut here---------------end--------------->8--- that would be put in (gnu system image). Otherwise, looks fine to me :) Thanks again, Mathieu