From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 43340@debbugs.gnu.org
Subject: [bug#43340] [PATCH 4/5] daemon: Spawn 'guix authenticate' once for all.
Date: Sat, 12 Sep 2020 09:20:04 +0200 [thread overview]
Message-ID: <87r1r7h36j.fsf@gnu.org> (raw)
In-Reply-To: <20200911145154.15057-4-ludo@gnu.org> ("Ludovic Courtès"'s message of "Fri, 11 Sep 2020 16:51:53 +0200")
> + (send-reply 500
Reply codes could be factorized in an enum.
> + if (!agent) {
> + Strings args = { "authenticate" };
> + agent = std::shared_ptr<Agent>(new Agent(settings.guixProgram, args));
> + }
make_shared should be preferred to the direct use of new.
> + if (strchr("0123456789", ch)) {
You can maybe use isdigit?
Thanks,
Mathieu
next prev parent reply other threads:[~2020-09-12 7:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 14:40 [bug#43340] [PATCH 0/5] Speed up archive export/import Ludovic Courtès
2020-09-11 14:51 ` [bug#43340] [PATCH 1/5] daemon: Generalize 'HookInstance' to 'Agent' Ludovic Courtès
2020-09-11 14:51 ` [bug#43340] [PATCH 2/5] daemon: Isolate signing and signature verification functions Ludovic Courtès
2020-09-11 14:51 ` [bug#43340] [PATCH 3/5] daemon: Move 'Agent' to libutil Ludovic Courtès
2020-09-12 7:21 ` Mathieu Othacehe
2020-09-11 14:51 ` [bug#43340] [PATCH 4/5] daemon: Spawn 'guix authenticate' once for all Ludovic Courtès
2020-09-12 7:20 ` Mathieu Othacehe [this message]
2020-09-11 14:51 ` [bug#43340] [PATCH 5/5] authenticate: Cache the ACL and key pairs Ludovic Courtès
2020-09-11 15:01 ` [bug#43340] [PATCH 0/5] Speed up archive export/import Ludovic Courtès
2020-09-12 7:12 ` Mathieu Othacehe
2020-09-13 13:07 ` Ludovic Courtès
2020-09-14 13:47 ` bug#43340: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1r7h36j.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=43340@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).