[bug#42364] [PATCH] gnu: Add python-robber.

[bug#42364] [PATCH] gnu: Add python-robber.

[Tanguy Le Carrour]

* gnu/packages/python-xyz.scm (python-robber): New variable.
---
 gnu/packages/python-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 15d9e097c5..f6afb73fcb 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -3522,6 +3522,26 @@ designed to be used by Robot Framework and tools and libraries in its
 ecosystem, but can naturally be used also by other projects.")
     (license license:asl2.0)))
 
+(define-public python-robber
+  (package
+    (name "python-robber")
+    (version "1.1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "robber" version))
+              (sha256
+               (base32
+                "0xp5csgv2g9q38hscml6bc5i1nm4xy5lzqqiimm2drxsf0hw2nq5"))))
+    (build-system python-build-system)
+    (arguments '(#:tests? #f))  ; no tests
+    (propagated-inputs
+     `(("python-mock" ,python-mock)
+       ("python-termcolor" ,python-termcolor)))
+    (home-page "https://github.com/vesln/robber.py")
+    (synopsis "BDD / TDD assertion library for Python")
+    (description "Robber is a BDD / TDD assertion library for Python.")
+    (license license:expat)))
+
 (define-public python-robotframework
   (package
     (name "python-robotframework")
-- 
2.27.0

[bug#42364] [PATCH] gnu: Add python-robber.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Tanguy Le Carrour <tanguy@bioneland.org> writes:

> * gnu/packages/python-xyz.scm (python-robber): New variable.

Thanks!  As this appears to be a test library, can you move it to
python-check.scm?

[...]
  
> +(define-public python-robber
> +  (package
> +    (name "python-robber")
> +    (version "1.1.5")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "robber" version))
> +              (sha256
> +               (base32
> +                "0xp5csgv2g9q38hscml6bc5i1nm4xy5lzqqiimm2drxsf0hw2nq5"))))
> +    (build-system python-build-system)
> +    (arguments '(#:tests? #f))  ; no tests

There appears to be tests in the upstream repository:

  https://github.com/vesln/robber.py/tree/master/tests

Perhaps we should pull that instead of the PyPI release?

Otherwise LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#42364] [PATCH] gnu: Add python-robber.

[Tanguy Le Carrour]

Hi,

Le 07/21, Marius Bakke a écrit :
> Tanguy Le Carrour <tanguy@bioneland.org> writes:
> 
> > * gnu/packages/python-xyz.scm (python-robber): New variable.
> 
> Thanks!  As this appears to be a test library, can you move it to
> python-check.scm?

Would make sense, indeed! I'm sending a v2 for this.


> > +(define-public python-robber
> > +  (package
> > +    (name "python-robber")
> > +    (version "1.1.5")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (pypi-uri "robber" version))
> > +              (sha256
> > +               (base32
> > +                "0xp5csgv2g9q38hscml6bc5i1nm4xy5lzqqiimm2drxsf0hw2nq5"))))
> > +    (build-system python-build-system)
> > +    (arguments '(#:tests? #f))  ; no tests
> 
> There appears to be tests in the upstream repository:
> 
>   https://github.com/vesln/robber.py/tree/master/tests
> 
> Perhaps we should pull that instead of the PyPI release?

Yes, but… for an (yet) unknown reason, version 1.1.5 is not in the git
repo!? The last version is 0.1.0!?
I sent an email to the author mentioned on PyPI. I'm adding a comment on
this in the package definition.

-- 
Tanguy

[bug#42364] [PATCH v2] gnu: Add python-robber.

[Tanguy Le Carrour]

* gnu/packages/python-check.scm (python-robber): New variable.
---
 gnu/packages/python-check.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index 2e3cfe05c5..8c4af22fab 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -534,3 +534,26 @@ it, the declaration of a name's public export semantics are not separated from
 the implementation of that name.")
     (license (list license:asl2.0
                    license:lgpl3))))    ; only for setup_helpers.py
+
+(define-public python-robber
+  (package
+    (name "python-robber")
+    (version "1.1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "robber" version))
+              (sha256
+               (base32
+                "0xp5csgv2g9q38hscml6bc5i1nm4xy5lzqqiimm2drxsf0hw2nq5"))))
+    (build-system python-build-system)
+    ;; The last version tagged in Github (0.1.0) is older than the one on PyPI.
+    ;; Reported upstream: <https://github.com/vesln/robber.py/issues/20>.
+    ;; There are no tests in the tarball downloaded from PyPI.
+    (arguments '(#:tests? #f))
+    (propagated-inputs
+     `(("python-mock" ,python-mock)
+       ("python-termcolor" ,python-termcolor)))
+    (home-page "https://github.com/vesln/robber.py")
+    (synopsis "BDD / TDD assertion library for Python")
+    (description "Robber is a BDD / TDD assertion library for Python.")
+    (license license:expat)))
-- 
2.27.0

[bug#42364] [PATCH v2] gnu: Add python-robber.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Tanguy Le Carrour <tanguy@bioneland.org> writes:

> * gnu/packages/python-check.scm (python-robber): New variable.

[...]

> +    ;; The last version tagged in Github (0.1.0) is older than the one on PyPI.
> +    ;; Reported upstream: <https://github.com/vesln/robber.py/issues/20>.

Wow, it's concerning that someone just uploaded a fork on PyPI without
notifying the original author, yet reuses the original home page.

Even more so when there are no tags matching the uploaded tarball.

I think we should adjust the home page of this package to point to the
fork, and maybe add a comment explaining the situation.  WDYT?

Can you also add a copyright line for yourself in python-check.scm?

Thanks for tracking down this issue!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#42364] [PATCH v2] gnu: Add python-robber.

[Tanguy Le Carrour]

Hi Marius,


Le 07/25, Marius Bakke a écrit :
> Tanguy Le Carrour <tanguy@bioneland.org> writes:
> 
> > * gnu/packages/python-check.scm (python-robber): New variable.
> 
> [...]
> 
> > +    ;; The last version tagged in Github (0.1.0) is older than the one on PyPI.
> > +    ;; Reported upstream: <https://github.com/vesln/robber.py/issues/20>.
> 
> Wow, it's concerning that someone just uploaded a fork on PyPI without
> notifying the original author, yet reuses the original home page.

He might have tried, but… the original author's email address given on
PyPI does not exist any more!


> Even more so when there are no tags matching the uploaded tarball.
> 
> I think we should adjust the home page of this package to point to the
> fork, and maybe add a comment explaining the situation.  WDYT?

I've just send a email to the author of the last commit in the second
repo. Let's see what will happen!
In the worst case scenario, I can open a claim request on PyPI and fix
the mess myself. But let's hope I don't have to do that! ^_^'


-- 
Tanguy

[bug#42364] [PATCH v2] gnu: Add python-robber.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

Tanguy Le Carrour <tanguy@bioneland.org> writes:

> Hi Marius,
>
>
> Le 07/25, Marius Bakke a écrit :
>> Tanguy Le Carrour <tanguy@bioneland.org> writes:
>> 
>> > * gnu/packages/python-check.scm (python-robber): New variable.
>> 
>> [...]
>> 
>> > +    ;; The last version tagged in Github (0.1.0) is older than the one on PyPI.
>> > +    ;; Reported upstream: <https://github.com/vesln/robber.py/issues/20>.
>> 
>> Wow, it's concerning that someone just uploaded a fork on PyPI without
>> notifying the original author, yet reuses the original home page.
>
> He might have tried, but… the original author's email address given on
> PyPI does not exist any more!

Oh, right.  That makes sense.  :-)

>> Even more so when there are no tags matching the uploaded tarball.
>> 
>> I think we should adjust the home page of this package to point to the
>> fork, and maybe add a comment explaining the situation.  WDYT?
>
> I've just send a email to the author of the last commit in the second
> repo. Let's see what will happen!
> In the worst case scenario, I can open a claim request on PyPI and fix
> the mess myself. But let's hope I don't have to do that! ^_^'

I hope so too!  Meanwhile I think we can take the original patch you
sent, but adjust the home page to that of the fork.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#42364] [PATCH v3] gnu: Add python-robber.

[Tanguy Le Carrour]

* gnu/packages/python-xyz.scm (python-robber): New variable.
---
 gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index 51b864957f..aa00a35d23 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -889,3 +889,27 @@ any Python VM with basically no runtime overhead.")
     ;; Foundation License version 2: stdlib-samples/*, mypyc/lib-rt/pythonsupport.h and
     ;; mypyc/lib-rt/getargs.c
     (license (list license:expat license:psfl))))
+
+(define-public python-robber
+  (package
+    (name "python-robber")
+    (version "1.1.5")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "robber" version))
+              (sha256
+               (base32
+                "0xp5csgv2g9q38hscml6bc5i1nm4xy5lzqqiimm2drxsf0hw2nq5"))))
+    (build-system python-build-system)
+    ;; There are no tests in the tarball downloaded from PyPI.
+    ;; The last version tagged in Github (0.1.0) is older than the one on PyPI.
+    ;; Reported upstream: <https://github.com/vesln/robber.py/issues/20>.
+    (arguments '(#:tests? #f))
+    (propagated-inputs
+     `(("python-mock" ,python-mock)
+       ("python-termcolor" ,python-termcolor)))
+    ;; URL of the fork used to generate the package available on PyPI.
+    (home-page "https://github.com/EastAgile/robber.py")
+    (synopsis "BDD / TDD assertion library for Python")
+    (description "Robber is a BDD / TDD assertion library for Python.")
+    (license license:expat)))
-- 
2.27.0

bug#42364: [PATCH v3] gnu: Add python-robber.

[Ludovic Courtès]

Hi,

Tanguy Le Carrour <tanguy@bioneland.org> skribis:

> * gnu/packages/python-xyz.scm (python-robber): New variable.

[...]

> +    (synopsis "BDD / TDD assertion library for Python")
> +    (description "Robber is a BDD / TDD assertion library for Python.")

I tweaked these and applied, thanks!

Ludo’.

[bug#42364] [PATCH v3] gnu: Add python-robber.

[Tanguy Le Carrour]

Le 09/24, Ludovic Courtès a écrit :
> Hi,
> 
> Tanguy Le Carrour <tanguy@bioneland.org> skribis:
> 
> > * gnu/packages/python-xyz.scm (python-robber): New variable.
> 
> [...]
> 
> > +    (synopsis "BDD / TDD assertion library for Python")
> > +    (description "Robber is a BDD / TDD assertion library for Python.")
> 
> I tweaked these and applied, thanks!

Thanks!

-- 
Tanguy