From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WLA3C5aec180WAAA0tVLHw (envelope-from ) for ; Tue, 29 Sep 2020 20:52:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KBQXB5aec183ZgAAB5/wlQ (envelope-from ) for ; Tue, 29 Sep 2020 20:52:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ADDE194023C for ; Tue, 29 Sep 2020 20:52:37 +0000 (UTC) Received: from localhost ([::1]:51172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNMc0-00031A-Mk for larch@yhetil.org; Tue, 29 Sep 2020 16:52:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNMWc-0007cM-Fc for guix-patches@gnu.org; Tue, 29 Sep 2020 16:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNMWb-0007Ov-Nu for guix-patches@gnu.org; Tue, 29 Sep 2020 16:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNMWb-0008Om-Md for guix-patches@gnu.org; Tue, 29 Sep 2020 16:47:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43620] [PATCH 2/2] gnu: Add folly. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Sep 2020 20:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Greg Hogan Cc: 43620@debbugs.gnu.org Received: via spool by 43620-submit@debbugs.gnu.org id=B43620.160141239532251 (code B ref 43620); Tue, 29 Sep 2020 20:47:01 +0000 Received: (at 43620) by debbugs.gnu.org; 29 Sep 2020 20:46:35 +0000 Received: from localhost ([127.0.0.1]:57300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNMWA-0008O6-Vb for submit@debbugs.gnu.org; Tue, 29 Sep 2020 16:46:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNMW9-0008Nq-3D for 43620@debbugs.gnu.org; Tue, 29 Sep 2020 16:46:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47361) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNMW3-0007NT-MO; Tue, 29 Sep 2020 16:46:27 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57474 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kNMW3-0003wU-5Y; Tue, 29 Sep 2020 16:46:27 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Tue, 29 Sep 2020 22:46:24 +0200 In-Reply-To: (Greg Hogan's message of "Fri, 25 Sep 2020 14:13:40 -0400") Message-ID: <87r1qk48gv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: tz/jjADE2EjZ Greg Hogan skribis: >>>From 2835c2ac08db9b5887bcc33a3c15e84f26111864 Mon Sep 17 00:00:00 2001 > From: Greg Hogan > Date: Tue, 22 Sep 2020 15:22:32 +0000 > Subject: [PATCH 2/2] gnu: Add folly. > > * gnu/packages/cpp.scm (folly): New variable. [...] > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0ppd02scbi4a52s99par4i17cys4z8gangpxa86yma48k72z5xvs")) > + (patches (search-patches > "folly-add-missing-include.patch")))) Looks like your mail client mangled the patch. > + (synopsis "An open-source C++ library developed and used at Facebook= ") Everything is free software in here, no need to write it. Also, please remove the initial article and somehow say what the library provides in terms of features: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > + (description > + "Folly (acronymed loosely after Facebook Open Source Library) is a > library > + of C++14 components designed with practicality and efficiency in mind. > Folly > + contains a variety of core library components used extensively at > Facebook. In > + particular, it's often a dependency of Facebook's other open source C++ > efforts > + and place where those projects can share code. > + > + It complements (as opposed to competing against) offerings such as Boo= st > and of > + course std. In fact, we embark on defining our own component only when > + something we need is either not available, or does not meet the needed > + performance profile. We endeavor to remove things from folly if or when > std or > + Boost obsoletes them. > + > + Performance concerns permeate much of Folly, sometimes leading to > designs that > + are more idiosyncratic than they would otherwise be (see e.g. > PackedSyncPtr.h, > + SmallLocks.h). Good performance at large scale is a unifying theme in > all of Folly.") I=E2=80=99d strip all but one reference to Facebook, we=E2=80=99re not an a= dvertising project. :-) Nitpick: please remove =E2=80=9Copen source=E2=80=9D, avoid marketing terms (=E2=80=9Ccompeting=E2=80=9D, =E2=80=9Cofferings=E2=80=9D, etc.), write @co= de{std}, @file{SmallLocks.h} and similar. Could you send an updated patch? Thank you! Ludo=E2=80=99.