From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OCBANYWnlF8ALAAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 22:15:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CFsRMYWnlF9EHwAAB5/wlQ (envelope-from ) for ; Sat, 24 Oct 2020 22:15:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2AA569402A0 for ; Sat, 24 Oct 2020 22:15:33 +0000 (UTC) Received: from localhost ([::1]:49094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWRow-0003AC-Qk for larch@yhetil.org; Sat, 24 Oct 2020 18:15:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWRoW-0003A1-HL for guix-patches@gnu.org; Sat, 24 Oct 2020 18:15:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWRoU-0006dZ-6X for guix-patches@gnu.org; Sat, 24 Oct 2020 18:15:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWRoU-0008JU-1K for guix-patches@gnu.org; Sat, 24 Oct 2020 18:15:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44170] [PATCH] gnu: Correct Inkscape extension dependencies Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 22:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44170 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ekaitz Zarraga Cc: "44170@debbugs.gnu.org" <44170@debbugs.gnu.org> Received: via spool by 44170-submit@debbugs.gnu.org id=B44170.160357767631910 (code B ref 44170); Sat, 24 Oct 2020 22:15:01 +0000 Received: (at 44170) by debbugs.gnu.org; 24 Oct 2020 22:14:36 +0000 Received: from localhost ([127.0.0.1]:35378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWRo4-0008Ib-5y for submit@debbugs.gnu.org; Sat, 24 Oct 2020 18:14:36 -0400 Received: from mira.cbaines.net ([212.71.252.8]:51126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWRo1-0008IQ-UF for 44170@debbugs.gnu.org; Sat, 24 Oct 2020 18:14:35 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id 45B3B27BBF0; Sat, 24 Oct 2020 23:14:32 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id df446e67; Sat, 24 Oct 2020 22:14:30 +0000 (UTC) References: <87mu0bbdqx.fsf@cbaines.net> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: Date: Sat, 24 Oct 2020 23:14:27 +0100 Message-ID: <87r1pn9sqk.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: zeDiLDP79OxU --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ekaitz Zarraga writes: >> The : after /bin is unnecessary. > > I copied all this from Kicad's package because it's a software > that has a similar python plugin style. That's fine, it's also unnecessary there :) If you pull the generated shell out of the bin/kicad or bin/inkscape file, and play around with it in a shell, you should see something like: =E2=86=92 export PATH=3D"/gnu/store/11l2qmzfgsp7k345mv6x1vn64q8330kw-python= -wrapper-3.8.2/bin:${PATH:+:}$PATH" =E2=86=92 echo $PATH /gnu/store/11l2qmzfgsp7k345mv6x1vn64q8330kw-python-wrapper-3.8.2/bin::/gnu/= store/hgh67ilwsbx6v2irc7vgrnv354cv4h8a-profile/bin Note the double colon, I don't think it's a problem in terms of functionality, but just in case someone copies this from inkscape as an example, it would be good not to do the same here. Note, there's no need to fix this in kicad. If you do want to, I'd submit a separate commit under a seperate bug. >> Also, it looks like python-wrapper is already referenced lots in the >> output, did you have a specific reason why wrapping inkscape with the >> PATH was useful? > > Not really. > I just copied it from kicad and followed the discussion at guix-devel... > I thought it was necessary but watching what python-wrapper does it's > probably not necessary. I'll try it without the PATH and remove it if > it's not useful. > > I'll compare with kicad's package too, because they are very similar > so they should have some relation on this too. Sounds good, it's possible something, or plugins expect the PATH to have python on it, if so, that's fine, but it would be good to note the reason in a comment. Otherwise, this bit can be removed. >> So, before python-wrapper was a native-input, and you've added some >> Python packages as native inputs. >> >> The distinction for inkscape between an input and a native input is >> mostly academic at this point, because the meson build system doesn't >> support cross builds. >> >> However, inkscape already uses references python-wrapper in its output, >> so it should probably be an input. With this change, you're also setting >> out that inkscape should be able to use these Python libraries at >> runtime, hence they should be inputs (matching the architecture you're >> building for), rather than native inputs (matching the architecture >> you're building on). >> >> Does that make sense? > > Something obviously doesn't. :) > In my understanding, python should be an `input` but it was already in > `native-inputs`, I don't know why. So I considered all the rest of the > python-related packages should be in the same block. > > If I did this package I would add python-* and python itself as inputs. > > So, I follow your explanation and it's what I understood, but I don't > get why were python related things in native-inputs before. That > confused me. > > I'll move those to inputs. Could you explain or find a reason why python > wasn't an input before? is it just an error? Well, error is a strong word, in this case, given the build system doesn't support building for a non-native architecture, it's sort of a non-issue. But I would view it as something you're fixing in addition to the changes you're making. It didn't (and still doesn't to some extent) matter that the Python stuff was/is in native-inputs, because cross building this package is impossible because of the build system. However, in case the build system changes to support this, to be consistent with other package definitions, and to be consistent with the general rule that you don't reference native-inputs from the outputs (at least I think that's a rule or at least strong convention), having the Python stuff in inputs is better. Even if the package builds just the same. > Thank you for your time and for the explanations. Really helpful. > > I'll follow up with the updated patch soonish. Only with the Inkscape > part. You're welcome :) I look forward to it. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+Up0NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfCxA//QwhdFh5HZfmjq90dW4q3B5bQOeFcIFNv Uf+qyrv+e/VF+6umESRskAZMF8eSyyGq/GQ8XaDxHWljshMqO5o3EVqm5o9Cs/kY U3hswcOOGMJFKTgceSjgi0FsISd3O6QIP4EBFXPXbnv5cOQJnI+YN4fd1wxYimZq eeIHajIK3LOjuAqIAfZVyasBBndnCyVu1F81FVU5Z/G0tMdx/YsEAaHaBxYWEsUS usvnjHAH/M48a8wjwWWs5bEgogNe5zgRU5akOYcm000olZg3FXD88BDncwE/hDFU bVa+17HMvPOmbC9PgCPblulK6gfufYHtu0jS2wrUWZ3Hy/hJnZ55tp43i2uiQsKY tBKOUU8I0l2JQEUZUQAaU8JX4MFAScNFEk/IrhNhcRODw7TwssBLiB4OXr6S4Dg+ tRXRosXbX525cUDDJibId7T/XYck3o4fAhSD32jWbAV1di5luZHfRac8WxXJG6FQ K37x/dszk2ONTPb9E+LKJqL5TtEFVIP961OrA+GGzHUTCJ+MX41HsWBcquwgwpPV xc+ZuMgoDtIomliRc8nG/n+OWUvJHUkr6hvlgSlnyUTP0yfz4tRtXVsBtZjB3K+s CDtfvbU/eqJLTVQe9gaQ806iW0Lazgzv972DvVLCt3Uw/QBgKXzJKdvWW768Aw0p iqn6YLE5pRM= =c8dk -----END PGP SIGNATURE----- --=-=-=--