unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: Jonathan Frederickson <jonathan@terracrypt.net>
Cc: Kyle Meyer <kyle@kyleam.com>,
	45000@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: [bug#45000] [PATCH 0/9] Build git-annex with assistant webapp enabled
Date: Fri, 04 Dec 2020 09:34:05 -0500	[thread overview]
Message-ID: <87r1o5skrm.fsf@ngyro.com> (raw)
In-Reply-To: <4a143acb-6b03-bc7f-12f3-17da26545f56@terracrypt.net> (Jonathan Frederickson's message of "Thu, 3 Dec 2020 20:56:29 -0500")

Hi Jonathan,

Jonathan Frederickson <jonathan@terracrypt.net> writes:

> On 12/3/20 3:52 PM, Timothy Sample wrote
>> With respect to the patches, I managed to apply them all, build all of
>> the packages, and run the assistant, so that’s good!  However, most of
>> the packages are more recent then the versions given in the Stackage LTS
>> Haskell 14.27 list <https://www.stackage.org/lts-14.27>, which we follow
>> to maintain a consistent package set.  Please see
>> <https://lists.gnu.org/archive/html/guix-patches/2020-12/msg00086.html>
>> for an explanation.  (The short version is that the problem is not
>> really your fault but rather the fault of our tools suggesting at every
>> turn to do the wrong thing.)  All of the packages except ghc-hjsmin and
>> ghc-cryptonite-conduit are too recent
>> Would you mind sending an updated patch set with the LTS Haskell
>> 14.27
>> versions?  As of recently, if you run “guix lint” on Haskell packages it
>> will warn you if the version is wrong and suggest the correct version.
>
> Oh, oops! Thanks for letting me know. I used the Hackage importer, but
> I suppose using the Stackage importer would've been a better starting
> point?

Yup!  The Stackage importer will do the right thing.

> Anyway, I can make these changes, but... I noticed the thread you
> linked to about adding hledger-web includes some of the same
> dependencies! Would you suggest that I just go ahead and fix my patch
> series, and we'll deal with any conflicts as they come up?

I think that makes sense.  There should be no big conflicts, since we’ll
end up with the LTS Haskell versions of each package either way.  The
only unfortunate thing is the duplication of work.  I guess that’s hard
to avoid with a large, distributed, and disorganized group of
volunteers.  :)

>> Besides that, there are a few minor issues in the descriptions.  Mostly
>> incomplete sentences.  It’s not a big deal as they are easy enough to
>> fix at commit time.  However, if you are going to update the patches
>> anyway...  :)
>
> Got it, I'll update those as well.

Thanks!


-- Tim




      reply	other threads:[~2020-12-04 14:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02  4:53 [bug#45000] [PATCH 0/9] Build git-annex with assistant webapp enabled Jonathan Frederickson
2020-12-02  4:55 ` [bug#45000] [PATCH 1/9] gnu: Add ghc-yesod-test Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 2/9] gnu: Add ghc-wai-app-static Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 3/9] gnu: Add ghc-yesod-static Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 4/9] gnu: Add ghc-cryptonite-conduit Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 5/9] gnu: ghc-yesod-core: Update to 1.6.18.6 Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 6/9] gnu: Add ghc-hjsmin Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 7/9] gnu: Add ghc-template-haskell Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 8/9] gnu: Add ghc-boot-th Jonathan Frederickson
2020-12-02  4:55   ` [bug#45000] [PATCH 9/9] gnu: git-annex: Build with git-annex assistant webapp enabled Jonathan Frederickson
2020-12-03 13:48     ` zimoun
2020-12-02 11:17 ` [bug#45000] [PATCH 0/9] Build git-annex with " zimoun
2020-12-03  5:32   ` Kyle Meyer
2020-12-03 20:52     ` Timothy Sample
2020-12-04  1:56       ` Jonathan Frederickson
2020-12-04 14:34         ` Timothy Sample [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1o5skrm.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=45000@debbugs.gnu.org \
    --cc=jonathan@terracrypt.net \
    --cc=kyle@kyleam.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).