From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0HsJHiBBz1/hcwAA0tVLHw (envelope-from ) for ; Tue, 08 Dec 2020 09:02:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kL/SGSBBz18zEwAAB5/wlQ (envelope-from ) for ; Tue, 08 Dec 2020 09:02:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 128BC940149 for ; Tue, 8 Dec 2020 09:02:24 +0000 (UTC) Received: from localhost ([::1]:40844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmYt5-0003HH-1X for larch@yhetil.org; Tue, 08 Dec 2020 04:02:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmYsr-0003GW-Ge for guix-patches@gnu.org; Tue, 08 Dec 2020 04:02:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmYsk-0000iu-M2 for guix-patches@gnu.org; Tue, 08 Dec 2020 04:02:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmYsk-00057e-JP for guix-patches@gnu.org; Tue, 08 Dec 2020 04:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44969] [PATCH 2/7] gnu: Added go-github-com-felixge-httpsnoop. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Dec 2020 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44969 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Martin Becze Cc: 44969@debbugs.gnu.org Received: via spool by 44969-submit@debbugs.gnu.org id=B44969.160741811919680 (code B ref 44969); Tue, 08 Dec 2020 09:02:02 +0000 Received: (at 44969) by debbugs.gnu.org; 8 Dec 2020 09:01:59 +0000 Received: from localhost ([127.0.0.1]:56541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmYsh-00057M-Cz for submit@debbugs.gnu.org; Tue, 08 Dec 2020 04:01:59 -0500 Received: from mira.cbaines.net ([212.71.252.8]:47418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmYsf-00057E-BW for 44969@debbugs.gnu.org; Tue, 08 Dec 2020 04:01:58 -0500 Received: from localhost (188.29.103.89.threembb.co.uk [188.29.103.89]) by mira.cbaines.net (Postfix) with ESMTPSA id ADAA527BC01; Tue, 8 Dec 2020 09:01:56 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 9cb79447; Tue, 8 Dec 2020 09:01:54 +0000 (UTC) References: <20201130201757.27248-1-mjbecze@riseup.net> <20201130202408.27437-1-mjbecze@riseup.net> <20201130202408.27437-2-mjbecze@riseup.net> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20201130202408.27437-2-mjbecze@riseup.net> Date: Tue, 08 Dec 2020 09:01:54 +0000 Message-ID: <87r1o0iscd.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 128BC940149 X-Spam-Score: -4.40 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: wYQ+JAf+osBZ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Martin Becze writes: > * gnu/packages/golang.scm (go-github-com-felixge-httpsnoop): New variable. So, the commit message should say Add rather than Added. This is both for consistency, and because it makes more sense for commits to say what they will do when applied, rather than reading like something's already happened. > --- > gnu/packages/golang.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index fed32d65ec..e72d7026de 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -22,6 +22,7 @@ > ;;; Copyright =C2=A9 2020 Ryan Prior > ;;; Copyright =C2=A9 2020 Marius Bakke > ;;; Copyright =C2=A9 2020 raingloom > +;;; Copyright =C2=A9 2020 Martin Becze > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -6039,3 +6040,27 @@ JSON data to the machine.") > systems can import this package to enable running programs as services w= ithout > modifying them.") > (license license:zlib))) > + > +(define-public go-github-com-felixge-httpsnoop > + (package > + (name "go-github-com-felixge-httpsnoop") > + (version "1.0.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/felixge/httpsnoop") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0ncd8lar5zxiwjhsp315s4hsl4bhnm271h49jhyxc66r5yffgmac")))) > + (build-system go-build-system) > + (arguments > + '(#:import-path "github.com/felixge/httpsnoop")) > + (home-page "https://github.com/felixge/httpsnoop/") > + (synopsis "Capture http related metric") > + (description "Httpsnoop provides an easy way to capture http > +related metrics (i.e. response time, bytes written, and http status > + code) from your application's http.Handlers.") > + (license license:expat))) Adding packages at the bottom of modules is something to try and avoid. When other patches do the same thing, it causes merge conflicts. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/PQQJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcS6g/+KpoDmbD/AbY4M2dyKD4gXWrZyi41cMH3 FIDWQ7KRxY2LFjYvfxkgq1VXoH40P4i0JL09mhFz2EafqMakvrHfdQEyhGroqcmB VF2zhmBElrLAhp0FF/obcEgidmYsySwamzUtInFFsuKqSQ8/3+rhaxH1n1yH8drz TOwHxlrJ9RiriiNzodFORZE+jp2njmyEKgrUAd+RB/lHpknFbLm1YbHqRnFJOwcx 5zlz3LSn21/5UIn4VF7XN+tXVWb8O5IoIjYy4C5dzMJiLTNN70bN6sB/au/mFab5 epNgI2f0wvXj8qij7hRJV+brNtMtG4W/Rg/mQyHpjIzvbTwi1oc2FTljHXSe0Z6d pJeFsoVczdyJzgS1IAW9wimwMwTYr7PxPmDf57OkAklVHaf4Q6LeLGrex/voSrgh 3Dzif+0xO8BF6VOKST1k8HdGqD6Ik8AFqr+kl7PpyN0ft3lpmWZSjUpPZdQLpEtb qZoRHgZROrMoDUDuW2oXj8yNwtGANqhZmWlLE1DJfVNTuEcOJ4NKo/ETEqbE2pxG qZt/pcgLCAR5exj3cmxZPAmbOyWj2/qHifjc3nmYxnDI6rANAy5jVWh1A4oGjp0W zLTXH6ZdhOwgC/Hv35ABacrnktKlhVsfo3JknrKxxycycIFjDCsvsAVNgltWGwYw nSzIPgy79mc= =GIoc -----END PGP SIGNATURE----- --=-=-=--