From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CNVoLQu7EmDPawAA0tVLHw (envelope-from ) for ; Thu, 28 Jan 2021 13:24:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4PtKKQu7EmCEbgAAB5/wlQ (envelope-from ) for ; Thu, 28 Jan 2021 13:24:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F2119403AE for ; Thu, 28 Jan 2021 13:24:27 +0000 (UTC) Received: from localhost ([::1]:40540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l57He-00076d-Ga for larch@yhetil.org; Thu, 28 Jan 2021 08:24:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l57GI-0006Fu-G5 for guix-patches@gnu.org; Thu, 28 Jan 2021 08:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l57GI-0006P4-7m for guix-patches@gnu.org; Thu, 28 Jan 2021 08:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l57GI-0006jM-20 for guix-patches@gnu.org; Thu, 28 Jan 2021 08:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45984] [PATCH 0/5] Fix recursive importers Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jan 2021 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45984 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Received: via spool by 45984-submit@debbugs.gnu.org id=B45984.161184014925811 (code B ref 45984); Thu, 28 Jan 2021 13:23:02 +0000 Received: (at 45984) by debbugs.gnu.org; 28 Jan 2021 13:22:29 +0000 Received: from localhost ([127.0.0.1]:47572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57Fk-0006iE-V8 for submit@debbugs.gnu.org; Thu, 28 Jan 2021 08:22:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l57Fi-0006hu-Rj for 45984@debbugs.gnu.org; Thu, 28 Jan 2021 08:22:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41838) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l57Fc-0006CY-Ve; Thu, 28 Jan 2021 08:22:21 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58084 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l57FV-0005Fq-Nn; Thu, 28 Jan 2021 08:22:18 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210119154525.11230-1-zimon.toutoune@gmail.com> <87ft2nwd3b.fsf@gnu.org> <86im7ji90s.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?UTF-8?Q?Pluvi=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Jan 2021 14:22:12 +0100 In-Reply-To: <86im7ji90s.fsf@gmail.com> (zimoun's message of "Wed, 27 Jan 2021 00:16:35 +0100") Message-ID: <87r1m5p56j.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45984@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7F2119403AE X-Spam-Score: -2.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: CQXj0EFyC0/s --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! zimoun skribis: > On Tue, 26 Jan 2021 at 23:24, Ludovic Court=C3=A8s wrote: > >>> $ guix import gem do-not-exist -r >>> #f >>> >>> $ ./pre-inst-env guix import gem do-not-exist -r >>> guix import: error: failed to download meta-data for package 'do-not-ex= ist' >> >> I think we do want this error message. Why should we ignore >> non-existent packages when doing =E2=80=98-r=E2=80=99? It would think t= hey=E2=80=99re still a >> problem, no? > > Do you mean instead of displaying an error about the query (what the > patch does), displaying which dependent package has failed? Something > along these lines: > > $ ./pre-inst-env guix import gem foo -r > guix import: error: failed to download meta-data for package 'bar' > > > If it is what you have in mind, it needs to really re-think how > =E2=80=99recursive-import=E2=80=99 works. Not only fixing the corner cas= e. :-) I was looking at hunks like this one: --=-=-= Content-Type: text/x-patch Content-Disposition: inline (match (fetch-elpa-package name repo) (#false - (raise (condition - (&message - (message (format #false - "couldn't find meta-data for ELPA package `~a'." - name)))))) + (values #f '())) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E2=80=A6 and I interpreted it as meaning failures would now be silently ignored. But I guess what happens is that #f is interpreted by the caller as a failure, and that=E2=80=99s how we get the =E2=80=9Cfailed to download meta= -data=E2=80=9D message, right? If so, forget my comment. Sorry for the confusion! Ludo=E2=80=99. --=-=-=--