unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#48485] [PATCH 2/2]: gnu: common-lisp-jupyter: Update to 0.1.0-3.ba9f0e7
@ 2021-05-17 19:48 Sharlatan Hellseher
  2021-05-17 19:54 ` [bug#48485] [PATCH 1/2]: gnu: Add shasht Sharlatan Hellseher
  0 siblings, 1 reply; 6+ messages in thread
From: Sharlatan Hellseher @ 2021-05-17 19:48 UTC (permalink / raw)
  To: 48485

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[-- Attachment #2: 0002-gnu-common-lisp-jupyter-Update-to-0.1.0-3.ba9f0e7.patch --]
[-- Type: text/x-patch, Size: 2254 bytes --]

From 178aab2b39001310997da838ecba33c313a92562 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Mon, 17 May 2021 20:43:47 +0100
Subject: [PATCH 2/2] gnu: common-lisp-jupyter: Update to 0.1.0-3.ba9f0e7

* gnu/packages/lisp-xyz.scm (sbcl-common-lisp-jupyter)
  [version]: Refactor format
  [inputs]: Add `dissect`, replace jsown to `shasht`
---
 gnu/packages/lisp-xyz.scm | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index ce8c61eefe..7c647c7fb2 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -14878,10 +14878,11 @@ and @code{doseq*}.")
   (sbcl-package->cl-source-package sbcl-trivial-do))
 
 (define-public sbcl-common-lisp-jupyter
-  (let ((commit "011f60b69a3b8c70eefeafe7acb724cd00dd3e62"))
+  (let ((commit "ba9f0e746b9200d6fd6db647d7274448119ed01b")
+        (revision "3"))
     (package
       (name "sbcl-common-lisp-jupyter")
-      (version (git-version "0.1" "2" commit))
+      (version (git-version "0.1.0" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -14890,7 +14891,7 @@ and @code{doseq*}.")
                (commit commit)))
          (file-name (git-file-name name commit))
          (sha256
-          (base32 "10jdghlcmp9p6ygrvw7g49i8f9jy71ybzn29n544fzb6g47siqhw"))))
+          (base32 "0si69xfzi769dprwfy7gp1x3bl7lxz6d4n98sa26w9r41wvay5ja"))))
       (build-system asdf-build-system/sbcl)
       (inputs
        `(("alexandria" ,sbcl-alexandria)
@@ -14899,13 +14900,14 @@ and @code{doseq*}.")
          ("cl-base64" ,sbcl-cl-base64)
          ("cl-indentify" ,sbcl-cl-indentify)
          ("closer-mop" ,sbcl-closer-mop)
+         ("dissect" ,sbcl-dissect)
          ("eclector" ,sbcl-eclector)
          ("ironclad" ,sbcl-ironclad)
          ("iterate" ,sbcl-iterate)
-         ("jsown" ,sbcl-jsown)
          ("multilang-documentation" ,sbcl-multilang-documentation)
-         ("pzmq" ,sbcl-pzmq)
          ("puri" ,sbcl-puri)
+         ("pzmq" ,sbcl-pzmq)
+         ("shasht" ,sbcl-shasht)
          ("static-vectors" ,sbcl-static-vectors)
          ("trivial-do" ,sbcl-trivial-do)
          ("trivial-garbage" ,sbcl-trivial-garbage)
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#48485] [PATCH 1/2]: gnu: Add shasht
  2021-05-17 19:48 [bug#48485] [PATCH 2/2]: gnu: common-lisp-jupyter: Update to 0.1.0-3.ba9f0e7 Sharlatan Hellseher
@ 2021-05-17 19:54 ` Sharlatan Hellseher
  2021-05-18  7:52   ` bug#48485: " Guillaume Le Vaillant
  2021-05-18 15:58   ` [bug#48485] " Jack Hill
  0 siblings, 2 replies; 6+ messages in thread
From: Sharlatan Hellseher @ 2021-05-17 19:54 UTC (permalink / raw)
  To: 48485

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

-- 
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.

[-- Attachment #2: 0001-gnu-Add-shasht.patch --]
[-- Type: text/x-patch, Size: 1875 bytes --]

From f99196cff24a7802f143797f7a842960fcdf2323 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Mon, 17 May 2021 20:32:18 +0100
Subject: [PATCH 1/2] gnu: Add shasht

* gnu/packages/lisp-xyz.scm (sbcl-shasht, ecl-shasht, cl-shasht): New variables.
---
 gnu/packages/lisp-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 64955a13f6..ce8c61eefe 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -16644,3 +16644,36 @@ all kind of typesetting applications.")
 
 (define-public cl-typesetting
   (sbcl-package->cl-source-package sbcl-cl-typesetting))
+
+(define-public sbcl-shasht
+  (let ((commit "4055327ef8e2aaa8627892ab256350ff3cb15e3c")
+        (revision "1"))
+    (package
+      (name "sbcl-shasht")
+      (version (git-version "0.1.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/yitzchak/shasht.git")
+               (commit commit)))
+         (file-name (git-file-name "shasht" version))
+         (sha256
+          (base32 "01mh20s5gj0lajq45anxji77ykq1wcg72mn1y9a1k8i7q1ainjlr"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       `(("alexandria" ,sbcl-alexandria)
+         ("parachute" ,sbcl-parachute)
+         ("trivial-do" ,sbcl-trivial-do)))
+      (home-page "https://yitzchak.github.io/shasht/")
+      (synopsis "Common Lisp JSON reading and writing for the Kzinti")
+      (description
+       "This package provides a Common Lisp library to work with JSON file
+format.")
+      (license license:expat))))
+
+(define-public ecl-shasht
+  (sbcl-package->ecl-package sbcl-shasht))
+
+(define-public cl-shasht
+  (sbcl-package->cl-source-package sbcl-shasht))
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#48485: [PATCH 1/2]: gnu: Add shasht
  2021-05-17 19:54 ` [bug#48485] [PATCH 1/2]: gnu: Add shasht Sharlatan Hellseher
@ 2021-05-18  7:52   ` Guillaume Le Vaillant
  2021-05-18 15:58   ` [bug#48485] " Jack Hill
  1 sibling, 0 replies; 6+ messages in thread
From: Guillaume Le Vaillant @ 2021-05-18  7:52 UTC (permalink / raw)
  To: Sharlatan Hellseher; +Cc: 48485-done

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Patches pushed as ff11a9f449e2f259faabebd075ce2ae1e13d27c2 and following
with a few modifications:
 - shasht: alexandria and parachute moved to native-inputs as they are
   only used for the tests.
 - common-lisp-jupyter: license changed to expat/MIT as this is what is
   indicated upstream.

Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#48485] [PATCH 1/2]: gnu: Add shasht
  2021-05-17 19:54 ` [bug#48485] [PATCH 1/2]: gnu: Add shasht Sharlatan Hellseher
  2021-05-18  7:52   ` bug#48485: " Guillaume Le Vaillant
@ 2021-05-18 15:58   ` Jack Hill
  2021-05-18 16:40     ` Guillaume Le Vaillant
  1 sibling, 1 reply; 6+ messages in thread
From: Jack Hill @ 2021-05-18 15:58 UTC (permalink / raw)
  To: Sharlatan Hellseher; +Cc: Guillaume Le Vaillant, 48485

Thanks for working on this. However, I have a question about the synopsis:

> +      (synopsis "Common Lisp JSON reading and writing for the Kzinti")

As a native American English speaker, I find Kzinti to be an obscure word. 
I didn't know what it meant when I first read it. Doing a search online 
wasn't that enlightening. The best thing I could fine talked about alien 
cats [0]. Do you think the synopsis could be improved in the future to 
more clearly say what the software is for and improve search results? 
Perhaps shortening it to "Common Lisp JSON reading and writing" would be 
sufficient?

[0] https://en.wikipedia.org/wiki/Kzin

Best,
Jack




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#48485] [PATCH 1/2]: gnu: Add shasht
  2021-05-18 15:58   ` [bug#48485] " Jack Hill
@ 2021-05-18 16:40     ` Guillaume Le Vaillant
  2021-05-18 16:50       ` Jack Hill
  0 siblings, 1 reply; 6+ messages in thread
From: Guillaume Le Vaillant @ 2021-05-18 16:40 UTC (permalink / raw)
  To: Jack Hill; +Cc: 48485, Sharlatan Hellseher

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Jack Hill <jackhill@jackhill.us> skribis:

> Thanks for working on this. However, I have a question about the synopsis:
>
>> +      (synopsis "Common Lisp JSON reading and writing for the Kzinti")
>
> As a native American English speaker, I find Kzinti to be an obscure word.
> I didn't know what it meant when I first read it. Doing a search online 
> wasn't that enlightening. The best thing I could fine talked about alien cats
> [0]. Do you think the synopsis could be improved in the future to more clearly
> say what the software is for and improve search results? Perhaps shortening it
> to "Common Lisp JSON reading and writing" would be sufficient?
>
> [0] https://en.wikipedia.org/wiki/Kzin
>
> Best,
> Jack

Before pushing Sharlatan's patch, I changed the synopsis to "Common Lisp
JSON reading and writing library". I also didn't know that word, found
that it was probably a reference to a cat-looking warrior from space in
a series of science fiction novels, and concluded that it was not
really related to JSON processing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#48485] [PATCH 1/2]: gnu: Add shasht
  2021-05-18 16:40     ` Guillaume Le Vaillant
@ 2021-05-18 16:50       ` Jack Hill
  0 siblings, 0 replies; 6+ messages in thread
From: Jack Hill @ 2021-05-18 16:50 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: 48485, Sharlatan Hellseher

On Tue, 18 May 2021, Guillaume Le Vaillant wrote:

> Jack Hill <jackhill@jackhill.us> skribis:
>
>> Thanks for working on this. However, I have a question about the synopsis:
>>
>>> +      (synopsis "Common Lisp JSON reading and writing for the Kzinti")
>>
>> As a native American English speaker, I find Kzinti to be an obscure word.
>> I didn't know what it meant when I first read it. Doing a search online
>> wasn't that enlightening. The best thing I could fine talked about alien cats
>> [0]. Do you think the synopsis could be improved in the future to more clearly
>> say what the software is for and improve search results? Perhaps shortening it
>> to "Common Lisp JSON reading and writing" would be sufficient?
>>
>> [0] https://en.wikipedia.org/wiki/Kzin
>>
>> Best,
>> Jack
>
> Before pushing Sharlatan's patch, I changed the synopsis to "Common Lisp
> JSON reading and writing library". I also didn't know that word, found
> that it was probably a reference to a cat-looking warrior from space in
> a series of science fiction novels, and concluded that it was not
> really related to JSON processing.

Happy to here that I wasn't alone in thinking that. I guess it's time to 
`guix pull` and benefit from the new packages.

Thanks!
Jack




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-05-18 16:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-17 19:48 [bug#48485] [PATCH 2/2]: gnu: common-lisp-jupyter: Update to 0.1.0-3.ba9f0e7 Sharlatan Hellseher
2021-05-17 19:54 ` [bug#48485] [PATCH 1/2]: gnu: Add shasht Sharlatan Hellseher
2021-05-18  7:52   ` bug#48485: " Guillaume Le Vaillant
2021-05-18 15:58   ` [bug#48485] " Jack Hill
2021-05-18 16:40     ` Guillaume Le Vaillant
2021-05-18 16:50       ` Jack Hill

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).