From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iMKGC2MRKmHfJwEAgWs5BA (envelope-from ) for ; Sat, 28 Aug 2021 12:35:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +ONJB2MRKmG9HgAAB5/wlQ (envelope-from ) for ; Sat, 28 Aug 2021 10:35:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC14AFA3 for ; Sat, 28 Aug 2021 12:35:14 +0200 (CEST) Received: from localhost ([::1]:57340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJvg9-00034Y-2E for larch@yhetil.org; Sat, 28 Aug 2021 06:35:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJvfy-00034P-T3 for guix-patches@gnu.org; Sat, 28 Aug 2021 06:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJvfy-0005rI-LW for guix-patches@gnu.org; Sat, 28 Aug 2021 06:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJvfy-0002r0-Eb for guix-patches@gnu.org; Sat, 28 Aug 2021 06:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50077] [PATCH 1/3] gnu: notmuch: Add separate 'emacs' output. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Aug 2021 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50077 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 50077@debbugs.gnu.org Received: via spool by 50077-submit@debbugs.gnu.org id=B50077.163014689910958 (code B ref 50077); Sat, 28 Aug 2021 10:35:02 +0000 Received: (at 50077) by debbugs.gnu.org; 28 Aug 2021 10:34:59 +0000 Received: from localhost ([127.0.0.1]:53452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJvfr-0002qc-6R for submit@debbugs.gnu.org; Sat, 28 Aug 2021 06:34:59 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:44582 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJvfk-0002qI-Tp for 50077@debbugs.gnu.org; Sat, 28 Aug 2021 06:34:53 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1630146878; bh=InNYTCiS7BH/2UNCbDq4yHrqFvBU+9qpga/u1aNA0nw=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=hRo2DtDGN868yhAS5eWU3Z1Ew+IkwKEjbRVDsZw7cr4RVHfC+9vzmtzIug6Xhi1T/ oWXUVfu03WjGi/mma8Q61LbCjkYkhTbs+F93DYnFa2lcyMyoq+rL+Oh9Wt7qgn7BbW nn+T91FgNh2I+FRMneqlCbEqa320PqNvSjcI0g54= In-Reply-To: <87o89owoi0.fsf@trop.in> References: <87o89owoi0.fsf@trop.in> Date: Sat, 28 Aug 2021 12:34:16 +0200 Message-ID: <87r1edvown.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630146914; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=uJKNtJ7FCH0fa5hrwVGyhFqPz77wclNW2zRKXEyqnDw=; b=LLSU83Ax4+OYTnRIbN+RfIQ/zXao2XUkGvo2Tz4b/gwpY3hBil7qakwR819Q4hiZpRCBFe 0J9aEJ3dEtm4kxpiS/LDIZmIuNdv55lsY9e/CWrtd9GsnQkcIJ9oCSnXexDNNM6X3wqVyy RIkElng/QyIPNwyG/NFKeJUrV+Y1Dhfx0CI+R682yQlBMZ9o0TAMkgmW9b77/Bs/YaQiRY waSWK0uZKGo8+vbYu6aD+BgkzZhcm6ji+m9sK2fFPd829GSIuFiJVQVS9kdCIiVTecGHSI k7niyCFA8XyrHqrHr2sg61MzbK0a+EwaRRrml/dyE4/5Jqj3htInV/PAna/Alw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630146914; a=rsa-sha256; cv=none; b=I5r6WoagTiC48lvXDEEvgGoTNHY7rLX0r6RfzWyznfzr9PK/nCNeKGbzmMtIQ2ADRindW7 432hQzb+I4x9kd068cUZ4LJI6evJaoevwIZB0gEq2K3BMLDHVoO2jBwuqYZxBhvAWGfnzc P5ZAfdml/+KaiNczsaWheAG+ahPUE30u0PiHzCMh1PCcR7qJKKAM3IZWfz2p+WCfxWjn/H iq1GoI9kq6N7fXg4NTyNmVg+nRClAAMtIMX7EMd+/QyMl4zZ1qZQHzpSDbcb0z92Akczco A7SHvhc1f479xysDe/lD66gpVfOYaZilE4jTCLBWUjtPHjczukLvMwLHsCG3Vg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=hRo2DtDG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=hRo2DtDG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: AC14AFA3 X-Spam-Score: -1.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: PgNThpPuRpog --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [ Debbugs wasn=E2=80=99t Cc=E2=80=99d in the previous message ] On Mon, Aug 23 2021, Andrew Tropin wrote: > On 2021-08-16 16:12, Xinglu Chen wrote: > >> * gnu/packages/mail.scm (notmuch)[outputs]: Add =E2=80=98emacs=E2=80=99 = output >> [arguments]<#:modules>: Add (guix build emacs-utils). >> <#:phases>{configure}: Use the =E2=80=98emacs=E2=80=99 output. >> {make-autoloads}: Modify the default =E2=80=98make-autoloads=E2=80=99 ph= ase to use the =E2=80=98emacs=E2=80=99 >> output. >> --- >> gnu/packages/mail.scm | 16 +++++++++++++--- >> 1 file changed, 13 insertions(+), 3 deletions(-) >> >> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm >> index ccf44b7cf3..bbc616f6f5 100644 >> --- a/gnu/packages/mail.scm >> +++ b/gnu/packages/mail.scm >> @@ -1337,7 +1337,8 @@ invoking @command{notifymuch} from the post-new ho= ok.") >> (arguments >> `(#:modules ((guix build gnu-build-system) >> ((guix build emacs-build-system) #:prefix emacs:) >> - (guix build utils)) >> + (guix build utils) >> + (guix build emacs-utils)) >> #:imported-modules (,@%gnu-build-system-modules >> (guix build emacs-build-system) >> (guix build emacs-utils)) >> @@ -1355,7 +1356,8 @@ invoking @command{notifymuch} from the post-new ho= ok.") >> (setenv "CONFIG_SHELL" (which "sh")) >>=20=20 >> (let* ((out (assoc-ref outputs "out")) >> - (elisp (emacs:elpa-directory out))) >> + (emacs (assoc-ref outputs "emacs")) >> + (elisp (emacs:elpa-directory emacs))) >> (invoke "./configure" >> (string-append "--prefix=3D" out) >> (string-append "--emacslispdir=3D" elis= p) >> @@ -1373,7 +1375,14 @@ invoking @command{notifymuch} from the post-new h= ook.") >> (substitute* (find-files "test" "\\.sh$") >> (("/bin/sh") (which "sh"))))) >> (add-after 'install 'make-autoloads >> - (assoc-ref emacs:%standard-phases 'make-autoloads))= ))) >> + (lambda* (#:key outputs inputs #:allow-other-keys) >> + (let* ((emacs (string-append (assoc-ref inputs "e= macs") "/bin/emacs")) >> + (out (assoc-ref outputs "emacs")) >> + (elpa-name-ver ((@@ (guix build emacs-buil= d-system) >> + store-directory->elpa-= name-version) out)) >> + (elpa-name (package-name->name+version elp= a-name-ver)) >> + (el-dir (emacs:elpa-directory out))) >> + (emacs-generate-autoloads elpa-name el-dir)))))= )) >> (native-inputs >> `(("bash-completion" ,bash-completion) >> ("emacs" ,emacs-no-x) ; -minimal lacks libxml, needed for som= e tests >> @@ -1394,6 +1403,7 @@ invoking @command{notifymuch} from the post-new ho= ok.") >> ("talloc" ,talloc) >> ("xapian" ,xapian) >> ("zlib" ,zlib))) >> + (outputs '("out" "emacs")) >> (home-page "https://notmuchmail.org/") >> (synopsis "Thread-based email index, search, and tagging") >> (description > > The separate output is ok, but I think making a separate emacs-notmuch > package looks more consistent. We can inherit it from notmuch package > to be sure that the packages are built from the same source code. Why would it be more consistent to make a separate package? Making a separate package is usually used for packaging a slightly different version of the =E2=80=9Cregular=E2=80=9D package, e.g., =E2=80=98emacs-next= -pgtk=E2=80=99 adds native compilation and pure GTK support for Emacs., =E2=80=98emacs-no-x=E2=80=99 r= emoves X suport for =E2=80=98emacs=E2=80=99. =E2=80=98emacs-notmuch=E2=80=99 isn=E2= =80=99t really a different version of =E2=80=98notmuch=E2=80=99, it=E2=80=99s just =E2=80=98notmuch=E2=80=99 but = with all the non-Elisp stuff removed. This is usually what using different outputs tries to achieve, e.g., separate documentation from the main package, or in this case, separate Elisp stuff from the main package. The =E2=80=98notmuch=E2=80=99 package in Nixpkgs also uses multiple outputs= [1], which I think makes sense. > > Thank you for working on this, the changes are good and useful!) You are welcome! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmEqESgVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5kZcP/RTgDyBP+weLceLnv5Xo6z4wvR1y mpqjSSoz7xEKazB7JGNkjKx+1Xcz15AcC1VOAyGUPJdBUGTbHtp1jSIMcmwCY5Xb dNUlv+aGXZzQdKzMw2lTRxe4JPKq6fbIZN9aIhezCAX8oojDI8LIuRK4H6onZzkt NijrdN09oYkfEsHTDXdoDu/EZNV25MH3MAW4lVQKnpwZIDqj6m3A46Z/2jvMFeoH HaXQUD6ZJc4zN1n1tklds09hYyHeR+0ijBG33HmZ8KQloaOx+9J2k9AO326i3R2Y Evjqt1DL3RoaCMqwSXIsxKBZmJj84YJZm2MxmZz8wGWdxf5AzpFzdmWl4svaPS2T nCRrjf3M0PvW+eNUagLAnF186p3alC9incQqq/o9aOeri7YggHkoxQL/drHFlEik 93589LuGBa+cyaXIjV4t9hD7O47/sZyudT5kwIsDnyo+QZMTeMH/Mo9fPN7YhORm 0Am3niBcEMc0lZ6zNWQyupU4UdtLrgOcltJYYOH29wA5DrSb5WlM9rQZTu6O4PkD HLlsa75O4e9OiENSllJClA/lM3dSmPp+VCWH08I5i1yduDaJ28EbF45Dwxh1Bgxx P4LgB6XhBdGcsi2AFnF+worHqIv9qshfwBzLU10Qcxy3rvFTC+HDZ41JZtIlYPhK 2EdnAyHscS2FFONS =kd3P -----END PGP SIGNATURE----- --=-=-=--