From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SMiPBdsVV2FOCgAAgWs5BA (envelope-from ) for ; Fri, 01 Oct 2021 16:06:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0JM2AdsVV2FSXQAAB5/wlQ (envelope-from ) for ; Fri, 01 Oct 2021 14:06:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C23A32E34 for ; Fri, 1 Oct 2021 16:06:18 +0200 (CEST) Received: from localhost ([::1]:49040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWJB3-0002XE-Vm for larch@yhetil.org; Fri, 01 Oct 2021 10:06:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWJAo-0002MF-W7 for guix-patches@gnu.org; Fri, 01 Oct 2021 10:06:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45245) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWJAo-0002oc-96 for guix-patches@gnu.org; Fri, 01 Oct 2021 10:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWJAo-00056C-4W for guix-patches@gnu.org; Fri, 01 Oct 2021 10:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50887] [PATCH] gnu: Add python-fitsio. References: Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Oct 2021 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50887 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Konrad Hinsen , 50887@debbugs.gnu.org Received: via spool by 50887-submit@debbugs.gnu.org id=B50887.163309715319578 (code B ref 50887); Fri, 01 Oct 2021 14:06:02 +0000 Received: (at 50887) by debbugs.gnu.org; 1 Oct 2021 14:05:53 +0000 Received: from localhost ([127.0.0.1]:56791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWJAf-00055h-0X for submit@debbugs.gnu.org; Fri, 01 Oct 2021 10:05:53 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:50386 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWJAd-00055O-5U for 50887@debbugs.gnu.org; Fri, 01 Oct 2021 10:05:51 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1633097145; bh=8y82Dee5zwESpsWWC0dt1IhhkAb9W0YhooCYBULMTtI=; h=From:To:Subject:In-Reply-To:Date; b=QhiQ3m6bO4hUfPwYvUXsQDJxRnFvt1KsbhjRM5Fs+KJPk1XtMxwf96Isvw5+Rdbd5 B0eDEZ6OEo4uaaq3ZE6WK9g1So0fnRqM6dc/RvMkr9xTOvSJDsX2ntQrWxfucb/KvN gRJCdk+CwAyQPD4zN8Hk1aXjWptopi34QZ0iKBL8= In-Reply-To: Date: Fri, 01 Oct 2021 16:05:44 +0200 Message-ID: <87r1d4lu13.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633097178; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=YIh3SgkOIQ66/rYFb6YiwaySsuOlhKG3K2g7n6jD4CQ=; b=XqyyEcN30GCyIZ05syV2RuSpUqm6E9/CrJVsKMQrS4kVDZNjP+8MPIwx729kXJd1wTAb+X iWGA2WkNHTuY7y/odi9Fp9CqZeCg3mTL2zmlviiXBA2MH01WYfBpNDxX5ydXGasFz0KwG1 ZAQ6QWytWFMi/ALj2CEdH3j6spG6KgdqFltdzIE7UpdUiEYYVPpRoIo11RXAx/OmuSPrpf hmhbmTgZPfCs6gwwiyUIpVFjH+NfqQ+NeuViRIL2zwSSAl+M7qzFCUXEFqm+erYBsDc21K 7Pro2NMwDtC8WgJZmGGMFEO28hdW8bFVIaSbnisFXJQZPPO/eY8Zx4wsMmNAcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633097178; a=rsa-sha256; cv=none; b=uKZL6rySF8Xz8XaAcPufajBtT0wEdcicTP5ZQllXKY2PpGnBH9DJ/9wwTA24vFOjYtiZlP ywLe5uYFlOF0GHvf4B30+KnJXKUCnqeE5fYybNdnSdnhuPx8R3sobLf0GBXwpNS2ymTCCZ 5Jhzm6YGwFnX4HNMXtG5KrP44EnsaqJVYOIfIXzTfiYsSWnUlBiOWCm4lmXB6lD99swNY+ qGgyCQYL1f5d16rAdN3hETsDp2j6a2cZR9/xhwLz4/kFaqRymXkpGwToULKBjym4/gsDfP QPmZuApGMjMzhqP5z5vUIS9+n5iL/MCyYg16xuf6295AM/ifN64coHXv8ivCVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=QhiQ3m6b; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.80 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=QhiQ3m6b; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C23A32E34 X-Spam-Score: -3.80 X-Migadu-Scanner: scn1.migadu.com X-TUID: DiJOn5e2OJfg --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 29 2021, Konrad Hinsen wrote: > * gnu/packages/astronomy.scm (python-fitsio): New variable. > --- > gnu/packages/astronomy.scm | 43 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > index a3f7d5cbf4..4fba3aae99 100644 > --- a/gnu/packages/astronomy.scm > +++ b/gnu/packages/astronomy.scm > @@ -96,6 +96,49 @@ in FITS files.") > (license (license:non-copyleft "file://License.txt" > "See License.txt in the distribution.")))) >=20=20 > +(define-public python-fitsio > + (package > + (name "python-fitsio") > + (version "1.1.5") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "fitsio" version)) > + (sha256 > + (base32 "1llql2i6xr9lkdl81jx5nvz80kspamvira90546y32ldy551hq1l"))= )) > + (build-system python-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'unbundle-cfitsio > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((cfitsio (assoc-ref inputs "cfitsio")) > + (includedir (string-append "\"" cfitsio "/include\""= )) > + (libdir (string-append "\"" cfitsio "/lib\""))) > + ;; Use Guix' cfitsio instead of the bundled one > + (substitute* "setup.py" > + (("self.use_system_fitsio =3D False") "pass") > + (("self.system_fitsio_includedir =3D None") "pass") > + (("self.system_fitsio_libdir =3D None") "pass") > + (("self.use_system_fitsio") "True") > + (("self.system_fitsio_includedir") includedir) > + (("self.system_fitsio_libdir") libdir))) Maybe the bundled cfitsio should also be deleted in a =E2=80=98snippet=E2= =80=99 in the =E2=80=98origin=E2=80=99? > + ;; The bzip2 test fails because Guix' cfitsio > + ;; is built without bzip2 support. > + (substitute* "fitsio/test.py" > + (("'SKIP_BZIP_TEST' in os.environ") "True")) This part should probably be put in a separate phase, maybe you could call it =E2=80=98skip-bzip-test=E2=80=99. > + #t))))) Phases don=E2=80=99t need to return #t. > + (propagated-inputs > + `(("python-numpy" ,python-numpy) > + ("cfitsio" ,cfitsio))) > + (home-page "https://github.com/esheldon/fitsio") > + (synopsis > + "Python library to read from and write to FITS files") > + (description > + "A compact Python library for reading from and writing to FITS file= s, > +based on the CFITSIO library.") The sentence is lacking a subject; the meaning of =E2=80=9CFITS=E2=80=9D sh= ould be written (I had no idea what it meant). I suggest something like This package provides a Python library for reading from and writing to @acronym{FITS, Flexible Image Transport System} files using the CFITSIO library. Among other things, it can @itemize @item read and write image, binary, and ascii table extensions; @item read arbitrary subsets of tables in a lazy manner; @item query the rows and columns of a table; @item read and write header keywords; @item read and write Gzip files directory; @item read Zip and Bzip2 files. @end itemize > + (license license:gpl2))) =E2=80=98LICENSE.txt=E2=80=99 looks like gpl2+ Could you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFXFbgVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5FcwQAJ9m3sKsIAHjtkpccXgU1XBnF/8k uHLZJ//ggjVgYK8kZLuGUj+cYuoKLMgxNEl2b//UnKpulxzpNRzQ9RAFcqFms9sy ShywjgdF89hqEBSR+eqgEgX2gqceRvjInpFqdQ7KSxX5FRZJ+x1s4jO+KP6A/Pef loup0IAKW0iYAs/hBpj6uX0CrS0vJxkJCOIepVcZK2cfVbSSdrOiZfXO7tptfoq9 WItvA0VRxgT5SL9gVkhwz2/b4w1lOHo15mxHfAmlbB2uefcPHSwvIAFOztWxIyf0 7PTrvPe8hTCKMmYSlJwxpaFoLwrq8+YV7qWedif2CItLUJ5q1SRqcYcBPj0vTyz0 B/OjPl523O06nJkJ+PFUm2VYMGDM0ChlBj0y/i2f/GJIgXL/eKhhof4IK3PfEwxY ZOvK9ktgPcFLo7ebzVDzhjICQnGlHU28aAqo0KhtAAD2BjCiawqzOqm26SN+MbwY boa6uwUdsv4g9CWgRcdjhPqZgBkqaeh+8JN1mSo8BBHUEDpxj1OFbrGekPfi8k2b 8ePBj6p+IEkTpnJesqazmDxCZHFo97MEOdgc1J4shKwrMgtux/jF8jTtVREbjjTF TAIfbal97RBFt2hKaGP77EY/jGa/iJvVfFG3YigaxTIumDzVXWlQghXrTauc2wBt MWIvt8klIfAiv3v5 =y5x9 -----END PGP SIGNATURE----- --=-=-=--