From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eOsSKntbZWHb5QAAgWs5BA (envelope-from ) for ; Tue, 12 Oct 2021 11:55:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +G/SJHtbZWF9fgAAbx9fmQ (envelope-from ) for ; Tue, 12 Oct 2021 09:55:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6123F2ADFC for ; Tue, 12 Oct 2021 11:55:07 +0200 (CEST) Received: from localhost ([::1]:57490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maEV0-0000qk-FZ for larch@yhetil.org; Tue, 12 Oct 2021 05:55:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maEGQ-0000yi-Ej for guix-patches@gnu.org; Tue, 12 Oct 2021 05:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maEGQ-0007kj-5U for guix-patches@gnu.org; Tue, 12 Oct 2021 05:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maEGP-0000g1-Vp for guix-patches@gnu.org; Tue, 12 Oct 2021 05:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50814] [PATCH] guix: git-authenticate: Also authenticate the channel intro commit. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Oct 2021 09:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 50814@debbugs.gnu.org Received: via spool by 50814-submit@debbugs.gnu.org id=B50814.16340316002589 (code B ref 50814); Tue, 12 Oct 2021 09:40:01 +0000 Received: (at 50814) by debbugs.gnu.org; 12 Oct 2021 09:40:00 +0000 Received: from localhost ([127.0.0.1]:33521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maEGO-0000fh-76 for submit@debbugs.gnu.org; Tue, 12 Oct 2021 05:40:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maEGM-0000fU-9u for 50814@debbugs.gnu.org; Tue, 12 Oct 2021 05:39:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57240) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maEGG-0007eg-Bs; Tue, 12 Oct 2021 05:39:52 -0400 Received: from [193.50.110.91] (port=34608 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maEGE-00020K-G6; Tue, 12 Oct 2021 05:39:51 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210926101928.3877-1-attila@lendvai.name> <878rz2xq23.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 =?UTF-8?Q?Vend=C3=A9miaire?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 12 Oct 2021 11:39:48 +0200 In-Reply-To: (Attila Lendvai's message of "Sat, 09 Oct 2021 15:31:08 +0000") Message-ID: <87r1cqwpi3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634032507; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ORsKtOZPZin3A6sXcbAGA53a6n0vMeJuqa6Zfw56VOg=; b=YArdiScpXmA5XrocfIOeiJxb/aEWPtQWXcwmBZ5Gq9iNOSw9IdoM/w9IZWZ7ZfJ64C9Mmj jyLgadOxTGIhUo5HQVBk2ievs7DJRKOvCKmMz8rjrMKD6nTrzwgGfP4IFQNFgpkhlzP+of uhX6IyDH3yb0xcbuE6pbHRulchHMTWNvHQsMCv5r3Fs+8VZRG+gd8hIl+47G8AWRxstOkI nTykQo9PWYpsRpUHR5yzAdoIY4+f25xWpTrki2V6vlwVg5z2Hr1eXN9mC4i1YphAIZONIJ UbKojbGstM4CWNFT4wGoout84Cd031Ub3mQphpcWH4lyi+saChoPYNZg2+0VtA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634032507; a=rsa-sha256; cv=none; b=JuaK8AxoNOIaOTd93CVWN8DAQp7y6W8vSLLazwUs3vfcZtRowwzYGxFrkQZ8bbDHFnzgbM K6vVQKJIFvCdnaFvpEBcoeeaVBjs5JxPUrVhHw26K3P0lVf71pcHlmF2JU5k74iPuHDIOg k8dF35pEw5800PcFXuJmLqNQaBadmSXdktdEfrpkZCpgfxl0hV04bCRet9Ep1q5Yi6JcaY b0drC5vQCvrR3HrHuxvkkZWA7/9i0lZCc2m8YvVe+c+XPVxH/uiuKs1RsGvdSCS8OFL6Us IatWUZUCVs5T0JIJ6pqchh0meZChIa0vUUP0f2bwUJZuEKPHcoFdbb4VwunXlg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6123F2ADFC X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: /0UPxtwpPcKe Hi, Attila Lendvai skribis: > there are three main topics of this patchset: > > 1) adding a (hopefully helpful) warning. the primary goal. > 2) general cleanups > 3) IIRC, fixing some actual bugs in the process Alright. Please next time open one issue per topic: that=E2=80=99s a good = way to maximize the chances that review happens in a timely fashion. :-) > as for 1): > > what i did was fork guix master, and now i'm pulling my own > authenticated branch from my own local git checkout, where every once > in a while i merge my various topic branches into my branch, and guix > pull it. > > when i added my second commit i have spent a disproportionate amount > of time trying to figure out what was happening: the first commit was > accepted, and i thought it's set up all fine. then who knows how much > later, when i added my second commit, i was staring at the screen > without a clue why pulling doesn't work anymore. > > then i ventured into quickly adding warning, so that others won't > waste their time on this, and went down the rabbit hole, which > resulted in fixing actual bugs, i believe. IIRC, they are exposed by > the test that i have added when run on the current codebase. I understand the behavior was surprising to you, but I=E2=80=99d like to se= e if we can pinpoint why. Can you think of anything that could be added to the documentation? https://guix.gnu.org/manual/en/html_node/Specifying-Channel-Authorization= s.html > as for 3), any actual bugs: > > i'll investigate again later by running the test without the fix, and wri= te > up my results here, or better yet, in a better commit message. Yes please. In general, please start by reporting the bug: what you get, what you expected, and how to reproduce. That makes it easier to understand and evaluate proposed fixes. Thanks! Ludo=E2=80=99.