From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eBiNClyznGFBMAEAgWs5BA (envelope-from ) for ; Tue, 23 Nov 2021 10:24:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KLhVBlyznGHnJgAA1q6Kng (envelope-from ) for ; Tue, 23 Nov 2021 09:24:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8EABE585 for ; Tue, 23 Nov 2021 10:24:43 +0100 (CET) Received: from localhost ([::1]:44218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpS2c-0006V5-CO for larch@yhetil.org; Tue, 23 Nov 2021 04:24:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpS1y-0006T4-Kp for guix-patches@gnu.org; Tue, 23 Nov 2021 04:24:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38443) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpS1y-0007ls-CU for guix-patches@gnu.org; Tue, 23 Nov 2021 04:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpS1y-0007P8-9o for guix-patches@gnu.org; Tue, 23 Nov 2021 04:24:02 -0500 Subject: bug#51346: [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 23 Nov 2021 09:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51346 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: Tobias Geerinckx-Rice , 51346-done@debbugs.gnu.org Mail-Followup-To: 51346@debbugs.gnu.org, ludo@gnu.org, dev@jpoiret.xyz Received: via spool by 51346-done@debbugs.gnu.org id=D51346.163765942128431 (code D ref 51346); Tue, 23 Nov 2021 09:24:02 +0000 Received: (at 51346-done) by debbugs.gnu.org; 23 Nov 2021 09:23:41 +0000 Received: from localhost ([127.0.0.1]:49988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpS1d-0007OU-4O for submit@debbugs.gnu.org; Tue, 23 Nov 2021 04:23:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpS1X-0007OC-Jj for 51346-done@debbugs.gnu.org; Tue, 23 Nov 2021 04:23:39 -0500 Received: from [2001:470:142:3::e] (port=39322 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpS1S-0007k8-C0; Tue, 23 Nov 2021 04:23:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=hSV29mN02cMuhNyE+p0cv2bK8p+lrGRTcTbGawRNc5w=; b=qHCZ29G0MUt9G+TU0CIV /BGO1cHqePvciMjyAR0lSkBCIf7cZ3oMq9QX1qpv1I048oFu34+mm5WSCa9qSevEwG7R92mrc3/lQ LPRysqWmEFEgHiXRt7z4cXk4H2nM1wUmBUEwRquIfyvEMp+H5Y1tWcdM0JHC1GxZpME/sw3mfb+jF 47NeE1QaGToCpcQWWGYHTlkeod8lDBxYSDwAfCHTIovw6L0T3K9G8by7w5J2fbj8qo9R6gAW3LRNj rTL06/v6e/JP1LvGkd65rHspKZTqfmTO/JtxYOxT7sdAeTNp34UMJq8i6fs1dovrkRWArBWDfrQqF BLSSyIzSTiCbXw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62055 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpS1S-00008Z-6J; Tue, 23 Nov 2021 04:23:30 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y25p65on.fsf_-_@gnu.org> <20211115202631.6032-1-dev@jpoiret.xyz> Date: Tue, 23 Nov 2021 10:23:27 +0100 In-Reply-To: <20211115202631.6032-1-dev@jpoiret.xyz> (Josselin Poiret's message of "Mon, 15 Nov 2021 20:26:26 +0000") Message-ID: <87r1b7jkds.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637659483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hSV29mN02cMuhNyE+p0cv2bK8p+lrGRTcTbGawRNc5w=; b=gAwElNd2bfKY3CYkechTL38yTub/OJDrpT7CoVcMdtFEpd0nrQQq3RwEHK8DHVOkO0EPRY XMKmEs5bGSRcyDisHHz9jWjo6bc4NGMNTYf5uGCzPz8901DS2ugEKAGTxZrv3YdDNH55Os B8Eb5CNhk6QBMneDLogGv4NrbJiKRkIUQElRO/KVPdmWglyZq2IjJ1ua35N2NnCxymLE0H BbTzmNWv/x65JDjTNFHyjMTi6NGVvNN7LMG9HrA8q1mCRk+bXUcKw3XCOiHcaO/75etTlN bAwwvdhWGcTSCBSeWwr/GDTtOHLWCOLE03sEzmeyXjP9IRaLxFNIFlbwwymhZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637659483; a=rsa-sha256; cv=none; b=RjJXjQe7Mj1xCWhuwPmKC5UCwLMRRbyUu/1Yc3SoyAnYI6BJILqHta9z3C8YmOidYr/foe /izvUBkSD/8mCCzlIC+UFhytUbjHdKaRcKGWezfRDAtul4DDwL0DgDXuv0bD8QN7uQjDCU gFa49YAxsVtlW7ps2csb71xJBoWM1AmpIW9P8yP6PLtDAl081rFfhX9HDUHANeVbOjNuWc kjvC1WgPyhs2gqyvXI9TOdzb0zBXk7b3MvNKd+4bKvZx3B0I8UFRkJx9YbPeRXOQFTekJw Iv9XV0eaz0St3mMScWXACgCg4uhn9vdKEcaR002RRjb4f2ILtlwd3TNJVR/neA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=qHCZ29G0; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=qHCZ29G0; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8EABE585 X-Spam-Score: -3.58 X-Migadu-Scanner: scn1.migadu.com X-TUID: 9SaHJwnpVk2w Hi Josselin, Josselin Poiret skribis: > Thanks for the review! Here is hopefully the last patchset, which > addresses most of the issues. > > I decided not to merge the doc changes with the first commit as it > also describes swap flags, but that's just a matter of taste I > suppose. > > Moved the deprecation warning that I originally put in > gnu/services/base.scm (swap-service) to a sanitizer of swap-devices in > its own commit, although it only reports the location of the > (operating-system) syntax use, not of the field itself (but that is > what I also noticed for other deprecation warnings, alas). I marked > the field as delayed, otherwise I was getting a lot of warnings while > testing rather than the only one I'm getting now. I suppose this can be addressed with this newfangled =E2=80=98define-with-syntax-properties=E2=80=99, right? :-) > Fixed the swap-device dependency filtering to silently ignore > old-style values rather than erroring out. > > Overall, I cleaned up all the rogue TABs I had inserted! > (setq-default indent-tabs-mode nil) for our Emacs readers at home. > This should not happen any more as I have set whitespace-mode to an > aggressive red highlighting for TAB characters. Nice. Note that =E2=80=98.dir-locals.el=E2=80=99 is supposed to set that; = not sure why it didn=E2=80=99t work for you. > And finally, I changed the examples at the end to simply be @lisp > blocks, outside of a table. > > Josselin Poiret (5): > gnu: system: Rework swap space support, add dependencies. > gnu: system: Warn about swap-devices format change > gnu: system: Add swap flags. > gnu: system: Filter out boot dependencies from swap-space. > doc: Add new Swap Space section. Applied on =E2=80=98master=E2=80=99, which I plan to merge into =E2=80=98co= re-updates-frozen=E2=80=99 shortly. Thank you! Ludo=E2=80=99.