From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2L6XJvYI6mFzsgAAgWs5BA (envelope-from ) for ; Fri, 21 Jan 2022 02:14:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id UJhcH/YI6mG/VwEAG6o9tA (envelope-from ) for ; Fri, 21 Jan 2022 02:14:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34AF714B88 for ; Fri, 21 Jan 2022 02:14:30 +0100 (CET) Received: from localhost ([::1]:42678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAiVY-0000nY-Di for larch@yhetil.org; Thu, 20 Jan 2022 20:14:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAgmh-0000ma-D0 for guix-patches@gnu.org; Thu, 20 Jan 2022 18:24:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAgmh-000792-08 for guix-patches@gnu.org; Thu, 20 Jan 2022 18:24:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAgmg-00043n-T2 for guix-patches@gnu.org; Thu, 20 Jan 2022 18:24:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53208] [PATCH 39/39] gnu: rust-analyzer: Make it out of box. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jan 2022 23:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53208 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53208@debbugs.gnu.org Cc: 873216071@qq.com X-Debbugs-Original-To: Z572 via Guix-patches via X-Debbugs-Original-Cc: 53208@debbugs.gnu.org, Z572 <873216071@qq.com> Received: via spool by 53208-submit@debbugs.gnu.org id=B53208.164272099615538 (code B ref 53208); Thu, 20 Jan 2022 23:24:02 +0000 Received: (at 53208) by debbugs.gnu.org; 20 Jan 2022 23:23:16 +0000 Received: from localhost ([127.0.0.1]:59634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAglv-00042Y-V7 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 18:23:16 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:55077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAglp-000421-H3 for 53208@debbugs.gnu.org; Thu, 20 Jan 2022 18:23:09 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id C9F92240007; Thu, 20 Jan 2022 23:23:02 +0000 (UTC) From: Nicolas Goaziou References: Date: Fri, 21 Jan 2022 00:23:01 +0100 In-Reply-To: (guix-patches@gnu.org's message of "Wed, 12 Jan 2022 23:27:59 +0800") Message-ID: <87r1928016.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642727670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=8WhScQH8vRZ5uQSxcPGBrEnSWcyT0ijp2wUA+zhp4U8=; b=DlGUMLSS87hwHsgc0wCc609V7krQCJqWxuDvDnzDm8iHf2gzVZ9A/u3ObAkh6GJpr8KHC8 gPzzmRS0TEJKw2AcXERKBV5F60+nxzso0q3zmt2DinDTCW0U0OILSIDpfzpOqm0AMNzmHx M6/4tXysurtLX+akYWa19PnmLMZCuFNTff/jCdjfQY6UpJBUhzCdIrEVlK+87nnVLMvVJv 5xtvrxYui+soKSKG4kk4uE/WQUBrm8DQp0e4eRRgglosj1k7YShyZ58HB7ayjhnXPtaUzn 9gxd+TL7Gwu2ly1APUU6EF9XmKCkFDunukgkereNHUZxRb595Us/19DcdFyXjA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642727670; a=rsa-sha256; cv=none; b=jweVJEKmxnUQqEule3eHy4U8wOqWhULecsU1oXnouW/WFB2XSsu2fNxeWm3cqZygR8ZqYS SZlCWHYZcWGsKPkFBMgy5KfeUYAd+mS1i0WNhpEN93zG4bnf3uT54caU0kGnwkquQUTeUN +JjMRIkyk1STKAoN+RnAnjKn2Gomct+7DZC8+vQOkRqOJQMRxGBdSU1pt/pBn2Aint/CbP jRZXT4EN/L+pENu3HoNje3U4UEwWLOSihq171oeXyfIX27dDJgT1SlwScw5L0JKdVWzuBx UNrzMYfli6ZFi7IzVkkVRldJYkKBlUpi2D73SdPB31I3nGuCtSVP6tbtKNJ+zQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.53 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 34AF714B88 X-Spam-Score: -3.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7T6R0xoW2RnN Hello, Z572 via Guix-patches via writes: > +(define-public rust-src > + (hidden-package > + (package > + (inherit rust-1.57) > + (name "rust-src") > + (build-system copy-build-system) > + (native-inputs '()) > + (inputs '()) > + (native-search-paths '()) > + (outputs '("out")) > + (arguments > + `(#:install-plan > + '(("library" "lib/rustlib/src/rust/library") > + ("src" "lib/rustlib/src/rust/src")))) > + (synopsis "Source code for the Rust standard library") > + (description "This package provide source code for the Rust standard > +library, only use by rust-analyzer, make rust-analyzer out of > box.")))) This cannot work, because, AFAIK, you can only inherit packages from the same module. So rust-src should be moved to rust.scm and made visible. > + (add-after 'install 'wrap-program > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (rust-src-path (search-input-directory > + inputs "/lib/rustlib/src/rust/library"))) > + ;; if not get environment variable RUST_SRC_PATH, set it, > + ;; make rust-analyzer out of box. > + (with-directory-excursion bin > + (let* ((prog "rust-analyzer") > + (wrapped-file (string-append (dirname prog) > + "/." (basename prog) "-real")) > + (prog-tmp (string-append wrapped-file "-tmp"))) > + (link prog wrapped-file) > + (call-with-output-file prog-tmp > + (lambda (port) > + (format port "#!~a > +if test -z \"${RUST_SRC_PATH}\";then export RUST_SRC_PATH=~S;fi; > +exec -a \"$0\" \"~a\" \"$@\"" > + (which "bash") > + rust-src-path > + (canonicalize-path wrapped-file)))) > + (chmod prog-tmp #o755) > + (rename-file prog-tmp prog)))))) I tried to move the rust-src in rust.scm, as explained above, but when I do, installation of rust-analyzer fails during the `wrap-program' phases. > (replace 'install-license-files > (lambda* (#:key outputs #:allow-other-keys) > (let* ((out (assoc-ref outputs "out")) > @@ -1298,6 +1341,7 @@ (define-public rust-analyzer > (chdir "../..") > (install-file "LICENSE-MIT" doc) > (install-file "LICENSE-APACHE" doc))))))) > + (inputs (list rust-src)) Shouldn't it be a native-input? Could you have a look at those issues? Thanks! Regards, -- Nicolas Goaziou