From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gMBnB+lTBWJ5EAEAgWs5BA (envelope-from ) for ; Thu, 10 Feb 2022 19:05:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yGnEBOlTBWIAIgAA9RJhRA (envelope-from ) for ; Thu, 10 Feb 2022 19:05:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D5C137230 for ; Thu, 10 Feb 2022 19:05:26 +0100 (CET) Received: from localhost ([::1]:33150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIDor-0002Hm-JX for larch@yhetil.org; Thu, 10 Feb 2022 13:05:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nICDm-00036o-JK for guix-patches@gnu.org; Thu, 10 Feb 2022 11:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34779) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nICDm-0003wU-9O for guix-patches@gnu.org; Thu, 10 Feb 2022 11:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nICDm-0001ak-5g for guix-patches@gnu.org; Thu, 10 Feb 2022 11:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53656] [PATCH 0/2] 2 Julia packages Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Feb 2022 16:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53656 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 53656@debbugs.gnu.org Received: via spool by 53656-submit@debbugs.gnu.org id=B53656.16445101636073 (code B ref 53656); Thu, 10 Feb 2022 16:23:02 +0000 Received: (at 53656) by debbugs.gnu.org; 10 Feb 2022 16:22:43 +0000 Received: from localhost ([127.0.0.1]:56909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nICDT-0001Zt-FB for submit@debbugs.gnu.org; Thu, 10 Feb 2022 11:22:43 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:46611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nICDS-0001Zg-EA for 53656@debbugs.gnu.org; Thu, 10 Feb 2022 11:22:42 -0500 Received: by mail-wr1-f45.google.com with SMTP id q7so10433974wrc.13 for <53656@debbugs.gnu.org>; Thu, 10 Feb 2022 08:22:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=xZhlY/0YuDtdjgJGNPgHQK/bc7edp4jUzHYjOfVo4mo=; b=oXIe5yEK4RqdvBI/YRsHLZNJOF1yY6hqqvKjBS1Sq0OSkNlR5tLbUENSJaXhlirVq7 o2ktvFePG942y/DnqQXdzvuEfh41YsJoQ1Kd3jD0iNHrQggYMllF5rX3DTcTad8MFmKl xQPqj5FPCMBDSAj4IQ5WJjMzvmTSCsiBBWKeofitx/dOomQCEPxx0t2qzWNvp5c5mVTT cPx3z2OfR6HP1HBDhPsX+QCl5GnH1hHPEu6GE7ti5ht7iUYWCIqt1bd2igQQ3P0JKfVq 9AsR5XXC++0M28ijcZHW1/OvjaLa6kWlwZEN9aEQ+2z6gJgvtYUt1Fz0djiT08HM7f4/ BuNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=xZhlY/0YuDtdjgJGNPgHQK/bc7edp4jUzHYjOfVo4mo=; b=Nc1h57zdas9MD+ttXsDbInJbbdHYGnvEeF8uPykAw11umWbp/fdV38xd3cQdWiRupV T17uOrNtzsR0bV6w9+5b5Cuq6sKpKXMqQH93D9nvx4gA8YC/SfjZ2WukL9tuFVpoTwAZ ThElFZTSW/vvfm5FORU57OJB01RjOHT/4a/Aa9CFoScjUae8ttLzjmVTdSLtbx/dvuKd w5ccOlSuXc3lmvHw7Bm36bVTD+LA3J+BdGD+iz0jBHmbSgFTDgn51wIKCelv6TNvGdLi suATSMf+Fd208sUdYXq5DD3H7XZVdIabtsWajs2jAr+iE4Jw338hK0Xpz62jS0o/M9JB pyrQ== X-Gm-Message-State: AOAM532ffIEUENLUAJIUsN8oufLORXdWAOg41AlKuHIegGwvTgpxPZak kF1MigkHs/3OfpyiSmUOc+Msqqy7SJk= X-Google-Smtp-Source: ABdhPJzllmXhQRTmtBMokXEah5xhC8Ip8K2wKwhmp9KZnyq3VuEGBS0+nDx/qKFofHySYu7bgUX29w== X-Received: by 2002:a05:6000:2c6:: with SMTP id o6mr7216600wry.585.1644510156274; Thu, 10 Feb 2022 08:22:36 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id p12sm1795326wmg.36.2022.02.10.08.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 08:22:35 -0800 (PST) From: zimoun References: <93a51e504cd30094511b1eac3957e10ff800cdf0.1643625386.git.efraim@flashner.co.il> Date: Thu, 10 Feb 2022 17:22:33 +0100 In-Reply-To: <93a51e504cd30094511b1eac3957e10ff800cdf0.1643625386.git.efraim@flashner.co.il> (Efraim Flashner's message of "Mon, 31 Jan 2022 12:40:33 +0200") Message-ID: <87r18a8zee.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644516326; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xZhlY/0YuDtdjgJGNPgHQK/bc7edp4jUzHYjOfVo4mo=; b=UEp4vJGr/4PgcjEaKwa24eaczwuw24kp6c+gm4r/q1PLCROBKGrgArhNSu1r/5dYqXGlyv CsA6td3SvdutMib9DpJ+Ba8DGR19od/zy45Kdj+nBGhq/jCKxCT04IoIvBgaQhFb/pBHqF 2eszA9qrFmiFSq/i3PPFwezt+o0rR1eeQDJ1FysUFQfTocRa605n9bgRbtZY8LJsRDTMG/ +HbFSgV+Hoi0j/dGey17Pu7KmgZzXnxiVyNP4NF1cg9qjI0vNo7CuaDszCpilS6CLNWASU kmuuz9yt5VMHN+u9tac2QNTnkhTsvBWGonIz6NBHLQdenRvBp61US9W/A1FBFA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644516326; a=rsa-sha256; cv=none; b=FDNeC7tRKIC00xXPky6PBVBnnaoO5d7PrZzDtSykEqGut88P7baS/X4z2Fk9s+sSCKGzqg QEADx3KotnXQZ+bWg+RbtzpBb5/ARXeLG4GkYq+g27i7y0G+0VrVP1mRavCebQ9HT3BGb2 vLadSipg3A3BvSIm+7g5WyKNpyha13Nv3rZSh6lJc1yJnE9Iuvg9mIrrB2i4ZWUWvd1OCq U7/vQBu3279lN3xYyNqh8t2mK8bgE0TONLp8VSNkv9i2sTXTmpnqpOxz1HPVReErMA6AWW yl1VIzo5tvTpDueFSWd2pAaKGniRyBqUtdkNNYnknaE6HFQz3DefnXwFwJoY7Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=oXIe5yEK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=oXIe5yEK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6D5C137230 X-Spam-Score: -3.63 X-Migadu-Scanner: scn0.migadu.com X-TUID: rHYqNOOFvGca Hi Efraim, Both patches look good to me. I notice this warning: --8<---------------cut here---------------start------------->8--- =E2=94=8C Warning: Package OptimTestProblems does not have LinearAlgebra in= its dependencies: =E2=94=82 - If you have OptimTestProblems checked out for development and h= ave =E2=94=82 added LinearAlgebra as a dependency but haven't updated your pr= imary =E2=94=82 environment's manifest file, try `Pkg.resolve()`. =E2=94=82 - Otherwise you may need to report an issue with OptimTestProblems =E2=94=94 Loading LinearAlgebra into OptimTestProblems from project depende= ncy, future warnings for OptimTestProblems are suppressed. --8<---------------cut here---------------end--------------->8--- and... On Mon, 31 Jan 2022 at 12:40, Efraim Flashner wrote: > * gnu/packages/julia-xyz.scm (julia-optim): New variable. [...] > + #:use-module (guix gexp) [...] > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'adjust-tests > + (lambda _ > + ;; TODO: Figure out why this test fails. > + (substitute* "test/runtests.jl" > + ((".*l_bfgs.*") ""))))))) ...I am thinking loudly if this gexp is required. There are other many similar patter without a gexp. Therefore, for consistency with the rest, I would be in favor to switch to regular modification of phases. Or let me know if this is becoming the new patter and I would adapt for the others. Cheers, simom