From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cHZ0LJdxgWKuNgEAbAwnHQ (envelope-from ) for ; Sun, 15 May 2022 23:33:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2PpvK5dxgWLaFQAAG6o9tA (envelope-from ) for ; Sun, 15 May 2022 23:33:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0976114D57 for ; Sun, 15 May 2022 23:33:11 +0200 (CEST) Received: from localhost ([::1]:43682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqLrR-0008G0-Iw for larch@yhetil.org; Sun, 15 May 2022 17:33:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqLrK-0008Fk-9F for guix-patches@gnu.org; Sun, 15 May 2022 17:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nqLrK-0002dC-0A for guix-patches@gnu.org; Sun, 15 May 2022 17:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nqLrJ-0006tz-Sm for guix-patches@gnu.org; Sun, 15 May 2022 17:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54832] [patch] update glibc to 2.35 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 May 2022 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zamfofex Cc: Maxime Devos , 54832@debbugs.gnu.org Received: via spool by 54832-submit@debbugs.gnu.org id=B54832.165265032326466 (code B ref 54832); Sun, 15 May 2022 21:33:01 +0000 Received: (at 54832) by debbugs.gnu.org; 15 May 2022 21:32:03 +0000 Received: from localhost ([127.0.0.1]:50905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqLqN-0006so-6f for submit@debbugs.gnu.org; Sun, 15 May 2022 17:32:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqLqM-0006sL-1j for 54832@debbugs.gnu.org; Sun, 15 May 2022 17:32:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqLqF-0002YW-Eu; Sun, 15 May 2022 17:31:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=mDn8q1r8/4lLkuM5AYfdWowXiRcaG9I/abcAQHVHNHg=; b=VbvRvNPASFt9t6TCXszi umHvIFdVQqN9TP68hktdhRL2nQKWAIlZGGKBvfweEMT45RnoNHUKc2aVtHENkisucVSSam80XfIi2 xVB9GLgFlI/EZnStTqQnv7Uq6SdQLZ6Fd8CAYahhJuz8fwGB6j9yREhfvefu0TStl3IH8hoXL8dyZ kSS1HLa4CtlAPiTJyVfAs6pdSymucWjDRroWxwQ2/R+Gh6eqakv+iBcKl6+iZZW6QmVO5iUltB00l B9o+/DHRlrP98vSucqWPyiI3IjZQDBjP4ieflojuKFfYEL9N7EO/2Cj5f3cYptSbf6DypkZCoHTA4 kOX/ohdH4UlhEg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:60766 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqLqF-0007sv-1n; Sun, 15 May 2022 17:31:55 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <935236349.13698.1649553391613@privateemail.com> Date: Sun, 15 May 2022 23:31:53 +0200 In-Reply-To: <935236349.13698.1649553391613@privateemail.com> (zamfofex@twdb.moe's message of "Sat, 9 Apr 2022 22:16:31 -0300 (BRT)") Message-ID: <87r14ubhyu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652650391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mDn8q1r8/4lLkuM5AYfdWowXiRcaG9I/abcAQHVHNHg=; b=bZpxskegjz8mvW1PzlVHBOCA+X7qn3k7BcDLoNtMuflbxeVloEQtYIA3MpIfB+0JnXkkBr C5jeMJkzasyR3pj8trW8NX7c645ulRJV0jWKwEw1xoZ+mx0g+3a7VT2A5QvQBySTO84Kxa zhHrbACU6wzHGlGmWjBJxwFyOsEPGXT7/t9/yzU45yEI+UfbJurbMq7sfO7rljh+HBt0UL O5fDnTKffZH1NMgOfoP5fbXfou6g3KMtqPGr1hzSWOZeZLxvjxi7YEQrC0KK4z/BmmyI0Z Hcq7d0HbA5GFE6lD3OMOI+0t/PeWJ0zZPkTCdMufx8nSNhQ8al0DaNPttL/GEA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652650391; a=rsa-sha256; cv=none; b=la9SjPQ1CnS7N+Gc/Sy03ru4b0lkKHZO59isaD1dekzrdaByV65CUVtTnkgM8CtaAoPTW4 lRKY3/3NAMKm3qUR3KiENCJ3qaVN2oar0PvUKeN2SOau7oxdIwttCP2XD/CO22osg6kZsm FLMlJrP0cMTx2mpsKZAjN90tr9uLJSVD97Ui7jyGV3YFhKy5y3zBxVD2Lvu+xObx1NJQCG THJx6OBRpYGbUbGe3zrqN8JH1YB5KqM+sk3MKgKa1WhCRdHxOe/21NvJ49wEHRvX9Lpg3C ixC7tn2mDKEU5TbskoG562HU0SvbaAIiFUxP8rmqKQ8AFxgGWnPohnV9KNixfg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VbvRvNPA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=VbvRvNPA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0976114D57 X-Spam-Score: -3.93 X-Migadu-Scanner: scn1.migadu.com X-TUID: yNco4sUBzpgu Hello! zamfofex skribis: > Hello! I have decided I wanted to work on updating glibc. I tested the up= dated glibc with the packages =E2=80=98hello=E2=80=99, =E2=80=98coreutils= =E2=80=99, =E2=80=98grep=E2=80=99, =E2=80=98sed=E2=80=99 and =E2=80=98guile= =E2=80=99, and they all built successfully! Yay! > (base32 > - "1zvp0qdfbdyqrzydz18d9zg3n5ygy8ps7cmny1bvsp8h1q05c99f")) > - (patches (search-patches "glibc-ldd-powerpc.patch" > - "glibc-ldd-x86_64.patch" > - "glibc-dl-cache.patch" Could you confirm that these patches are no longer needed? > + (define empty-static-libraries '("libpthread.a" "li= bdl.a" "libutil.a" "libanl.a")) > + (define (empty-static-library? file) > + (any (lambda (s) (string=3D? file s)) empty-stati= c-libraries)) [...] > (files (scandir lib static-library?)) > + (files2 (scandir lib empty-static-library?)) > (static (assoc-ref outputs "static")) > (slib (string-append static "/lib"))) > (mkdir-p slib) > @@ -876,6 +883,10 @@ (define (linker-script? file) > (rename-file (string-append lib "/" b= ase) > (string-append slib "/" = base))) > files) > + (for-each (lambda (base) > + (copy-file (string-append lib "/" bas= e) > + (string-append slib "/" ba= se))) > + files2) Like Maxime wrote, this needs comments in the code. Could you explain why the empty .a files need special treatment? In the end, it seems we=E2=80=99re copying them to the =E2=80=9Cstatic=E2=80=9D ou= tput anyway, so why not let them in =E2=80=98files=E2=80=99? > (define-public m4 > (package > (name "m4") > - (version "1.4.18") > + (version "1.4.19") This should be done in a separate patch. > +++ b/gnu/packages/patches/m4-failing-test-bug.patch > @@ -0,0 +1,7 @@ > +--- a/tests/test-execute.sh > ++++ b/tests/test-execute.sh Like Maxime wrote, please start the patch with a short comment explaining what it does, and with a link to the upstream commit or bug report. One last thing: could you use =E2=80=98git format-patch=E2=80=99 and (optio= nally) =E2=80=98git send-email=E2=80=99 to send a revised patch? https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html Thanks in advance, and apologies for the delay! Ludo=E2=80=99.