From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SO6kOAjbtGK1hQEAbAwnHQ (envelope-from ) for ; Thu, 23 Jun 2022 23:28:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WOhtOAjbtGK0SQEAauVa8A (envelope-from ) for ; Thu, 23 Jun 2022 23:28:40 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CF6222679 for ; Thu, 23 Jun 2022 23:28:40 +0200 (CEST) Received: from localhost ([::1]:44458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4UNT-0005Es-0i for larch@yhetil.org; Thu, 23 Jun 2022 17:28:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4UH4-0003q9-N3 for guix-patches@gnu.org; Thu, 23 Jun 2022 17:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4UH4-0004iJ-EI for guix-patches@gnu.org; Thu, 23 Jun 2022 17:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4UH4-0007Wk-A0 for guix-patches@gnu.org; Thu, 23 Jun 2022 17:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jun 2022 21:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55966 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55966@debbugs.gnu.org Cc: Nicolas Graves X-Debbugs-Original-To: Nicolas Graves via Guix-patches via , 55966@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165601926328838 (code B ref -1); Thu, 23 Jun 2022 21:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jun 2022 21:21:03 +0000 Received: from localhost ([127.0.0.1]:40143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4UG6-0007Uu-KD for submit@debbugs.gnu.org; Thu, 23 Jun 2022 17:21:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:34692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4UG5-0007U4-2O for submit@debbugs.gnu.org; Thu, 23 Jun 2022 17:21:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4UG4-0001rQ-Pf for guix-patches@gnu.org; Thu, 23 Jun 2022 17:21:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4UG4-0004Y5-6k; Thu, 23 Jun 2022 17:21:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=z8OaRJUnslCFZtQgPwOldeqlYFUlB0/yeswTO6qAVLs=; b=IPwPH46+xs6gXUNr62M6 fwRKJZLkDADSxhlv8l3uYwZieV4HX5yuWc0R336Hc3bHuP0GvywMD+QhMTBGti5h5ZF8VhKRn+3iH NK/yT8lXe62R+oyddrHOoEAQw2HZNOgGg/q2Kb16aJL0nmyHnE8malA+WLtAZA4zEydB/KXrpoDXg ReTpE4rw84rzBX0W2O6z8Ypk3tPBCFHpC2GIIttJA5KJbS706Ea6AVAQ5ERMHc710KXnktnV7uZo5 5vtLLoug22llIUbbcslcL30ms13/Ma3aYMSkZ9udIDNMecU2zOXRttApaQs/lUsbHLwjKskI07IyR J8k6HZQNFTCimw==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:38588 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4UG3-0007Hd-Ol; Thu, 23 Jun 2022 17:20:59 -0400 From: Marius Bakke In-Reply-To: <20220614094954.15197-9-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> <20220614094954.15197-9-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 23:20:57 +0200 Message-ID: <87r13fqdom.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656019720; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=z8OaRJUnslCFZtQgPwOldeqlYFUlB0/yeswTO6qAVLs=; b=mqXonRXsZBMFgFtBOrJLOEwCtvmltPVl5ZL9t3AEeEHIx9o5YNRaDQSc89gaZrOM/+ceZc RakXXfFqELl5k9eRA8stM1ctHKzr9a1JLbK/LriG93yi7bH2Xr2awcC7ZMmcWZj6htYZI2 g+Ab8Zi9Z6sqfcHxEkYFmbOXzZ6Ya2QwByKH9Nh/XkiBdBGgEyTnRJavd5JK5Mlu7iDdtd dO5deLX5UXBz6SKaaYF6Wm6wXeqUKGt8N2Iot8TM/8WajnQ6aLAVhYK2qxqhqw82JDZ8Ks tW40QpHs+U7MBZheZOWXTO++h/jAEWKkucvyiDlgfUSaQv8kZlWUq8J2fyxhMg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656019720; a=rsa-sha256; cv=none; b=FnzYfLuLLM5mebhMYOQAgiafdPkWhl8kb9e4/gjiUoZDZQea90WbFbpMSojcCe2xtivyFC VMr+qK8pgjJa5iVqDVybfSHmDo3cpXUeEj3FxOMAnSGHhr0coTatWCuafjiJ74xeemRcMJ TO0mQqF8enUZk557/t+UBIzhvtZ9G9MixYrMU4fXh5RfBVXz+tp3eVdjpif33n7F4jgfGj R2aAalStaBGlyNPWfcJsZ25iSLMxV9UtdQM7S44xz9J9OB9fkqAuhNQmJYw9VXp5sbPZL4 Lm2sk/tE0B4KlbnmRa4cx3EacH1kd7f2ofLzHJf9RVgOV6M5GoGp1gqrIyM5Tg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IPwPH46+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IPwPH46+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8CF6222679 X-Spam-Score: -6.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: uT1WP6BAw/Sx --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicolas Graves via Guix-patches via skriver: > --- > gnu/build/chromium-extension.scm | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) This commit lacks a message describing the changed variable. The commit title could also be more descriptive. ;-) > diff --git a/gnu/build/chromium-extension.scm b/gnu/build/chromium-extens= ion.scm > index 8ca5251957..8d52153751 100644 > --- a/gnu/build/chromium-extension.scm > +++ b/gnu/build/chromium-extension.scm > @@ -19,10 +19,9 @@ > (define-module (gnu build chromium-extension) > #:use-module (guix gexp) > #:use-module (guix packages) > - #:use-module (gnu packages chromium) > #:use-module (gnu packages gnupg) > #:use-module (gnu packages tls) > - #:use-module (gnu packages xorg) > + #:use-module (gnu packages node-xyz) > #:use-module (guix build-system trivial) > #:export (make-chromium-extension)) >=20=20 > @@ -69,24 +68,14 @@ (define version (package-version package)) > (string-append name "-" version ".crx") > (with-imported-modules '((guix build utils)) > #~(begin > - ;; This is not great. We pull Xorg and Chromium just to Zip and > - ;; sign an extension. This should be implemented with something > - ;; lighter. (TODO: where is the CRXv3 documentation..?) Wohoo. :-) > (use-modules (guix build utils)) > - (let ((chromium #$(file-append ungoogled-chromium "/bin/chromiu= m")) > - (xvfb #$(file-append xorg-server "/bin/Xvfb")) > + (let ((crx3 #$(file-append node-crx3 "/bin/crx3")) > (packdir (string-append (getcwd) "/extension"))) > (mkdir packdir) > (copy-recursively (ungexp package package-output) packdir > ;; Ensure consistent file modification time= s. > #:keep-mtime? #t) > - (system (string-append xvfb " :1 &")) > - (setenv "DISPLAY" ":1") > - (sleep 2) ;give Xorg some time to initiali= ze... > - (invoke chromium > - "--user-data-dir=3Dchromium-profile" > - (string-append "--pack-extension=3D" packdir) > - (string-append "--pack-extension-key=3D" #$signing-ke= y)) > + (invoke crx3 "--keyPath" #$signing-key packdir) LGTM! Feel free to add your copyright here too. Can you send an updated series? Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTZOQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcmwQD8CMK+pxlSWKSUz/ZS4n6M37C/yTwXqJn4qeGC hws+52wBAIw/6zFLo4RX6PFqyK9JZQaT/A5uCqEB4F62aO+AFJYB =NJqd -----END PGP SIGNATURE----- --=-=-=--