From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WJ6qIivUAmM2BQAAbAwnHQ (envelope-from ) for ; Mon, 22 Aug 2022 02:56:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qC2KIivUAmOwAAEAauVa8A (envelope-from ) for ; Mon, 22 Aug 2022 02:56:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A2FF2F26D for ; Mon, 22 Aug 2022 02:56:11 +0200 (CEST) Received: from localhost ([::1]:34246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPvje-0006DF-5T for larch@yhetil.org; Sun, 21 Aug 2022 20:56:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPvjX-0006D6-9o for guix-patches@gnu.org; Sun, 21 Aug 2022 20:56:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oPvjW-0004Rv-TY for guix-patches@gnu.org; Sun, 21 Aug 2022 20:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oPvjW-0006YG-FW for guix-patches@gnu.org; Sun, 21 Aug 2022 20:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0 Resent-From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Aug 2022 00:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57257 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 57257@debbugs.gnu.org, iyzsong@member.fsf.org Received: via spool by 57257-submit@debbugs.gnu.org id=B57257.166112971725130 (code B ref 57257); Mon, 22 Aug 2022 00:56:02 +0000 Received: (at 57257) by debbugs.gnu.org; 22 Aug 2022 00:55:17 +0000 Received: from localhost ([127.0.0.1]:37153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPvim-0006XG-Ld for submit@debbugs.gnu.org; Sun, 21 Aug 2022 20:55:16 -0400 Received: from envs.net ([89.163.145.170]:55668 helo=mail.envs.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPvii-0006Wz-Cq for 57257@debbugs.gnu.org; Sun, 21 Aug 2022 20:55:14 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 2C34638A1AB5; Mon, 22 Aug 2022 00:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1661129709; bh=IuDJE9tK7WMwy7S6r89fRGxzlbkxLu4ckQsLdTnXHos=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XMii7Qf4Ut1fuqwik+yRguGKD1bBsyQ3CBbOrBvoblzacqvqn6pRvQ0gVv0+x64Xh uhhz1t0xTqc9XUhszc4LYDkM7x2COkm7KPjbKkmJaEsAL+DKXZMVG1t5EEX/H/3aXt 71ne3SGen4Zp2QQ8ALc5e5LTaDHOWn30XshT9jBAvUmblis9xluT4yScAk4ygyvx7P J55IDq8QQj3cGGKiMdJMgTelg73OjHwvAj5HxDRIufxsFY/vcNgIEnWggS60C8TMm2 rSbwU8hX93YNagzWtGIA6xYzA/QaXsYmbA+C8woG22v4pC7CSkb5MrVvAuDPEoFRYU 2OMltbVCKSYuhcdisRlc8+2qwk1gm4AEDzWV077LGe5rthkDpcbKohqz5n/5tx3aOM 1Ssv4ELvwfiyxe4tF1QPjFz4udrNi2wxZqFAckRgxBjQpkjJyKETc1dDwsZlIlLwlk dSFaNzfIWXb7j3yklH4dh2Xz15KalDU1gfZF1XRzjj7U/07YQSN0iqe9kD14+K9Ox4 cXa4HMWgDiML5/zpSAqhSwIUgPwg2AdO7krDhoPOC5dcyelbSmnEZAK4wxIkc9+a6j V6ec1ZnRBuH4Widyv8T/dgykf5ZcBK8b0bfI5ERQAtArMRni+10B7/f4dQ56YCAH97 lXxKGjf63pKOBrrD/kALX3q4= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yzqRrh2ZXSZ4; Mon, 22 Aug 2022 00:55:05 +0000 (UTC) Received: from localhost (unknown [182.150.116.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: iyzsong@envs.net) by mail.envs.net (Postfix) with ESMTPSA; Mon, 22 Aug 2022 00:55:05 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ebba5264; Mon, 22 Aug 2022 00:55:03 +0000 (UTC) References: <877d313lpw.fsf@elephly.net> Date: Mon, 22 Aug 2022 08:55:03 +0800 In-Reply-To: <877d313lpw.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 21 Aug 2022 12:55:44 +0200") Message-ID: <87r119jdw8.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-ACL-Warn: , =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= From: =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661129771; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IuDJE9tK7WMwy7S6r89fRGxzlbkxLu4ckQsLdTnXHos=; b=g6QDvR469ysrtx9iD3yqPzMZpC/5QS4cbJ7RRtr6xYyRASySygh84NHlTPeaftEAvWOHe1 oTv66qHyQW7Hz318JX+NjlQslnRAnH/F9OnDqWvTq/DF/jk8yXXmQvRghBJctBLBwB1lqH rzH2/faonFje7c/AqFDy08BhRLe+YEoNaxuft53dEum3Egv2a+KfXg1dN34MaBDtfBcozJ 2+H2sMn/IpPm7H9jd8D1rsNPgCe8Za/jaVDtjsA/2HYX2nJ2LVHeicLfSvtNV6QdphckCE SkB/eOK7ortTYUfUXytdLhUGEEOdZZk2wV9XU6DUjmb6HP1Lurw+KgBBK3Jkww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661129771; a=rsa-sha256; cv=none; b=Jo3czuejq4CAQwOuxNJbumlNNoyO1ZaJAEApNKanbnPvAmJbCI27f4lJIab5L7jCC2QrRw U01VqIyK0Fle5189yye4Rs6Y12q4GOP99pTzugSfDXup0XYWnEVJ3D5Q22jlnv8Q+pzQgC rM0S3SeArJmBldqf/0axA+RQb32nigp6n1jX9atz04nI7RLcBZ8h3Wg0+e//ahgRSdNhOR diEQ5NnXvv1Y8vCQGIhvFNIqVS+qtsIeaGHUyBhGY7fhpmYmajkK8BUn0WTW4FzPmpHcup RvWq6JYGpZnZHdYrE8vKV+g8zOvfX5o3PzN9JnqjTUgJVnbhBQgFiR/gMG+KwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=XMii7Qf4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=XMii7Qf4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4A2FF2F26D X-Spam-Score: -2.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: leewnFNyWm9i Ricardo Wurmus writes: > Hi, > > overall this looks good to me. Thank you for working on it! > > There are just a few questions: > > - does it really work to use relative file names? Would it be possible > to test this roughly in a system test? Yes, the relative file names are for install, at runtime most things works as designed with XDG_DATA_DIRS and XDG_CONFIG_DIRS. A system test could verify items in lxqt-config, will look it later... > > - you=E2=80=99re removing a lot of patch-source phases. Why are these no= longer > needed? Yeah, I find that use relative file names in LXQtConfigVars.cmake remove the need of patching other cmake files. > > - you=E2=80=99re also removing patch-translations-dir phases. Do transla= tions > still work after applying these changes? Yes, at runtime they are found under XDG_DATA_DIRS, by lxqttranslator.cpp: *searchPath << XdgDirs::dataDirs(QL1C('/') + QL1S(LXQT_RELATIVE_SHARE_TRANS= LATIONS_DIR)); > [...] > > Feel free to push this! Okay, thanks for the review!