From: Christopher Baines <mail@cbaines.net>
To: Trevor Richards <trev@trevdev.ca>
Cc: 57756@debbugs.gnu.org
Subject: [bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify
Date: Wed, 14 Sep 2022 08:58:47 +0100 [thread overview]
Message-ID: <87r10e8jwt.fsf@cbaines.net> (raw)
In-Reply-To: <cb7a149a578dcd950dc6c53e2e756628305b90d1.1663018041.git.trev@trevdev.ca>
[-- Attachment #1: Type: text/plain, Size: 2109 bytes --]
Trevor Richards <trev@trevdev.ca> writes:
> ---
> gnu/packages/wm.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
Hi Trevor,
The commit message for adding a package like this one would generally
look like:
gnu: Add sbcl-stumpwm-notify.
* gnu/packages/wm.scm (sbcl-stumpwm-notify): New variable.
You're mostly there.
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 451dfce516..6ae0135a64 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -56,6 +56,7 @@
> ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> ;;; Copyright © 2022 muradm <mail@muradm.net>
> ;;; Copyright © 2022 Elais Player <elais@fastmail.com>
> +;;; Copyright © 2022 Trevor Richards <trev@trevdev.ca>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -2256,6 +2257,29 @@ (define-public sbcl-stumpwm-screenshot
> PNG files.")
> (license license:gpl3+)))
>
> +(define-public sbcl-stumpwm-notify
> + (package
> + (inherit stumpwm-contrib)
> + (name "sbcl-stumpwm-notify")
> + (build-system asdf-build-system/sbcl)
> + (inputs
> + `(("stumpwm" ,stumpwm "lib")
> + ("xml-emitter" ,sbcl-xml-emitter)
> + ("dbus" ,sbcl-dbus)
> + ("bordeaux-threads" ,sbcl-bordeaux-threads)))
> + (arguments
> + '(#:asd-systems '("notify")
> + #:tests? #f
Why aren't the tests being run? If they can be run, that would be
good. If there's a reason why they can't or shouldn't be run, it would
be good to note that in a comment.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'chdir
> + (lambda _ (chdir "util/notify") #t)))))
> + (home-page "https://github.com/stumpwm/stumpwm-contrib")
> + (synopsis "Notifications server for StumpWM")
> + (description "Implements org.freedesktop.Notifications
> +interface[fn:dbus-spec]. Shows notifications using stumpwm:message by default.")
> + (license license:gpl3)))
> +
> (define-public lemonbar
> (package
> (name "lemonbar")
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2022-09-14 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 21:27 [bug#57756] [PATCH 0/2] Add sbcl-xml-emitter Trevor Richards
2022-09-12 21:10 ` [bug#57756] [PATCH 1/3] gnu: add sbcl-xml-emitter Trevor Richards
2022-09-12 21:10 ` [bug#57756] [PATCH 2/3] gnu: add sbcl-stumpwm-notify Trevor Richards
2022-09-14 16:41 ` [bug#57756] [PATCH 3/3] gnu: sbcl-stumpwm-notify: Fixed missing tests Trevor Richards
2022-09-15 8:40 ` bug#57756: [PATCH 1/3] gnu: add sbcl-xml-emitter Guillaume Le Vaillant
2022-09-12 21:10 ` [bug#57756] [PATCH 1/2] * gnu/packages/lisp-xyz.scm: Add sbcl-xml-emitter Trevor Richards
2022-09-12 21:10 ` [bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify Trevor Richards
2022-09-14 7:58 ` Christopher Baines [this message]
2022-09-14 16:28 ` Trev
2022-09-16 10:25 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r10e8jwt.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=57756@debbugs.gnu.org \
--cc=trev@trevdev.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).