[bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of coq-mathcomp-analysis))

[zimoun <zimon.toutoune@gmail.com>]

Hi,

On dim., 02 oct. 2022 at 16:52, Garek Dyszel via Guix-patches via <guix-patches@gnu.org> wrote:
> I didn't see this last email before I closed the issue a couple of days
> ago. Sorry for not catching it sooner.
>
> At 14:06 2022-09-30 UTC+0200, zimoun <zimon.toutoune@gmail.com> wrote:
>> Because today, it is too much work to unknot your patch set.
> I agree. For a first patch set, it is a mess! :)
>
>> If it is too much work for you, please point against which Git commit
>> you generated the patch set.
> At this point I don't know. Before you had mentioned --base, I had
> already started working on another package and lost track of which
> commit this patch set was generated from.
>
>> From my point of view, the easiest to send this patch set with the
>> correct order and against the current master. Even if some patches
>> does not build correctly.
>>
>> Based on that, we could merge what is currently ready. And
>> collectively fixes what is missing.
> Oh, I suppose it didn't occur to me that we could fix the broken parts
> collectively :/ Would it be better to re-open this issue or start a new
> one?

That’s why ’--base’ is documented in «Submitting patches»; see #1 in [1].

Because if the branch evolves between the submission and the moment when
others give a look, it is still possible by others to apply the patch
and rebase.

Something to have in mind for the next time. :-)


Well, personally I am not able to reuse your work and Julien neither,
IIUC.  Therefore, feel free to close this submission and reopen another
one.


1: <https://guix.gnu.org/manual/devel/en/guix.html#Submitting-Patches>


Cheers,
simon