From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gOh8M7FjxmPLcQAAbAwnHQ (envelope-from ) for ; Tue, 17 Jan 2023 10:00:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id INZYM7FjxmOXxQAAauVa8A (envelope-from ) for ; Tue, 17 Jan 2023 10:00:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 691CC1066D for ; Tue, 17 Jan 2023 10:00:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHhpL-0006uX-KU; Tue, 17 Jan 2023 04:00:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHhp5-0006u0-LQ for guix-patches@gnu.org; Tue, 17 Jan 2023 04:00:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHhp5-0001JU-A0 for guix-patches@gnu.org; Tue, 17 Jan 2023 04:00:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHhp5-0007zw-4F for guix-patches@gnu.org; Tue, 17 Jan 2023 04:00:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60802] [PATCH v3 1/2] platforms: Raise an exception when no suitable platform is found. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Jan 2023 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60802 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: Tobias Geerinckx-Rice , 60802@debbugs.gnu.org, Maxim Cournoyer , Simon Tournier , Mathieu Othacehe , Christopher Baines , Ricardo Wurmus Received: via spool by 60802-submit@debbugs.gnu.org id=B60802.167394599930706 (code B ref 60802); Tue, 17 Jan 2023 09:00:02 +0000 Received: (at 60802) by debbugs.gnu.org; 17 Jan 2023 08:59:59 +0000 Received: from localhost ([127.0.0.1]:35636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHhp1-0007zC-Jf for submit@debbugs.gnu.org; Tue, 17 Jan 2023 03:59:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHhoz-0007yz-PL for 60802@debbugs.gnu.org; Tue, 17 Jan 2023 03:59:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHhos-0001IR-AA; Tue, 17 Jan 2023 03:59:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tlBggZt+vHmtWvRgCxAhkm3zw6eqrO72shWfZSV9x2Q=; b=EtrpyZElvXh1MEajt7IM YGgxahgRjrMfhNcVc/+PstVtp/mz8qqcuHMplaL4T3k7CRdCKVA5mqP+LCqHwO5tgWshLvYmMyxf4 S2b7KHIhajcEMU5JCmRjOzZnyrFpDFOJGWZRR30a4k3E/ISmYeUzhDCl0+8dptwxt4YtABnMA9oPM 2VEh3QcYKzWyqCakFGpiIwnRnJHLTfZ7D4p67ic2DlDc7/59WwEUFK5itYWW9aaRlTSrKkxRBe9aF lhv3S8V/c2TTGG0S+9zFMojj/w14HolOUkGO5PowQdJGyp+gMCAaf+m1YiKRBY2cxI3tEDpET1cbq xIGW8DnJsVw7eQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHhor-0007j0-9F; Tue, 17 Jan 2023 03:59:49 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230114151457.1903-2-maxim.cournoyer@gmail.com> <87zgajkiiy.fsf@jpoiret.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 =?UTF-8?Q?Niv=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Zinc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Jan 2023 09:59:46 +0100 In-Reply-To: <87zgajkiiy.fsf@jpoiret.xyz> (Josselin Poiret's message of "Sun, 15 Jan 2023 14:57:09 +0100") Message-ID: <87r0vtk03h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=EtrpyZEl; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673946033; a=rsa-sha256; cv=none; b=nR3yy9IQhLBMRRromvOQz/yArEyQIxNvKvidKHkOoii8tycbA/P7ZNDnjPfcns5X4d/vsQ 5LejLSjSaK5FaXWo52g1aISXsL1KG+UGN4kwTNL6bittxrU+trTSkgPr3UsjyvuI16m6Fy CEI5o5cu2UN0tJAOjOu6Wyp8pnyPLsYzDilE+DNEdk9QUMbvSF+v92cnpmLYjZIrie5NRO aah2UrJytI1owefJbRQs1IpVR1FIL2YRFFmsa7MG+qvRwo4n4KpUgvPNEt9onpS2cwzas7 4sI3GyNLjufGNUftMOK/Ndz4EOwdfZgTR8lVj2lFhT6RgG/tvPMMmhmKcVdBpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673946033; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tlBggZt+vHmtWvRgCxAhkm3zw6eqrO72shWfZSV9x2Q=; b=P+JsD4TMjroaV/eDL8PFqzgC7FG4gImYe6gzEaBlIZM/CiTxIZfngKFKtoHga/VARXkbpP LpgCQYo7N1xAi4z1MKa5swD+jN0rMZ/FvZGcoWLNXK22PqMGTRpGolesPy8kjM2KK1eg14 Lve5GgKz/9IEAh2vc/xcwMQkVgQ4vMAOBQsvobWvsFJgF/bLa5ydGTodAGOorLLIgs0z5T 3mo4Rl2YnNb6Nx8MzvX5BRJNh8Ar2AqlPPR8lQgrqouRadz1brURIS9+l3PTdlcwu6gLr1 A3ZeUXXxyEpvicpjfekFdzcBNPSPWcsPnFhpJ/S1awIxi2jZrS9ZCXM9p6zseA== X-Migadu-Queue-Id: 691CC1066D X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=EtrpyZEl; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -3.93 X-Spam-Score: -3.93 X-TUID: diojhUgtrhfp Hi Josselin, Josselin Poiret skribis: > This looks good to me, although in the grand scheme of things I wonder > if that change is a step forward: for those kinds of procedures, we > could expect consumers to instead always properly handle the #f case > themselves, rather than baby-sitting them and systematically relying on > exceptions in the parent procedure, no? As a caricatural example: the > SRFI-1 `find` could raise an exception instead of returning #f, but I > don't think anyone would consider that proper behaviour. I share this sentiment in general (plus the fact that we should keep UI aspects, such as error reports, separate from core logic). Here there=E2= =80=99s a precedent with other lookup procedures though (=E2=80=98lookup-bootloader-by-name=E2=80=99, =E2=80=98lookup-compressor=E2= =80=99, =E2=80=98lookup-image-type-by-name=E2=80=99, etc.), so I think it=E2=80=99s= okay to keep it that way. Ludo=E2=80=99.