unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: racin@free.fr
Cc: 60820@debbugs.gnu.org
Subject: [bug#60820] [PATCH] Add 'totpages' latex package.
Date: Tue, 24 Jan 2023 14:16:29 +0100	[thread overview]
Message-ID: <87r0vknkcy.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <2038367541.192525317.1674510934926.JavaMail.zimbra@free.fr> (racin@free.fr's message of "Mon, 23 Jan 2023 22:55:34 +0100 (CET)")

Hello,

racin@free.fr writes:

>> > +(define-public texlive-latex-totpages
>
>> The name should be texlive-totpages.
>
> Is there a reason why? The package lives under the latex/ directory, like the hyphenat and totpages package, which have latex- in their name.

Guix dropped the directory part in package names months ago. It doesn't
always make sense: some packages install files in more than one
top-level directory. Also, it was decided packages should follow TeXLive
naming scheme, as used in "texlive.tlpdb".

As another data point, if you import hyphenat

  guix shell subversion -- import texlive hyphenat

you can see the suggested name is "texlive-hyphenat":

  (... (simple-texlive-package "texlive-hyphenat" ...))

Note also that a number of deprecation functions in "tex.scm" already
move packages to the suggested naming scheme, e.g.:

  (define-deprecated-package texlive-latex-beamer texlive-beamer)

It is unfortunate that hyphenat package was pushed with the wrong name.
It will need a deprecation notice at some point.

>> > +  (package
>> > +    (inherit (simple-texlive-package "texlive-latex-totpages"
>> > +                                     (list "doc/latex/totpages/"
>> > +                                           "source/latex/totpages/"
>> > +                                           "tex/latex/totpages/")
>> > +                                     (base32
>> > +                                      "1mmya2fqdskyavw3hvdiygfyp9cll7bl4lpi7pl2jf9s7ds49j5a")
>> > +                                     #:trivial? #t))
>
> I am confused. The hyphenat package also has a .ins in its archive,
> and it is defined as a trivial package.

Again, current hyphenat package is wrong. You should not consider it as
an example. It simply does not install enough files.

Guix provides an helper function to determine if a TeXLive package is
complete or not, `files-differ?' in (guix import texlive):

  $ guix repl
  scheme@(guix-user)> ,use (guix import texlive)
  scheme@(guix-user)> (files-differ? "/gnu/store/n7pbka00i9y7jvbvqpm2jzf961cmlyya-texlive-latex-hyphenat-59745/share" "hyphenat")
  $1 = ("texmf-dist/source/latex/hyphenat/hyphenat.ins" "texmf-dist/source/latex/hyphenat/hyphenat.dtx")

It means that hyphenat package doesn't install its sources. Not good.

> Maybe I need to just remove source/latex/totpages from the list?

Please don't. I already suggested how to deal with the issue. Do not
hesitate to ping me if you have troubles with what I suggest.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2023-01-24 13:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-14 22:36 [bug#60820] [PATCH] Add 'totpages' latex package Matthieu Lemerre
2023-01-15 18:26 ` Nicolas Goaziou
2023-01-23 21:55   ` racin
2023-01-24 13:16     ` Nicolas Goaziou [this message]
2023-01-24 22:25       ` racin
2023-01-25 16:35         ` Nicolas Goaziou
2023-01-25 17:42           ` racin
2023-01-27  9:02             ` Nicolas Goaziou
2023-04-18 13:33               ` bug#60820: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0vknkcy.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=60820@debbugs.gnu.org \
    --cc=racin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).