unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Martin Marshall <law@martinmarshall.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 61163@debbugs.gnu.org
Subject: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package.
Date: Tue, 31 Jan 2023 12:53:59 -0500	[thread overview]
Message-ID: <87r0vak2tk.fsf@martinmarshall.com> (raw)
In-Reply-To: <87fsbq2411.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 31 Jan 2023 15:05:14 +0100")

[-- Attachment #1: Type: text/plain, Size: 1891 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>> +      (propagated-inputs (list font-awesome))
>
> It seems the project requires Font Awesome 6, but Guix only provides
> version 4. Is it an issue?

I don't think so.  While the default value of the `pretty-speedbar-font'
user-setting is "Font Awesome 6 Free Solid", the setting is
customizable, and any icon font may be used with the package.

Even with the default value of `pretty-speedbar-font' unchanged, my
system automatically uses the Font Awesome 4 fonts provided by Guix's
font-awesome package.

> It may be worth considering updating font-awesome in Guix first, but
> I don't know what its freedom status is nowadays (as a data point,
> Parabola provides it, tho).

There is a comment to its package definition stating this:

   ;; XXX The build scripts of version 5 are not freely licensed and
   ;; so we have to stick with version 4 for now:
   ;; <https://bugs.gnu.org/32916>

The linked discussion from 2018 concluded with all participants agreeing
that distribution of version 5 or higher would violate the Gnu FSDG.

I reviewed the Font Awesome GitHub Issues, and it seems they remain
unwilling to change the licensing terms for the build scripts, the matter
having been raised as late as March 2022.

There is a fork of Font Awesome whose stated goals are "to continue
building the amazing resource in a fully free, libre and open-source
fashion" (https://github.com/ForkAwesome/Fork-Awesome).  I haven't
used it though.

>> +      (description
>> +       "Generate and implement appealing SVG icons for the Emacs
>> Speedbar.  
>
> This is not a complete sentence.
>
> Could you send an updated patch?

Thank you for this and the other feedback provided.

I've rewritten the description along with the other suggested changes.

An updated patch is attached.

Warm regards,

-- 
Martin Marshall
law@martinmarshall.com

[-- Attachment #2: ~/Projects/guix/patches/0001-gnu-Add-emacs-pretty-speedbar.patch --]
[-- Type: message/external-body, Size: 111 bytes --]

  reply	other threads:[~2023-01-31 17:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30  6:36 [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package Martin Marshall
2023-01-31 14:05 ` Nicolas Goaziou
2023-01-31 17:53   ` Martin Marshall [this message]
2023-01-31 18:16     ` Martin Marshall
2023-02-01 21:19       ` bug#61163: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0vak2tk.fsf@martinmarshall.com \
    --to=law@martinmarshall.com \
    --cc=61163@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).