From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: conses <contact@conses.eu>
Cc: 61941@debbugs.gnu.org
Subject: [bug#61941] [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f.
Date: Wed, 08 Mar 2023 15:57:51 +0100 [thread overview]
Message-ID: <87r0tz8f4g.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <e6cad85daceaf8c46930268efce34f2fa7e96bf9.1677862554.git.contact@conses.eu> (conses's message of "Fri, 03 Mar 2023 17:58:26 +0100")
Hello,
conses <contact@conses.eu> writes:
> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.20.1c98f6f.
> [source]: Remove fix-docstring-test.patch.
> [propagated-inputs]: Remove emacs-shut-up.
Thank you. Some comments follow.
> + (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
> + (revision "0"))
Is there a particular reason to use an unreleased version?
> + (package
> + (name "emacs-helpful")
> + (version (git-version "0.20" revision commit))
Base version is actually still 0.19. Upstream bumped Version keyword,
but the README mentions there is no official 0.20 yet. I suggest to
stick to 0.19.
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/Wilfred/helpful")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + (list emacs-elisp-refs emacs-dash emacs-s emacs-f))
While you're at it, could you re-order inputs alphabetically?
You can also merge both patches.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-03-08 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 16:58 [bug#61941] [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f conses
2023-03-03 16:59 ` [bug#61941] [PATCH 2/2] gnu: Remove unused emacs-helpful-fix-docstring-test.patch conses
2023-03-08 14:57 ` Nicolas Goaziou [this message]
2023-03-09 22:47 ` [bug#61941] [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f conses
2023-03-09 22:55 ` [bug#61941] [PATCH v2] gnu: emacs-helpful: Update to 0.19.1c98f6f conses
2023-03-17 8:25 ` bug#61941: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0tz8f4g.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=61941@debbugs.gnu.org \
--cc=contact@conses.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).