unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Jelle Licht <jlicht@fsfe.org>
Cc: 61851-done@debbugs.gnu.org, Simon South <simon@simonsouth.net>
Subject: bug#61851: [PATCH] gnu: tesseract-ocr-tessdata-fast: Install tesseract config files.
Date: Mon, 20 Mar 2023 23:13:19 -0400	[thread overview]
Message-ID: <87r0tiu78w.fsf@gmail.com> (raw)
In-Reply-To: <87o7osig94.fsf@fsfe.org> (Jelle Licht's message of "Thu, 16 Mar 2023 21:38:15 +0100")

Hello,

Jelle Licht <jlicht@fsfe.org> writes:

> Hey folks,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hello,
>>
>> Simon South <simon@simonsouth.net> writes:
>>
>>> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>>>> Would you be so kind as to open an issue with upstream about the
>>>> misleading doc?
>>>
>>> I would've submitted a patch already were the project not using GitHub.
>>> I don't have a GitHub account and don't intend to get one.
>>>
>>> Would anyone else be willing to be open an issue on this?
>>
>> No problem; see: https://github.com/tesseract-ocr/tesseract/issues/4025.
>
> So it seems the issue was confirmed. In addition there seems to be some
> inconsistencies between build system with regards to how the data dir is
> interpreted by tesseract:
>
> https://github.com/tesseract-ocr/tesseract/issues/4026
>
> I think it makes sense for us to apply [a version of] Simon's patch.  QA
> also seems to show green lights, ignoring the unrelated recent
> openmpi-related failures.
>
> WDYT?

I've now applied it, after writing a proper change log commit message,
and running the xvnc and lightdm system tests to get some confidence
(they make use of tesseract-ocr).

Thank you for looking into it!

-- 
Thanks,
Maxim




      reply	other threads:[~2023-03-21  3:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 20:55 [bug#61851] [PATCH] gnu: tesseract-ocr-tessdata-fast: Install tesseract config files jlicht
2023-02-27 22:43 ` Simon South
2023-02-27 22:48   ` [bug#61851] [PATCH] gnu: tesseract-ocr: Use standard TESSDATA_PREFIX Simon South
2023-02-28  0:31   ` [bug#61851] [PATCH] gnu: tesseract-ocr-tessdata-fast: Install tesseract config files Jelle Licht
2023-02-28 15:00     ` Simon South
2023-02-28 15:35       ` Maxim Cournoyer
2023-02-28 16:40         ` Simon South
2023-02-28 21:41           ` Maxim Cournoyer
2023-03-16 20:38             ` Jelle Licht
2023-03-21  3:13               ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0tiu78w.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=61851-done@debbugs.gnu.org \
    --cc=jlicht@fsfe.org \
    --cc=simon@simonsouth.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).