unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Brian Cully <bjc@spork.org>
Cc: 63044@debbugs.gnu.org, Lars-Dominik Braun <lars@6xq.net>,
	jgart <jgart@dismail.de>
Subject: [bug#63044] [PATCH] gnu: python-setuptools: Disable date checking in bdist_egg.py
Date: Wed, 03 May 2023 22:05:05 +0200	[thread overview]
Message-ID: <87r0rxyydq.fsf@gnu.org> (raw)
In-Reply-To: <87jzxskkpv.fsf@psyduck.jhoto.kublai.com> (Brian Cully's message of "Mon, 01 May 2023 13:36:32 -0400")

Hi,

Brian Cully <bjc@spork.org> skribis:

> Lars-Dominik Braun <lars@6xq.net> writes:
>
>> is it correct that this change is required only for packages *not*
>> using
>> python-build-system? python-build-system itself already has a phase
>> called ”ensure-no-mtimes-pre-1980“, which should fix the issue for
>> all Python packages. Can we use that phase for affected packages
>> (two,
>> so far) and/or factor it out of python-build-system?
>
> I've only run into the issue with ‘gnu-build-system’, and your
> explanation that ‘python-build-system’ has an extra phase would
> explain why.

Oh got it.  So yes, your proposal makes a lot of sense to me, Lars.

The way to do that is to add (guix build python-build-system) to
#:imported-modules and #:modules in those packages, and then to use
‘modify-phases’ to add that ‘ensure-no-mtimes-pre-1980’ phase to those
of ‘gnu-build-system’.

How does that sound, Brian?

We have similar shenanigans for other packages that use a primary build
system but need stuff from another one.

Thanks,
Ludo’.




  reply	other threads:[~2023-05-03 20:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24  0:14 [bug#63044] [PATCH core-updates] Fix criu and sssd Brian Cully via Guix-patches via
2023-04-24  1:18 ` [bug#63044] [PATCH 1/4] gnu: criu: Use gexps Brian Cully via Guix-patches via
2023-04-24  1:18   ` [bug#63044] [PATCH 2/4] guix: utils: add `change-file-timestamps-recursively' procedure Brian Cully via Guix-patches via
2023-04-24  1:18   ` [bug#63044] [PATCH 3/4] gnu: sssd: Change timestamps to 1-Jan-1980 before compressing Brian Cully via Guix-patches via
2023-04-24  1:18   ` [bug#63044] [PATCH 4/4] gnu: criu: " Brian Cully via Guix-patches via
2023-04-24 15:49 ` [bug#63044] [PATCH core-updates] Fix criu and sssd Brian Cully via Guix-patches via
2023-04-30 20:39   ` [bug#63044] [PATCH] gnu: python-setuptools: Disable date checking in bdist_egg.py Ludovic Courtès
2023-05-01  6:32     ` Lars-Dominik Braun
2023-05-01 17:36       ` Brian Cully via Guix-patches via
2023-05-03 20:05         ` Ludovic Courtès [this message]
2023-05-03 22:05           ` Brian Cully via Guix-patches via
2023-05-04  0:37             ` Brian Cully via Guix-patches via
2023-05-10 15:18               ` Ludovic Courtès
2023-05-12 22:37                 ` Brian Cully via Guix-patches via
2023-05-13  7:11               ` Lars-Dominik Braun
2023-05-02  0:32   ` jgart via Guix-patches via
2023-04-25 14:35 ` [bug#63044] [PATCH v2] gnu: python: " Brian Cully via Guix-patches via
2023-04-28 13:59   ` [bug#63044] [PATCH core-updates] Fix criu and sssd Brian Cully via Guix-patches via
2023-04-28 14:01 ` [bug#63044] [PATCH v3] gnu: python-setuptools: Disable date checking in bdist_egg.py Brian Cully via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0rxyydq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=63044@debbugs.gnu.org \
    --cc=bjc@spork.org \
    --cc=jgart@dismail.de \
    --cc=lars@6xq.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).