unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#63435] Add vcmi 1.2.1 to games.scm
@ 2023-05-11  5:43 Vagrant Cascadian
  2023-05-11 17:17 ` Liliana Marie Prikler
  0 siblings, 1 reply; 17+ messages in thread
From: Vagrant Cascadian @ 2023-05-11  5:43 UTC (permalink / raw)
  To: 63435; +Cc: liliana.prikler, iyzsong, liliana.prikler, iyzsong


[-- Attachment #1.1: Type: text/plain, Size: 1089 bytes --]

X-Debbugs-Cc: liliana.prikler@gmail.com, iyzsong@envs.net

The attached patch adds "vcmi", which is in many ways very similar to
the "fheroes2" package, in that it (currently) requires external
non-free assets, but the game engine itself is GPL2. They also both use
assets from the same game lineage (heroes of might and magic).

I struggled to get the tests to work, and they do not seem to be
terribly well maintained upstream. They are even disabled by default by
upstream. I did some very brief manual "testing" that it actually works,
at least!

I had successfully built with various qt*@6 packages, but they are not
currently building; it seems to support qt*@5 too.

Some things failed to build with gcc-11, so I tried gcc-12 and it
worked!

We probably want to try to apply Debian's "privacy-breach" patch to
disable phoning home, as well as the reproducible builds patch and some
additional reproducibility patches I am working on, but figured I would
submit the package to guix for review now, in case anyone else wants to
join me down this rabbit hole...


live well,
  vagrant

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-vcmi-1.2.1.patch --]
[-- Type: text/x-diff, Size: 3477 bytes --]

From 94eabedcac6fb61ae1ddd77c6c28f89594586017 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Sun, 7 May 2023 17:43:33 -0700
Subject: [PATCH] gnu: Add vcmi 1.2.1.

FIXME review debian patches:
  https://salsa.debian.org/games-team/vcmi/-/blob/master/debian/patches/disable-privacy-breach
  https://salsa.debian.org/games-team/vcmi/-/blob/master/debian/patches/reproducible.patch
  ...and secrent as-yet-unsubmitted reproducibility patches...
  https://salsa.debian.org/games-team/vcmi/-/blob/master/debian/patches/minizip_maxu32

X-Debbugs-Cc: liliana.prikler@gmail.com, iyzsong@envs.net

* gnu/packages/games.scm (vcmi): New variable.
---
 gnu/packages/games.scm | 48 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 2e3994543a..c2b60037cc 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -199,6 +199,7 @@ (define-module (gnu packages games)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages squirrel)
   #:use-module (gnu packages swig)
+  #:use-module (gnu packages tbb)
   #:use-module (gnu packages tcl)
   #:use-module (gnu packages terminals)
   #:use-module (gnu packages texinfo)
@@ -11169,6 +11170,53 @@ (define-public fheroes2
 play; it will look for them at @file{~/.local/share/fheroes2} folder.")
     (license license:gpl2)))
 
+(define-public vcmi
+  (package
+    (name "vcmi")
+    (version "1.2.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/vcmi/vcmi")
+                    (commit version)
+                    (recursive? #t)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1nx3i078cxkak2ci514pf4pgi5269mp08njynsg35pin4yp3fn0p"))))
+    (build-system cmake-build-system)
+    (arguments
+     ;; Test suites do not seem well supported upstream and are disabled by default.
+     ;; Pass -DENABLE_TEST to configure to enable.
+     `(#:tests? #f))
+    (native-inputs (list boost
+                         ffmpeg
+                         ;; Build errors with gcc-11
+                         gcc-12
+                         ;; googletest ; needed for tests, but tests are disabled
+                         libxkbcommon
+                         luajit
+                         minizip
+                         pkg-config
+                         python
+                         ;; qtbase and qttools @6 not currently buildable but may work ok
+                         qtbase-5
+                         qttools-5
+                         sdl2
+                         sdl2-mixer
+                         sdl2-image
+                         sdl2-ttf
+                         tbb
+                         vulkan-headers
+                         zlib))
+    (home-page "https://vcmi.eu/")
+    (synopsis "Turn-based strategy game engine")
+    (description
+     "@code{vcmi} is an implementation of Heroes of Might and
+Magic III (aka HOMM3) game engine.  It requires assets and game resources to
+play; it will look for them at @file{~/.local/share/vcmi} folder.")
+    (license license:gpl2)))
+
 (define-public apricots
   (package
     (name "apricots")

base-commit: e2eb43f945fd467e9b55a4b3c91cd186cf32e268
-- 
2.39.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply related	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2023-07-09  5:37 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-11  5:43 [bug#63435] Add vcmi 1.2.1 to games.scm Vagrant Cascadian
2023-05-11 17:17 ` Liliana Marie Prikler
2023-05-11 21:48   ` Vagrant Cascadian
2023-05-11 23:07     ` Vagrant Cascadian
2023-05-12  1:47       ` Liliana Marie Prikler
2023-05-12  6:17         ` Vagrant Cascadian
2023-05-12 20:53           ` Liliana Marie Prikler
2023-05-13  1:33             ` Vagrant Cascadian
2023-05-13  1:35               ` Vagrant Cascadian
2023-05-13  6:16                 ` Liliana Marie Prikler
2023-05-14 19:52                   ` Vagrant Cascadian
2023-05-15 18:31                     ` Liliana Marie Prikler
2023-05-15 19:07                       ` Vagrant Cascadian
2023-07-03  2:50                       ` Vagrant Cascadian
2023-07-09  5:36                         ` bug#63435: " Liliana Marie Prikler
2023-05-13  6:12               ` [bug#63435] " Liliana Marie Prikler
2023-05-14 19:50                 ` Vagrant Cascadian

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).