[bug#64738] [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[bug#64738] [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[Sigve Sudland]

* gnu/packages/gl.scm (mesa): Enable zstd compression.
---
 gnu/packages/gl.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gl.scm b/gnu/packages/gl.scm
index 1691086e1a..2f54d8553d 100644
--- a/gnu/packages/gl.scm
+++ b/gnu/packages/gl.scm
@@ -299,7 +299,8 @@ (define-public mesa
            libxvmc
            llvm-for-mesa
            wayland
-           wayland-protocols))
+           wayland-protocols
+           `(,zstd "lib")))
     (native-inputs
      (list bison
            flex
@@ -362,6 +363,9 @@ (define-public mesa
          ;; Enable the codecs that were built by default as part of the
          ;; 21.3.x releases to avoid functionality regressions.
          "-Dvideo-codecs=vc1dec,h264dec,h264enc,h265dec,h265enc"
+
+         ;; Enable ZSTD compression for shader cache
+         "-Dzstd=enabled"

          ;; Also enable the tests.
          "-Dbuild-tests=true"

base-commit: ebb54e6a5fba36a571ed239398ee3e0307a91c26
--
2.41.0

[bug#64738] [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[宋文武 via Guix-patches via]

Sigve Sudland <sigve_sudland@hotmail.com> writes:

> * gnu/packages/gl.scm (mesa): Enable zstd compression.

Good idea!  Follow our commit log style, I adjust it to:

    gnu: mesa: Enable zstd compression for shader cache.
    
    * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
    [arguments]: Add '-Dzstd=enabled' to configure-flags.


And apply it on the mesa-updates branch locally, wait it building, once
done I'll pushed it to the mesa-updates branch.  I think this issue
should be closed when it got merged into master.

Thank you!

[bug#64738] [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[宋文武 via Guix-patches via]

>
>     gnu: mesa: Enable zstd compression for shader cache.
>     
>     * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
>     [arguments]: Add '-Dzstd=enabled' to configure-flags.

Pushed to the mesa-updates branch, merging progress tracked in
https://issues.guix.gnu.org/64369.

Thanks.

[bug#64738] [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[John Kehayias via Guix-patches via]

On Thu, Jul 20, 2023 at 06:58 PM, 宋文武 wrote:

>>
>>     gnu: mesa: Enable zstd compression for shader cache.
>>
>>     * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
>>     [arguments]: Add '-Dzstd=enabled' to configure-flags.
>
> Pushed to the mesa-updates branch, merging progress tracked in
> https://issues.guix.gnu.org/64369.
>
> Thanks.

An update here: I reset mesa-updates to just be the 2 commits from
before this patch (that were already built on Cuirass) but rebased on
master. Based on how many builds may be new, we can see what to do. I
hope it is just a small amount of rebuilds so mesa-updates can be merged
as is, and then include this and other patches for the next round.

Hope that is okay, especially as I think this is a minor change to mesa,
rather than a bug or missing hardware support.

John

[bug#64738] [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[宋文武 via Guix-patches via]

John Kehayias <john.kehayias@protonmail.com> writes:

> On Thu, Jul 20, 2023 at 06:58 PM, 宋文武 wrote:
>
>>>
>>>     gnu: mesa: Enable zstd compression for shader cache.
>>>
>>>     * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
>>>     [arguments]: Add '-Dzstd=enabled' to configure-flags.
>>
>> Pushed to the mesa-updates branch, merging progress tracked in
>> https://issues.guix.gnu.org/64369.
>>
>> Thanks.
>
> An update here: I reset mesa-updates to just be the 2 commits from
> before this patch (that were already built on Cuirass) but rebased on
> master. Based on how many builds may be new, we can see what to do. I
> hope it is just a small amount of rebuilds so mesa-updates can be merged
> as is, and then include this and other patches for the next round.
>
> Hope that is okay, especially as I think this is a minor change to mesa,
> rather than a bug or missing hardware support.
>

That's fine, thank you for take care of it.

[bug#64738] [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[John Kehayias via Guix-patches via]

Hello,

On Fri, Jul 21, 2023 at 06:15 PM, 宋文武 wrote:

> John Kehayias <john.kehayias@protonmail.com> writes:
>
>> On Thu, Jul 20, 2023 at 06:58 PM, 宋文武 wrote:
>>
>>>>
>>>>     gnu: mesa: Enable zstd compression for shader cache.
>>>>
>>>>     * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
>>>>     [arguments]: Add '-Dzstd=enabled' to configure-flags.
>>>
>>> Pushed to the mesa-updates branch, merging progress tracked in
>>> <https://issues.guix.gnu.org/64369>.
>>>
>>> Thanks.
>>
>> An update here: I reset mesa-updates to just be the 2 commits from
>> before this patch (that were already built on Cuirass) but rebased on
>> master. Based on how many builds may be new, we can see what to do. I
>> hope it is just a small amount of rebuilds so mesa-updates can be merged
>> as is, and then include this and other patches for the next round.
>>
>> Hope that is okay, especially as I think this is a minor change to mesa,
>> rather than a bug or missing hardware support.
>>
>
> That's fine, thank you for take care of it.

I ended up adding this (and other changes) to mesa-updates along with
a mesa version bump and some other patches. Hopefully merging to
master in the next few days once substitutes look good.

Thanks!
John

bug#64738: [PATCH] gnu: Make Mesa use zstd compression for shader cache instead of zlib.

[John Kehayias via Guix-patches via]

On Tue, Jul 25, 2023 at 09:27 PM, John Kehayias wrote:

> Hello,
>
> On Fri, Jul 21, 2023 at 06:15 PM, 宋文武 wrote:
>
>> John Kehayias <john.kehayias@protonmail.com> writes:
>>
>>> On Thu, Jul 20, 2023 at 06:58 PM, 宋文武 wrote:
>>>
>>>>>
>>>>>     gnu: mesa: Enable zstd compression for shader cache.
>>>>>
>>>>>     * gnu/packages/gl.scm (mesa)[inputs]: Add zstd:lib.
>>>>>     [arguments]: Add '-Dzstd=enabled' to configure-flags.
>>>>
>>>> Pushed to the mesa-updates branch, merging progress tracked in
>>>> <https://issues.guix.gnu.org/64369>.
>>>>
>>>> Thanks.
>>>
>>> An update here: I reset mesa-updates to just be the 2 commits from
>>> before this patch (that were already built on Cuirass) but rebased on
>>> master. Based on how many builds may be new, we can see what to do. I
>>> hope it is just a small amount of rebuilds so mesa-updates can be merged
>>> as is, and then include this and other patches for the next round.
>>>
>>> Hope that is okay, especially as I think this is a minor change to mesa,
>>> rather than a bug or missing hardware support.
>>>
>>
>> That's fine, thank you for take care of it.
>
> I ended up adding this (and other changes) to mesa-updates along with
> a mesa version bump and some other patches. Hopefully merging to
> master in the next few days once substitutes look good.
>
> Thanks!
> John

Pushed as 090c254fe7713db330636dae2c204c8282207cc8. Thanks!