From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oLY5H4SuEWWGfwAAG6o9tA:P1 (envelope-from ) for ; Mon, 25 Sep 2023 18:00:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oLY5H4SuEWWGfwAAG6o9tA (envelope-from ) for ; Mon, 25 Sep 2023 18:00:04 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50289588ED for ; Mon, 25 Sep 2023 18:00:04 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SSDaxrMW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695657604; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pkj89XwWCF4oR0NWtTa/CO4CUjECZd9FaDSE9x/jytA=; b=MD1LRbWjr8ZBZBCGmoBleMHSmjHBqeVAhgefQwbOtFaBse5WTtMTiQ4Ji38xAzikp3JkMC 3H+obmmIpQBASJDbnAGmCqx4wjhRt1YAdbFvLrq/+a11DSajWKzGhj5fLXWzbEZ+YbzBGi YdRhdJxQ6ZgutlNbNqctg3sRt2vjXjE8flc3bINA1Qz6SQAy2TdTB7ETqJz7C9pETG9XUs xa8DbfDvZtj44W3W3M+C4v/FmDhpKvYUQrRB0GpidN+htkvP+owmqy2SNH1RSKwBPzr6DP jvX2RZzSmXEBWEBPlpLpgT9aokEI7dr+jPqdOMKEVMwn0bkLp9mlinAWHmfeWA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695657604; a=rsa-sha256; cv=none; b=kjp7Qv8QK+pKV1b7h6IjpfWUQviH2pjhE/4PlB5Gdmgt1Pb/OwH0uYBhmrAQanYJNJtPUO L0CH1MMBRGUrqpVU2GRT10i50/jxooGNMCEtNc+l49zl0ux5SASvv65BlFA003DE8IKeBL dnvbiyhO5v31IkU2mYjzw4jLrPB23sOESC7M5QG+seSfPDTdxaTzlc8UJdIR7e41EzIKh+ giOg1D/2wzO2VCwS4dqqFu1pHmR7uRkIiPkAq3GUZj5as6S4Mbc9AADJSXbCs+A4FAp37l fKgng6uWgxkxQYLKDluFp4W1AgT7h+TyaAylA8IN26VAgy7Q/bCFkQ/U2M0DUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SSDaxrMW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qko02-0008J6-Ln; Mon, 25 Sep 2023 11:59:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qknzz-0008Dv-CP for guix-patches@gnu.org; Mon, 25 Sep 2023 11:59:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qknzz-00067H-3b for guix-patches@gnu.org; Mon, 25 Sep 2023 11:59:51 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qko0A-0008S4-U8 for guix-patches@gnu.org; Mon, 25 Sep 2023 12:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Sep 2023 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 65866@debbugs.gnu.org, Christopher Baines Received: via spool by 65866-submit@debbugs.gnu.org id=B65866.169565758732432 (code B ref 65866); Mon, 25 Sep 2023 16:00:02 +0000 Received: (at 65866) by debbugs.gnu.org; 25 Sep 2023 15:59:47 +0000 Received: from localhost ([127.0.0.1]:46475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qknzr-0008Qy-Es for submit@debbugs.gnu.org; Mon, 25 Sep 2023 11:59:47 -0400 Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:47373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qknzl-0008Qd-QP for 65866@debbugs.gnu.org; Mon, 25 Sep 2023 11:59:42 -0400 Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-4181462ebf0so16804631cf.3 for <65866@debbugs.gnu.org>; Mon, 25 Sep 2023 08:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695657560; x=1696262360; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=pkj89XwWCF4oR0NWtTa/CO4CUjECZd9FaDSE9x/jytA=; b=SSDaxrMWtXbcNP0TB40Qve1HEuGsDdLofX8KCOW11IBHuALGiQnHUhv6m6WOnxyF1B Zrz1LjOGuf6PyX84JDmD2lR0tusxeiRzl8tyRG0FeATpXzRN0T2O/7LkqoNjjGgqSROw yn9HaQYvQ4L7WyS6OtZWjk7okDmn8xe7HSYjKqW1ZVcW1fDR82JfawL1KTgRliiJrWVu rg1AzBn6/GQF4srU2UimikrVegN2hS7N1tLz+PJjFXwh2l4KiHsw9Z8RyKoSwfZJrhqE psO9+i/Hqb0iAVFmc2Chzy1K25IemzL/iG3UB7QjyXuHOSRYu+sOxicy/J9zgP4APPJU HL2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695657560; x=1696262360; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pkj89XwWCF4oR0NWtTa/CO4CUjECZd9FaDSE9x/jytA=; b=NpMfoyWtGTplXyXC9WZc2I6hxC3UlTmk9/nB2qlzIvTS69gvCGMU0Xo8+N0RBUHg7W PMNV/eIT/2+7IoisQndXfeZrHxRi0KZkNqDemjCc6WbqOF1U5/GjSOXn1raYjNtQzVNj hiZVQUh7RyoZ3zgqrWSnNNnu8AeqZS0mQLacRi7Rg8+lo6+thJJBDPEKMStMoFeLlTzU qDsJbs8gP9dBtKn7b7juGJK7Fl32ksXIIJyMTlgC1A6Mn1Y5uaH7sLrg6t8M4UCeMYc9 FXYA9/yWyqjIhfKcI0MvPEoFh1qo+dDNr3lx+ms+MSAMM7sZF4WkVMM70ViyCSQW2QJm dfDg== X-Gm-Message-State: AOJu0YwwrJw8yNZvhfHzh4Y8KdN8/PUntj1Psal/e8YWEkW5xAW+azia fgypVWUMqSzIjitgpsZj42I= X-Google-Smtp-Source: AGHT+IHnBGIt4UkEj3LuxxP+ffzedeQFCch0qQH2JIjHtwobYdrz6as8VLTIPS68W7D2SAnT7Qji7w== X-Received: by 2002:a05:622a:7484:b0:418:1817:43a9 with SMTP id jk4-20020a05622a748400b00418181743a9mr3340750qtb.17.1695657559770; Mon, 25 Sep 2023 08:59:19 -0700 (PDT) Received: from hurd (dsl-10-130-229.b2b2c.ca. [72.10.130.229]) by smtp.gmail.com with ESMTPSA id ay24-20020a05622a229800b00417f62a8826sm3184437qtb.44.2023.09.25.08.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 08:59:19 -0700 (PDT) From: Maxim Cournoyer References: <4eca94501c2c1e9986e1f718eeccb3eb9276dcd4.1694441831.git.ludo@gnu.org> <87pm2c4tie.fsf_-_@gmail.com> <87a5tdamws.fsf_-_@gnu.org> Date: Mon, 25 Sep 2023 11:59:18 -0400 In-Reply-To: <87a5tdamws.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 23 Sep 2023 00:00:35 +0200") Message-ID: <87r0mm2qi1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 5.73 X-Migadu-Spam-Score: 5.73 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 50289588ED X-TUID: k199ubRfwlaJ Hello, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: >> >>> * configure.ac: Check for =E2=80=98git=E2=80=99 and substitute =E2=80= =98GIT=E2=80=99. >>> * guix/config.scm.in (%git): New variable. >>> * guix/self.scm (compiled-guix): Define =E2=80=98git=E2=80=99 and pass = it to >>> =E2=80=98make-config.scm=E2=80=99. >>> (make-config.scm): Add #:git; emit a =E2=80=98%git=E2=80=99 variable. >>> * doc/guix.texi (Requirements): Add it. >> >> I'm a bit confused; we *both* capture git from the build environment, >> and reference git from the git-minimal Guix package -- why can't we >> strictly rely on the captured Git from the environment? > > That=E2=80=99s because we have two build systems: Autotools and (guix sel= f). > It=E2=80=99s the same change semantically, but for each of these build sy= stems. Oof, thanks for explaining. >> Nitpick: this commit should be ordered before the daemon changes that >> requires it. > > I believe that=E2=80=99s the case. Indeed, I should sort by subject in Gnus when reviewing to get the correct ordering! The series LGTM with the comments from Simon and myself in other replies taken into account. --=20 Thanks, Maxim