From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wBJEFvgLG2WIggAAauVa8A:P1 (envelope-from ) for ; Mon, 02 Oct 2023 20:29:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wBJEFvgLG2WIggAAauVa8A (envelope-from ) for ; Mon, 02 Oct 2023 20:29:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 01C873AEDB for ; Mon, 2 Oct 2023 20:29:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=XRWZTPpd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696271352; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=KjaRl+uPvaaQeZW7PgojmRzxnqirlXz9fp+D18SFPOE=; b=YBy0GntR3iJAWU/smjGGF+8z/b/cqWuPiN08nbGcsIXaklZ+UVNoOmaa5Ap0SVVgoQcqPa QFqPLBHRvBO1dU+hFMrL92kavAsVZlzzFVv4NLTxWFhcRkfqM/3FxRsqpMlA4Pjmz3jEvx Zb4p/xtzDmgTdwmV7aGHxseW7zvXJhkeQ6HDD/rmhKn1gZVAY93nvImo+ZTb3xTZAa/EPf CmVb2qDRopuZB2jq/uXUkMfGUJKgUD52Je2GHWphQWE8cJ3QLEfRfHwJSLDamJgmeT2qu3 9wW8qiVCmzqh6Kjpayr5AnRzS9v84AKXzAAKZ31SeR2YAsmARbdVSN98sc+YYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=XRWZTPpd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696271352; a=rsa-sha256; cv=none; b=u1iW8UAeQ1xOnd8hzxDz2mCwQ4JbgF/LJWhQ5lg0zJMvYx3yDizhJnPb+N+1qF9B4b56p4 fCTbvgQ4eHkK2bXw4qLmRacI8Sg0YH/8vYLqbN8u3ck+XanQkiLjJeB93ulVXfMRx+BoB3 66OKO82CtS1G/GgEyuSHKCBvQWeOTLBc8ya/BTpTHySzrj1FonwVH76ai8KR5m840ZrHbx 2jngJyKEvFwwINaAQR5vKv816KcTLz8G3wckTxTRPIWeVhHrbxEQf8QtMNnCUZAKlZL8h1 NXGI1EkOUjVJQ7rpEvfKGnv3H2GyMmf964qyIGO/El1P2Ko/Z3jBf3jpm9h60g== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnNf2-0005Zp-TG; Mon, 02 Oct 2023 14:28:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnNez-0005Z9-I9 for guix-patches@gnu.org; Mon, 02 Oct 2023 14:28:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnNew-0001oU-59 for guix-patches@gnu.org; Mon, 02 Oct 2023 14:28:48 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnNfC-0002uQ-Gg for guix-patches@gnu.org; Mon, 02 Oct 2023 14:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63985] [PATCH RFC 0/5] Generic INI serializer & SRFI-171 for define-configuration Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Oct 2023 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 63985@debbugs.gnu.org Received: via spool by 63985-submit@debbugs.gnu.org id=B63985.169627131411143 (code B ref 63985); Mon, 02 Oct 2023 18:29:02 +0000 Received: (at 63985) by debbugs.gnu.org; 2 Oct 2023 18:28:34 +0000 Received: from localhost ([127.0.0.1]:37919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnNek-0002tf-89 for submit@debbugs.gnu.org; Mon, 02 Oct 2023 14:28:34 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:62866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnNeh-0002tR-Sr for 63985@debbugs.gnu.org; Mon, 02 Oct 2023 14:28:32 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-65b0216b067so19411296d6.1 for <63985@debbugs.gnu.org>; Mon, 02 Oct 2023 11:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696271289; x=1696876089; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KjaRl+uPvaaQeZW7PgojmRzxnqirlXz9fp+D18SFPOE=; b=XRWZTPpd0GDui1DYdA049L09Kt6r+g5R711J0CTsIML+Zk2cFbcQT0Q3qMkKvP3j2U IRVeQLDlZNKP5k0fhepEUU9li1g3eAyhg6L7gXrKzuBSmOztbXW7AV4tD6wLFFDicqGa uR1A1Kkwfc1KG7nwwxd7C/LxREmE6M2RkKKpAYfNecaVefwSSMnh1N0N12k7ctq91APK 0Q5idGhPx5Ykvz4tO+PdyU0ZV+mCt68E3mxH5ehGntd47PIaeloaV8XdAi+r7Tw0qV1q upkdyqgRtxWUeV+swhuSKzyf1BLU1RnKFEn0G+SXemjidm478qmIj1Vd1ox8DZ0LDapx k3Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696271289; x=1696876089; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KjaRl+uPvaaQeZW7PgojmRzxnqirlXz9fp+D18SFPOE=; b=cxt9gf2yMHQUpLL56tby2OfdS6vGCXoNjT6awJkeTKC5vBhbkSHV+m1wkCy4sCfxRJ v0aMc2XehwMxWVNen9JHvuI6vscpbI5egrV0nERQMJWt+ziXOrdS9ReZBDTGSISuCK9V LmRh/+/wIpWUMdQ4pwFHxyGR2qKIKZ5LP1IXP0HVPbSp6YI1Zpfnb+EQPkigsFm5+NOk 5NVkRhcsOjZM2Y7INFZUFrnwNksMW/yTjWFqgHhXH4dOKFTYlSa+1+eX8Whjut2jtGQG 4OsmWJRPqxk0USR1am3Iw1tM1QwyNNFoxm1bRmgVUi35I++aKifeANx1kpLjvDG2Psbw 5lXA== X-Gm-Message-State: AOJu0YyHcV7fBgy2pQZu5EyEUqOXHj7yH6B8EBz9G9bSjfVPNzF77btU PTDtepyrwDGkONUknxumJuwQ249YoEQ= X-Google-Smtp-Source: AGHT+IGSnwTAHgN7+tFp8TOH1rCZQwe2TMtBjTGjgid4OkalMMvevJfiy4IRbwtUauTExjiLEI5TLA== X-Received: by 2002:a0c:e114:0:b0:656:33c7:dfff with SMTP id w20-20020a0ce114000000b0065633c7dfffmr549165qvk.10.1696271289233; Mon, 02 Oct 2023 11:28:09 -0700 (PDT) Received: from hurd (dsl-10-136-90.b2b2c.ca. [72.10.136.90]) by smtp.gmail.com with ESMTPSA id m17-20020a0cdb91000000b0065d04135014sm4126586qvk.13.2023.10.02.11.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 11:28:08 -0700 (PDT) From: Maxim Cournoyer References: <3c9e04b336d5627af5167ff3b786918df724f3f6.1687816734.git.mirai@makinata.eu> Date: Mon, 02 Oct 2023 14:28:08 -0400 In-Reply-To: <3c9e04b336d5627af5167ff3b786918df724f3f6.1687816734.git.mirai@makinata.eu> (Bruno Victal's message of "Mon, 26 Jun 2023 22:59:30 +0100") Message-ID: <87r0mc3mmf.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.10 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 01C873AEDB X-Spam-Score: -5.10 X-TUID: 4eSH8PsX8Y4z Hi, Bruno Victal writes: > Rewrite this section to make it easier to document later syntactical > changes. > > * doc/guix.texi (Complex Configurations): Rewrite define-configuration > documentation. Fix simple serializer example. [...] > +@item @code{(serializer @var{serializer})} > +@var{serializer} is the name of a procedure which takes two arguments, > +the first is the name of the field, and the second is the value > +corresponding to the field. The procedure should return a string or > +@ref{G-Expressions} that represents the content that will be serialized > +to the configuration file. If none is specified, a procedure of the > +name @code{serialize-@var{type}} will be used. > + > +An example of a simple serializer procedure: > +@lisp > +(define (serialize-boolean field-name value) > + (let ((value (if value "true" "false"))) > + #~(string-append '#$field-name #$value))) > +@end lisp > + I know this is adapted from old code, but shouldn't there be a "=" in that string-append, between the field name and its value? Also, using gexps here seems unnecessary and may confuse the reader. The rest LGTM! -- Thanks, Maxim