unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: Liliana Marie Prikler <liliana.prikler@gmail.com>,
	66171@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>
Subject: [bug#66171] [PATCH v3] gnu: git: Install zsh completions and git-prompt.
Date: Tue, 03 Oct 2023 20:35:43 -0400	[thread overview]
Message-ID: <87r0mb6x7k.fsf@gmail.com> (raw)
In-Reply-To: <ZRqJakoaXC0snbry@3900XT> (Efraim Flashner's message of "Mon, 2 Oct 2023 12:12:10 +0300")

Hi,

Efraim Flashner <efraim@flashner.co.il> writes:

> On Mon, Oct 02, 2023 at 06:30:59AM +0200, Liliana Marie Prikler wrote:
>> Am Sonntag, dem 01.10.2023 um 23:34 -0400 schrieb Maxim Cournoyer:
>> > Hi Liliana,
>> > 
>> > Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>> > 
>> > > [...]
>> > Sorry if my previous reply was not clear, but with your
>> > clarifications I think it'd be best to keep the 'contrib' output,
>> > perhaps documenting in the description that it contains the 'git-
>> > prompt' command as well as completions for Zsh?
>> IMHO, a ‘contrib’ output would be silly, since so much of what we
>> install in other outputs are part of contrib.  The name lacks meaning.
>> 
>> As for why I put it in ‘out’ instead of ‘completion’, I did miss the
>> fact that we already install git completions for bash, so not that I
>> know, I just extended the phase that does that.
>
> It's not uncommon to see shell completions in a contrib directory. I
> think it'd make more sense to install them to a 'completions' output
> than to a 'contrib' output, but I think it would make the most sense to
> just install them to the 'out' output.

Sounds good!

-- 
Thanks,
Maxim




  reply	other threads:[~2023-10-04  0:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23 19:43 [bug#66171] [PATCH] gnu: git: Install shell completions Liliana Marie Prikler
2023-09-23 19:43 ` [bug#66171] [PATCH v3] gnu: git: Install zsh completions and git-prompt Liliana Marie Prikler
2023-10-02  3:34   ` Maxim Cournoyer
2023-10-02  4:30     ` Liliana Marie Prikler
2023-10-02  9:12       ` Efraim Flashner
2023-10-04  0:35         ` Maxim Cournoyer [this message]
2023-10-10  3:33   ` bug#66171: " Maxim Cournoyer
2023-09-23 19:43 ` [bug#66171] [PATCH v2] gnu: git: Install shell completions Liliana Marie Prikler
2023-09-25 17:51   ` [bug#66171] [PATCH] " Maxim Cournoyer
2023-09-25 18:41     ` Liliana Marie Prikler
2023-09-26 16:36       ` Maxim Cournoyer
2023-09-28 14:41       ` Efraim Flashner
2023-09-25 11:12 ` Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0mb6x7k.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66171@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=liliana.prikler@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).