From: Jelle Licht <jlicht@fsfe.org>
To: 66158@debbugs.gnu.org
Subject: [bug#66158] [PATCH] gnu: node-lts: Update to 18.18.0.
Date: Fri, 06 Oct 2023 17:59:25 +0200 [thread overview]
Message-ID: <87r0m7vj1e.fsf@fsfe.org> (raw)
In-Reply-To: <b6c80111b210fe06895f45fe54cde465cc757eb9.1695406392.git.jlicht@fsfe.org>
jlicht@fsfe.org writes:
> From: Jelle Licht <jlicht@fsfe.org>
>
> * gnu/packages/node.scm (node-lts): Update to 18.18.0.
> ---
>
> gnu/packages/node.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index d769066dc4..a933a83e98 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -738,14 +738,14 @@ (define-public llhttp-bootstrap
> (define-public node-lts
> (package
> (inherit node)
> - (version "18.17.1")
> + (version "18.18.0")
> (source (origin
> (method url-fetch)
> (uri (string-append "https://nodejs.org/dist/v" version
> "/node-v" version ".tar.gz"))
> (sha256
> (base32
> - "0dachvhf5jxrb1av8mn2dikbhwklxsgc9y2zg4h50fcwh5d54mqi"))
> + "0z54vhfbb6g8j92z21xh8yg7rb48lqwxjw45g0qnwpxnw1z4spsw"))
> (modules '((guix build utils)))
> (snippet
> '(begin
>
> base-commit: ec130e1a1b7f3b87b1a6e626754f7e7a07f6b717
> --
> 2.41.0
Heads up: this breaks our node-openzwave-shared build, which happens due
to a breaking change in the NPM that is shipped along with node. It will
not work for many local `npm run build' scripts that use node-gyp for
the same reason, so I don't think this should be merged as-is.
I'm keeping an eye on https://github.com/npm/cli/issues/6842 for a
proper fix, but if nobody objects, I'd like to try my hand at a custom
generated wrapper script in `$output/lib/node_modules/npm/bin/node-gyp'
that restores the older behaviour. We can revert this hack once there's
a proper fix in upstream.
Any thoughts?
- Jelle
next prev parent reply other threads:[~2023-10-06 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 18:13 [bug#66158] [PATCH] gnu: node-lts: Update to 18.18.0 jlicht
2023-10-06 15:59 ` Jelle Licht [this message]
2023-10-24 15:41 ` Ludovic Courtès
2023-10-27 16:02 ` [bug#66158] [PATCH v2] gnu: node-lts: Update to 18.18.2 jlicht
2023-11-03 9:53 ` Christopher Baines
2023-11-05 13:42 ` bug#66158: " Jelle Licht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0m7vj1e.fsf@fsfe.org \
--to=jlicht@fsfe.org \
--cc=66158@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).