unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
	paren@disroot.org, Tobias Geerinckx-Rice <me@tobias.gr>,
	Ricardo Wurmus <rekado@elephly.net>,
	Raghav Gururajan <rg@raghavgururajan.name>,
	64510@debbugs.gnu.org, jgart <jgart@dismail.de>,
	Mathieu Othacehe <othacehe@gnu.org>,
	Christopher Baines <guix@cbaines.net>
Subject: [bug#64510] [PATCH v1] gnu: Add simtrace-1
Date: Wed, 11 Oct 2023 19:19:58 +0200	[thread overview]
Message-ID: <87r0m1rs8x.fsf_-_@gnu.org> (raw)
In-Reply-To: <525e005b4c563deadc37f65f7293531b3e98702b.1696608951.git.GNUtoo@cyberdimension.org> (Denis Carikli's message of "Fri, 6 Oct 2023 18:16:59 +0200")

Hi,

Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> skribis:

> * gnu/packages/telephony.scm (simtrace-1): New variable.

[...]

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitea.osmocom.org/sim-card/simtrace")
> +                    (commit (string-append "v" version))))

Please add (git-file-name name version), as suggested by ‘guix lint’.

> +    (native-inputs (list dblatex docbook-xml-4.2 libfaketime pkg-config
> +                         texlive))

Could you replace the dependency on ‘texlive’ (the monolithic package,
more than 4 GiB) by a dependency on the relevant set of texlive-*
packages (info "(guix) Using TeX and LaTeX")?

There are examples you can borrow from under gnu/packages/….

Thanks,
Ludo’.




  parent reply	other threads:[~2023-10-11 17:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07 14:09 [bug#64510] [PATCH v1] gnu: Add simtrace-1 Denis 'GNUtoo' Carikli
2023-10-05 10:12 ` Christopher Baines
2023-10-06 12:53   ` Denis 'GNUtoo' Carikli
2023-10-06 13:07     ` Denis 'GNUtoo' Carikli
2023-10-06 16:16 ` [bug#64510] [PATCH v2] " Denis 'GNUtoo' Carikli
2023-10-11 17:16   ` [bug#64510] [PATCH v1] " Ludovic Courtès
2023-10-11 17:19   ` Ludovic Courtès [this message]
2024-01-12  5:47 ` [bug#64510] [PATCH v3] " Denis 'GNUtoo' Carikli
2024-01-24  0:05   ` Denis 'GNUtoo' Carikli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0m1rs8x.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=64510@debbugs.gnu.org \
    --cc=GNUtoo@cyberdimension.org \
    --cc=guix@cbaines.net \
    --cc=jgart@dismail.de \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=paren@disroot.org \
    --cc=rekado@elephly.net \
    --cc=rg@raghavgururajan.name \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).