From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EEWDE0M2KGWzWwAA9RJhRA:P1 (envelope-from ) for ; Thu, 12 Oct 2023 20:09:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EEWDE0M2KGWzWwAA9RJhRA (envelope-from ) for ; Thu, 12 Oct 2023 20:09:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1034C5AF0A for ; Thu, 12 Oct 2023 20:09:07 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=EM+Ms+U7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697134147; a=rsa-sha256; cv=none; b=BeDNI+eCB6rayh2cshacHvvRtKMInXqbBeSXblHkrs+pvATQJzBz6/cMXBz6BrRQyHHzpm hp1tb/QtlI0cwWIGkkxr22FEzKzyn2o7F8AZn2S0RrGHzmN6ot9WrbDyP63nELaSDt/GL/ q2LtN4xDKdkg69hAueduIknD7fH14NRtGnj65glDJi+UvdLYl9kNkjU1JqMO6IIovyAO3c FyZS6xSZPif2MgLSEZyU9rGODF3SklIe90rG1nqyEBXhLQ/y/cSPdbCCaa07g7zN0vD47U MSQR8ZkehO3s35i/5dtpjDGmk5fGc76lirm7z11iRim0ZXEpi0Tik6+JNFOBeQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=EM+Ms+U7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697134147; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VKW3bJkuJWKLyHGm0vBPOUO8N6JTKnxdJQikAR94EJ0=; b=ITxudgB9lIaTm+oN4EPy5hvGm02y42bl0FZBxJdYW3O5EbQXMoWcxyHWJP+7HelSRWm/hg VaugBV8MoUD5gk5xOfUIFOKZ39vsGSnlONxegPDK9S48uUFziWmqDG8FrIUrBokqJQUte6 iw6SXYt/Ho5javYbuXh0vuECDjUUdjJ0+4W1UIdTH51+Ju495JQ+KBnGTsLaM3cYVwuyo6 ItduBrH22vSoTtg3TLHKyBEy2lyP2UzfDECndJpjOk1E0K7UBduP/BwihGDPttqS6qaYo4 QITKwGUGS+L08VE4H/l8bnP4iNWnSoBDmvsw67G/mk8YFcJCdeIx3N0CYIKRdw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qr06z-0001Fz-Ca; Thu, 12 Oct 2023 14:08:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qr06x-0001F0-QJ for guix-patches@gnu.org; Thu, 12 Oct 2023 14:08:39 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qr06x-0002gD-I3 for guix-patches@gnu.org; Thu, 12 Oct 2023 14:08:39 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qr07J-0006S0-N8 for guix-patches@gnu.org; Thu, 12 Oct 2023 14:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66424] [PATCH core-updates] gnu: libxkbcommon: Fix cross-compile. References: <62c95fe412c55e9350adff139ff33cb6fe91db68.1696864062.git.zhengjunjie@iscas.ac.cn> In-Reply-To: <62c95fe412c55e9350adff139ff33cb6fe91db68.1696864062.git.zhengjunjie@iscas.ac.cn> Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Oct 2023 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66424 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Zheng Junjie Cc: 66424@debbugs.gnu.org, Maxim Cournoyer , Marius Bakke Received: via spool by 66424-submit@debbugs.gnu.org id=B66424.169713413524783 (code B ref 66424); Thu, 12 Oct 2023 18:09:01 +0000 Received: (at 66424) by debbugs.gnu.org; 12 Oct 2023 18:08:55 +0000 Received: from localhost ([127.0.0.1]:44255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qr07C-0006Rc-D1 for submit@debbugs.gnu.org; Thu, 12 Oct 2023 14:08:55 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:28187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qr077-0006RL-Ak for 66424@debbugs.gnu.org; Thu, 12 Oct 2023 14:08:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1697134100; x=1697393300; bh=VKW3bJkuJWKLyHGm0vBPOUO8N6JTKnxdJQikAR94EJ0=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=EM+Ms+U7rRkEMSp6erU3bAAxSZFNJ6Xbi1+jV/L2zvhPbmoukTBYtQ35niFGkm6xf w6C137lW80Y/+aFxs50xKR8FVPaF7Pllq4pYbJXSusPF7mU601Rq/rNeS4qtxnwscr Udr3sWuZ8co+X03kbUmxJmq0yQdJKmU684oKtK0TMx0M9E2Pgv6PiX/XfT/1wHBzLB dsCEKmSKE4NaidTPDnpPvkmujmJ9ZNv6oGLTUdOft508gYJ92BhcdtcZ3hN4f9rZ5h CbG4/UQjuyRW5TVL3tcRuotUtDzetqgMOA5gN6evSgcRCKPpUbfs8Gy/XhM0L3va0G O2BoNhbXt0VGw== Date: Thu, 12 Oct 2023 18:07:56 +0000 Message-ID: <87r0lz7lzg.fsf@protonmail.com> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -0.41 X-Spam-Score: -0.41 X-Migadu-Queue-Id: 1034C5AF0A X-TUID: r48hWISf0HkH Hello, (CC'ing authors of two related commits too) On Mon, Oct 09, 2023 at 11:07 PM, Zheng Junjie wrote: > * gnu/packages/xdisorg.scm (libxkbcommon): Fix cross-compile. > [native-inputs]: When cross-compile add PKG-CONFIG-FOR-BUILD. > --- > gnu/packages/xdisorg.scm | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm > index db948a9318..84bdcad031 100644 > --- a/gnu/packages/xdisorg.scm > +++ b/gnu/packages/xdisorg.scm > @@ -527,9 +527,13 @@ (define-public libxkbcommon > wayland-protocols > xkeyboard-config)) > (native-inputs > - (list bison doxygen pkg-config python > - ;; wayland-scanner is required at build time. > - wayland)) > + (append > + (if (%current-target-system) > + (list pkg-config-for-build) > + '()) > + (list bison doxygen pkg-config python > + ;; wayland-scanner is required at build time. > + wayland))) > (arguments > (list #:configure-flags > #~(list (string-append "-Dxkb-config-root=3D" > > base-commit: 9b77bd0b9b4f3de69390da0ba7db5b9dbc01e554 When searching the log it looked like this had already been done on core-updates in 5841ac3981a3a08968704728cef14accd14e7a1c (Marius) but I was confused when I didn't see it. Looks like the pkg-config-for-build was dropped (accidentally?) in 5841ac3981a3a08968704728cef14accd14e7a1c (Maxim) Is this still needed? And if so, I can do it on mesa-updates very soon, since libx11 and libxpm will be ungrafted and related packages (like mesa) updated too. Or we can leave it to core-updates if that makes more sense. WDYT? Thanks! John