From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id wNgEMJsF6GUOzgAAqHPOHw:P1 (envelope-from ) for ; Wed, 06 Mar 2024 06:56:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wNgEMJsF6GUOzgAAqHPOHw (envelope-from ) for ; Wed, 06 Mar 2024 06:56:43 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=IkxzWF9u; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709704603; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8+sn1xX3GlBAx4eW8BJZpoOmhFF6vOrHBRgm3rnGstM=; b=T6EwlTJBtP/C2ZNy1wWqZqfkeGFJzW/ToiFKW5Q9ZhphWXvBYUcuV3bjPdpL7h3ml3BjBu qaeNO1TRU0tEt+xeo3dV+0gQIchhqf/6SGXLGS8m+F7kLwHp5sPQU8dBCKJTByXmEgf/zv i26sGhU7Yzu245VAxfkFKpB4fBr6IE9exRB1gwNro4sFRmZYOLPIZPVwac5kXL3XDQQU/r cLZLxn4iSGt1OFqImFadsPBZ/vKM88XLAaU4SKQjV0R5eWdiYhyl35BKV/l0Oz519SbLQl jOO6B+yA/IIlafG/sTD5jSjXJL5ag6IN6woNBlAOiSot5vJYhBpcgAbAkvWi1g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=IkxzWF9u; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709704603; a=rsa-sha256; cv=none; b=CfyQg6WA0rx+nDlUgBMSFchy7kdrJdEgTscGg/M9Pckm9/XvtTJ0MSxyNJuq2KfuZlqVLw 9biNbbugTHSUAfK/fOOzU+rR5jH53w7W8oR6XhpKJvbOZQNTj5M6zDoXUVkl/D3JwyfLu0 p/sx0l8TBUPCFCSfDSXBYg/L3g0uuqU/tfEh1GQU1zJBbzZnfNjNw39ReCkHpOmC8/F8/C Kfxnjp2bInE7wzlIKlRKTJa7R3+zrMCcu/4ZQIlujBCmsuOu8DMUNpZ/H7JulBYboXtcj8 FCKlMKuxPm6V1GtrNcDuIlzBeAlyZbMOY6lsIMzI8p+gXCO8nfHa0hRwVKGEqw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D99E10C5A for ; Wed, 6 Mar 2024 06:56:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhkGZ-0002py-Fz; Wed, 06 Mar 2024 00:56:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhkGW-0002pm-2s for guix-patches@gnu.org; Wed, 06 Mar 2024 00:56:32 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhkGV-0000pC-F5 for guix-patches@gnu.org; Wed, 06 Mar 2024 00:56:31 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhkH0-00004v-2S for guix-patches@gnu.org; Wed, 06 Mar 2024 00:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#65155] [PATCH] gnu: mesa: Add native-search-paths. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 06 Mar 2024 05:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65155 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: David Elsing Cc: 65155@debbugs.gnu.org, i@dan.games Received: via spool by 65155-submit@debbugs.gnu.org id=B65155.170970459332732 (code B ref 65155); Wed, 06 Mar 2024 05:57:02 +0000 Received: (at 65155) by debbugs.gnu.org; 6 Mar 2024 05:56:33 +0000 Received: from localhost ([127.0.0.1]:49477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhkGX-0008Vs-19 for submit@debbugs.gnu.org; Wed, 06 Mar 2024 00:56:33 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:14619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhkGV-0008Vd-1E for 65155@debbugs.gnu.org; Wed, 06 Mar 2024 00:56:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1709704554; x=1709963754; bh=8+sn1xX3GlBAx4eW8BJZpoOmhFF6vOrHBRgm3rnGstM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=IkxzWF9uV7YPzfgaNZ69PNpO58sKGgtSEtUiBnHbQUnYN8wRBzfVhwXslKeKAY2Us HbvAOWVaLJujCAIPx1PFdF0/ZztIRfM9Nx9JgHLHMBxzoHtGInotV3gnKDFRXREsdG Nj0TkB6RtuwSsSJEDJ9TRcJUaGmNqwdCDZThfuD34W2g0mTc6mWSv+IRf1ill3rYFt 1wZi6kwQMfLUL5O6InIzMQ53XOj5NrbOWcGC57rhHjmx6V1/zw9FdsqqL7bjWMuJQh ld6HFsgKLHsTY+1bnIiP328SA0FBbJm0d/WR+aIVQsorNONoFNNDSW5mxI84HkZCUh g5WSM8cB4RkYw== Date: Wed, 06 Mar 2024 05:55:35 +0000 Message-ID: <87r0gn7vl9.fsf@protonmail.com> In-Reply-To: <86jznanbrf.fsf@posteo.net> References: <86jznanbrf.fsf@posteo.net> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.78 X-Spam-Score: -6.78 X-Migadu-Queue-Id: 8D99E10C5A X-TUID: rDYfrW05tOHo Hi David and dan, On Sun, Feb 11, 2024 at 05:36 PM, David Elsing wrote: > Hello, > > John Kehayias writes: > >> So perhaps this belongs in vulkan-loader? Although I admit I'm less sure >> for XDG_* related paths. Is there a test case or something we can see if >> this does what is intended for vulkan? > > I also noticed the same problem and agree that the search path belongs > in the vulkan-loader package: > > diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm > index 285d6be7f5..98ce979652 100644 > --- a/gnu/packages/vulkan.scm > +++ b/gnu/packages/vulkan.scm > @@ -303,6 +303,11 @@ (define-public vulkan-loader > wayland)) > (inputs > (list vulkan-headers libxrandr)) > + (native-search-paths > + (list > + (search-path-specification > + (variable "XDG_DATA_DIRS") > + (files '("share"))))) > (home-page > "https://github.com/KhronosGroup/Vulkan-Loader") > (synopsis "Khronos official ICD loader and validation layers for Vul= kan") > Thanks for the diff, which I also tried. > > I tested it with > > guix shell -C vulkan-tools vulkan-loader mesa --no-grafts -- vulkaninfo > > which works with the patch applied. As documented in [1], vulkan-loader > still needs to be part of the profile for the search path to take effect. > > Cheers, > David > > [1] https://guix.gnu.org/manual/en/html_node/Search-Paths.html Yes, this also works for me. It is also works on my machine when dropping "mesa" and the "-C" without this diff; presumably because of how my environment exists and XDG_DATA_DIRS. Probably in most desktop setups things already work for Vulkan (or we'd have more bug reports?) with any typical desktop/graphical packages. Still, this seems like this should be more explicit like in the above diff for exactly the case of things like containers or minimal testing environments. I can apply such a change on mesa-updates soon when I make the other mesa/vulkan/etc. updates we have pending. Feel free to submit a more formal patch here so I can credit you as the author, though I should be able to do the same on my own anyway. Thanks for the diff and testing! John