From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: 70344@debbugs.gnu.org
Cc: Wilko Meyer <w@wmeyer.eu>, Christopher Baines <mail@cbaines.net>
Subject: [bug#70344] Increase verbosity of diffoscope test suite
Date: Thu, 11 Apr 2024 12:50:54 -0700 [thread overview]
Message-ID: <87r0fb3cgx.fsf@wireframe> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 549 bytes --]
The attached patch increases the verbosity of the test suite, showing
each test on it's own line and provides a useful summary, often
including a reason why skipped tests were skipped.
This can be useful to help find additional packages to add for broader
test coverage, inspired by discussion in
https://issues.guix.gnu.org/70293
This also reveals that the conditional to add "enjarify" to
native-inputs on x86_64 is not working correctly... and plausibly could
reveal other similar issues with other missing native-inputs.
live well,
vagrant
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-diffoscope-Increase-test-verbosity.patch --]
[-- Type: text/x-diff, Size: 1152 bytes --]
From b1475226dc655986e97445dca889d4b0c362215c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 11 Apr 2024 12:40:19 -0700
Subject: [PATCH] gnu: diffoscope: Increase test verbosity.
* gnu/packages/diffoscope.scm (diffoscope)[phases]: Replace 'check.
---
gnu/packages/diffoscope.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
index 3db52e5008..8106a6d258 100644
--- a/gnu/packages/diffoscope.scm
+++ b/gnu/packages/diffoscope.scm
@@ -139,6 +139,11 @@ (define (bin command)
(lambda _
;; This requires /sbin to be in $PATH.
(delete-file "tests/test_tools.py")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ ;; Increase verbosity of tests and provide a summary
+ (invoke "pytest" "-vv" "-r" "sxX"))))
(add-after 'install 'install-man-page
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
--
2.39.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next reply other threads:[~2024-04-11 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 19:50 Vagrant Cascadian [this message]
[not found] ` <87bk6byndq.fsf@cbaines.net>
2024-05-18 3:08 ` bug#70344: Increase verbosity of diffoscope test suite Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0fb3cgx.fsf@wireframe \
--to=vagrant@reproducible-builds.org \
--cc=70344@debbugs.gnu.org \
--cc=mail@cbaines.net \
--cc=w@wmeyer.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).