From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id sKf8ANxsNmZp3gAAqHPOHw:P1 (envelope-from ) for ; Sat, 04 May 2024 19:14:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id sKf8ANxsNmZp3gAAqHPOHw (envelope-from ) for ; Sat, 04 May 2024 19:14:04 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jXtaAhU7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714842843; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XPPmdYSarRGLQJSLK4/m1fmHWzfqD+W/L8wcxiXs9vk=; b=djNS5WlzKSvRXMFoPvC7OtgM3NTARFLMl9vDWwkHudhQNRKO0V62wa/V5fM9i6+HduFa5u A1SFDgRFTmXwzp69+yiFS1o0Z00P9SVUQZ2whRK+022XUTKQvJYBL5jDiZD8KRh4DNIszc /c7gFGqAPdZxnI++AuUvJXGCSBe/FLg632oGN/K273yd7mZHKYs1DScLCwbkJ+QVP1vePl rXMkfd6ISIsipr1RfgX8ibMpuO6lpn45dvqMD2EOb67EVxnl7vIHElrSvR90gB1gcoVTqc vtAFz+SbxPE8NArAAv8eF/xDI5zweXAzpotSKHis6VMibvaadQw8JHiFG+xNkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jXtaAhU7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714842843; a=rsa-sha256; cv=none; b=hDPYKXvtVnp2jFtYtB2Lsr8M+pYelSbed+QhDOoSGnP0N9aTjc2FEcgJRR9winhXc+HdXN GJ9qNAmr9dCw7eew3IUz5I5BjQAY3EzHkui+E/ku9PGKIQMLLo3KU5owmkI2Nz9SCM/rYs z3FuorLSCfNK0+HJ499uUk//VcCAMrFLCNc7QbWPjtd13fVb1FhwN+p7FYeB4XCcpr5Jgq 0pkrQsElycZ9uLvriq6Hjxyk1WYoSJ8+QGGr/M/wV2FDMgT+NdX147rijs+dlG6LYt/kH4 gpF5q9NoJUxjWrTVjlIupZWnBf10W8YJZdZqEyEz3rnHmHAvYdGpWxpewHY6SQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BF7E0501EC for ; Sat, 4 May 2024 19:14:03 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3IxB-0005V8-Nz; Sat, 04 May 2024 13:13:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3Ix9-0005Uk-VU for guix-patches@gnu.org; Sat, 04 May 2024 13:13:40 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3Ix9-0005SR-Nc for guix-patches@gnu.org; Sat, 04 May 2024 13:13:39 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3IxW-00067R-Py for guix-patches@gnu.org; Sat, 04 May 2024 13:14:02 -0400 Subject: bug#70263: [PATCH] gnu: guix-configuration: Improve offload build-machines. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 04 May 2024 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ian Eure Cc: 70263-done@debbugs.gnu.org Mail-Followup-To: 70263@debbugs.gnu.org, ludo@gnu.org, ian@retrospec.tv Received: via spool by 70263-done@debbugs.gnu.org id=D70263.171484281623487 (code D ref 70263); Sat, 04 May 2024 17:14:02 +0000 Received: (at 70263-done) by debbugs.gnu.org; 4 May 2024 17:13:36 +0000 Received: from localhost ([127.0.0.1]:54734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Ix5-00066l-RT for submit@debbugs.gnu.org; Sat, 04 May 2024 13:13:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Ix1-00066T-Ax for 70263-done@debbugs.gnu.org; Sat, 04 May 2024 13:13:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3IwY-0005Pq-DR; Sat, 04 May 2024 13:13:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=XPPmdYSarRGLQJSLK4/m1fmHWzfqD+W/L8wcxiXs9vk=; b=jXtaAhU7DrYzurEBwK8q /7w+M/J8FkKF3AnendF6ryAuYfpE/8FzkdNqpeAs6enHEqGoj+p+QGFyueG5G0kxYmADoozqbcV7L jHUCna9vK8sOVmbpV7zLCiwmKdS6SMSKh44HOXO4KjbN/JK0M0E0CdLesvsBDWg/nIWzFugz6bFRM 8y9n18GWOLh6Z7yC98i80ragWDHEajiLJFf9P8P1wft0YmZx4jkMf8zIfiDpCSTwWBIyrjJHoFQ3N Wf5vu5BmM7K1Lxls1Eo2o/9jtW4eimvao0eBMmwK0te5o/UHrXdqJmCPDO/619ncAXudawCnaRzC7 JVfKsZyxW8codg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <7d5b40b2df8b68e1aafc881080680824e6655460.1712517547.git.ian@retrospec.tv> (Ian Eure's message of "Sun, 7 Apr 2024 12:20:59 -0700") References: <7d5b40b2df8b68e1aafc881080680824e6655460.1712517547.git.ian@retrospec.tv> Date: Sat, 04 May 2024 19:12:59 +0200 Message-ID: <87r0ehsdpg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.09 X-Spam-Score: -7.09 X-Migadu-Queue-Id: BF7E0501EC X-Migadu-Scanner: mx13.migadu.com X-TUID: 3q0YmhR05h5f Hi Ian, Ian Eure skribis: > It=E2=80=99s currently difficult to programmatically add a build-machine,= because the > `service-extension' mechanism is the only facility which can do that. It > relies on the `guix-service-type', ala: > > (service-extension guix-service-type > (guix-extension (build-machines (list ...)))) > > ...but `guix-service-type' is already instantiated as part of > `%base-services', and replacing it may lose other configuration, like > substitute servers and authorized keys. > > Additionally, a default value of `#f' for the build-machines field requir= es > guarding uses of the field with: > > (or (guix-build-machines config) '()) > > Changing the default to be the empty list avoids that. One can now add > build-machines with code such as: > > (modify-services %base-services > (guix-service-type > config =3D> > (guix-configuration > (inherit config) > (authorized-keys > (cons %build-machine-key > (guix-configuration-authorized-keys config))) > (build-machines (cons #~(build-machine ...) > (guix-configuration-build-machines config))= )))) > > * gnu/services/base.scm (guix-configuration): Rename `guix-build-machines= ' to > `guix-configuration-build-machines' and export it. Change the default fr= om > `#f' to the empty list. > * gnu/services/base.scm (guix-activation): Update the build-machines test= and > reverse the conditions. That makes a lot of sense to me. Applied, thanks! Ludo=E2=80=99.