unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#72387] Fix reproducible build for readymedia
@ 2024-07-30 23:24 Vagrant Cascadian
  2024-08-01 15:56 ` bug#72387: " Z572
  0 siblings, 1 reply; 2+ messages in thread
From: Vagrant Cascadian @ 2024-07-30 23:24 UTC (permalink / raw)
  To: 72387


[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]

The attached patch should fix build reproducibility issues of
"readymedia" by avoiding embedding the running kernel version of the
build machine.

This was one of the examples used in the Reproducible Builds patch
session On July 11th!

  https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024

live well,
  vagrant

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-readymedia-Fix-reproducible-build.patch --]
[-- Type: text/x-diff, Size: 1110 bytes --]

From e40dc4bc9633a44fc10ea49007618a41fa598d99 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 3 Jul 2024 14:00:34 -0700
Subject: [PATCH] gnu: readymedia: Fix reproducible build.

* gnu/packages/upnp.scm (readymedia)[configure-flags]: Avoid embedding kernel
version.
---
 gnu/packages/upnp.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
index aab68a6414..5514b3632b 100644
--- a/gnu/packages/upnp.scm
+++ b/gnu/packages/upnp.scm
@@ -150,7 +150,8 @@ (define-public readymedia
         (base32 "1al04jx72bxwqch1nv9lx536mb6pvj7pgnqzy6lm32q6xa114yr2"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:configure-flags '("--with-os-name=Linux")      ; uname -s
+     `(#:configure-flags '("--with-os-name=Linux" ; uname -s
+                           "--with-os-version=") ; uname -r
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-source

base-commit: 2aa0127d4e3d2363c04caab88137b070b6cf1318
-- 
2.39.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#72387: Fix reproducible build for readymedia
  2024-07-30 23:24 [bug#72387] Fix reproducible build for readymedia Vagrant Cascadian
@ 2024-08-01 15:56 ` Z572
  0 siblings, 0 replies; 2+ messages in thread
From: Z572 @ 2024-08-01 15:56 UTC (permalink / raw)
  To: Vagrant Cascadian; +Cc: 72387-done

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

Vagrant Cascadian <vagrant@reproducible-builds.org> writes:

> The attached patch should fix build reproducibility issues of
> "readymedia" by avoiding embedding the running kernel version of the
> build machine.
>
> This was one of the examples used in the Reproducible Builds patch
> session On July 11th!
>
>   https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024
>
> live well,
>   vagrant
>
> [2. text/x-diff; 0001-gnu-readymedia-Fix-reproducible-build.patch]
> From e40dc4bc9633a44fc10ea49007618a41fa598d99 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@reproducible-builds.org>
> Date: Wed, 3 Jul 2024 14:00:34 -0700
> Subject: [PATCH] gnu: readymedia: Fix reproducible build.
>
> * gnu/packages/upnp.scm (readymedia)[configure-flags]: Avoid embedding kernel
> version.
> ---
>  gnu/packages/upnp.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
> index aab68a6414..5514b3632b 100644
> --- a/gnu/packages/upnp.scm
> +++ b/gnu/packages/upnp.scm
> @@ -150,7 +150,8 @@ (define-public readymedia
>          (base32 "1al04jx72bxwqch1nv9lx536mb6pvj7pgnqzy6lm32q6xa114yr2"))))
>      (build-system gnu-build-system)
>      (arguments
> -     `(#:configure-flags '("--with-os-name=Linux")      ; uname -s
> +     `(#:configure-flags '("--with-os-name=Linux" ; uname -s
> +                           "--with-os-version=") ; uname -r
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-source
>
> base-commit: 2aa0127d4e3d2363c04caab88137b070b6cf1318

Thanks, push, close.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-01 16:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 23:24 [bug#72387] Fix reproducible build for readymedia Vagrant Cascadian
2024-08-01 15:56 ` bug#72387: " Z572

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).