[bug#74092] [PATCH] fix gnutls package

[bug#74092] [PATCH] fix gnutls package

[Adam Quandour]

Actual hash of this package is not the same as the specified one.
---
 gnu/packages/tls.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index 1a1ce0d..4f862ff 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -212,7 +212,7 @@ (define-public gnutls
               (patches (search-patches "gnutls-skip-trust-store-test.patch"))
               (sha256
                (base32
-                "0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp"))))
+                "0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa"))))
     (build-system gnu-build-system)
     (arguments
      (list #:tests? (not (or (%current-target-system)
-- 
2.46.0

[bug#74092] [PATCH] fix gnutls package

[Tomas Volf]

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

Adam Quandour <adam.quandour@gmail.com> writes:

> Actual hash of this package is not the same as the specified one.
> ---
>  gnu/packages/tls.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
> index 1a1ce0d..4f862ff 100644
> --- a/gnu/packages/tls.scm
> +++ b/gnu/packages/tls.scm
> @@ -212,7 +212,7 @@ (define-public gnutls
>                (patches (search-patches "gnutls-skip-trust-store-test.patch"))
>                (sha256
>                 (base32
> -                "0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp"))))
> +                "0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa"))))

When I download the release from the official website[0], via the gnupg
ftp[1], I do get the file with the old hash[2].

I am not sure what is going on here, but the discrepancy should be
investigated and documented in the commit message.  Just adjusting the
hash is probably not the best choice.

I would assume the upstream[0] should be the authoritative source for
the hash, not the mirror.

0: https://gnutls.org/download.html
1: https://www.gnupg.org/ftp/gcrypt/gnutls/v3.8/
2: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp

>      (build-system gnu-build-system)
>      (arguments
>       (list #:tests? (not (or (%current-target-system)

Have a nice day,
Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

[bug#74092] [PATCH] fix gnutls package

[Adam]

[-- Attachment #1: Type: text/plain, Size: 2503 bytes --]

The main reason I wrote the patch - I cannot build gnutls@3.8.3 from source
code.
This command
```
guix build gnutls@3.8.3 --no-substitutes
```
returns me this
```
  expected hash: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp
  actual hash:   0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa
hash mismatch for store item
'/gnu/store/9zh4mcmwp2afyl4ig56943w64czdz2kp-gnutls-3.8.3.tar.xz'
```
Guix I'm using
```
    guix:
      repository URL: https://git.savannah.gnu.org/git/guix.git
      branch: master
      commit: 4009d1de954d694cb11af391d4113d29c5c1379d
```
Am I getting it right - you are suggesting I
replace "mirror://gnupg/gnutls/v" with
"https://gnutls.org/" or "ftp://gnutls.org" ?
I'm asking because I'm not the original author of this package, so it's not
obvious to me,
what will be the right decision here?

On Tue, Oct 29, 2024 at 8:59 PM Tomas Volf <~@wolfsden.cz> wrote:
>
> Adam Quandour <adam.quandour@gmail.com> writes:
>
> > Actual hash of this package is not the same as the specified one.
> > ---
> >  gnu/packages/tls.scm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
> > index 1a1ce0d..4f862ff 100644
> > --- a/gnu/packages/tls.scm
> > +++ b/gnu/packages/tls.scm
> > @@ -212,7 +212,7 @@ (define-public gnutls
> >                (patches (search-patches
"gnutls-skip-trust-store-test.patch"))
> >                (sha256
> >                 (base32
> > -
 "0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp"))))
> > +
 "0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa"))))
>
> When I download the release from the official website[0], via the gnupg
> ftp[1], I do get the file with the old hash[2].
>
> I am not sure what is going on here, but the discrepancy should be
> investigated and documented in the commit message.  Just adjusting the
> hash is probably not the best choice.
>
> I would assume the upstream[0] should be the authoritative source for
> the hash, not the mirror.
>
> 0: https://gnutls.org/download.html
> 1: https://www.gnupg.org/ftp/gcrypt/gnutls/v3.8/
> 2: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp
>
> >      (build-system gnu-build-system)
> >      (arguments
> >       (list #:tests? (not (or (%current-target-system)
>
> Have a nice day,
> Tomas
>
> --
> There are only two hard things in Computer Science:
> cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: Type: text/html, Size: 3416 bytes --]

[bug#74092] [PATCH] fix gnutls package

[Tomas Volf]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

Adam <adam.quandour@gmail.com> writes:

> The main reason I wrote the patch - I cannot build gnutls@3.8.3 from source
> code.
> This command
> ```
> guix build gnutls@3.8.3 --no-substitutes
> ```
> returns me this
> ```
>   expected hash: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp
>   actual hash:   0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa
> hash mismatch for store item
> '/gnu/store/9zh4mcmwp2afyl4ig56943w64czdz2kp-gnutls-3.8.3.tar.xz'
> ```
> Guix I'm using
> ```
>     guix:
>       repository URL: https://git.savannah.gnu.org/git/guix.git
>       branch: master
>       commit: 4009d1de954d694cb11af391d4113d29c5c1379d
> ```
> Am I getting it right - you are suggesting I
> replace "mirror://gnupg/gnutls/v" with
> "https://gnutls.org/" or "ftp://gnutls.org" ?
> I'm asking because I'm not the original author of this package, so it's not
> obvious to me,
> what will be the right decision here?

I suspect this might have been fixed by
a9c33e9f688fce88aed610ab04c650efb71b4ce6.  So I would recommend pulling
current guix and trying the build once more.  It is likely it will work
now.

If yes, just close this issue, if no, please provide the new error (the
URL should be different).

Have a nice day,
Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

[bug#74092] [PATCH] fix gnutls package

[Adam]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

I confirm, after switching to     commit:
ad966c3844385e8f7b60b0dc915f92a1eba47e09,
I was able to build gnutls from the source.
How can I close the issue?


On Tue, Oct 29, 2024 at 9:43 PM Tomas Volf <~@wolfsden.cz> wrote:

> Adam <adam.quandour@gmail.com> writes:
>
> > The main reason I wrote the patch - I cannot build gnutls@3.8.3 from
> source
> > code.
> > This command
> > ```
> > guix build gnutls@3.8.3 --no-substitutes
> > ```
> > returns me this
> > ```
> >   expected hash: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp
> >   actual hash:   0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa
> > hash mismatch for store item
> > '/gnu/store/9zh4mcmwp2afyl4ig56943w64czdz2kp-gnutls-3.8.3.tar.xz'
> > ```
> > Guix I'm using
> > ```
> >     guix:
> >       repository URL: https://git.savannah.gnu.org/git/guix.git
> >       branch: master
> >       commit: 4009d1de954d694cb11af391d4113d29c5c1379d
> > ```
> > Am I getting it right - you are suggesting I
> > replace "mirror://gnupg/gnutls/v" with
> > "https://gnutls.org/" or "ftp://gnutls.org" ?
> > I'm asking because I'm not the original author of this package, so it's
> not
> > obvious to me,
> > what will be the right decision here?
>
> I suspect this might have been fixed by
> a9c33e9f688fce88aed610ab04c650efb71b4ce6.  So I would recommend pulling
> current guix and trying the build once more.  It is likely it will work
> now.
>
> If yes, just close this issue, if no, please provide the new error (the
> URL should be different).
>
> Have a nice day,
> Tomas
>
> --
> There are only two hard things in Computer Science:
> cache invalidation, naming things and off-by-one errors.
>

[-- Attachment #2: Type: text/html, Size: 2596 bytes --]

bug#74092: [PATCH] fix gnutls package

[Vagrant Cascadian]

[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]

On 2024-10-29, Adam wrote:
> I confirm, after switching to     commit:
> ad966c3844385e8f7b60b0dc915f92a1eba47e09,
> I was able to build gnutls from the source.

Thanks for confirming!

> How can I close the issue?

By sending to the -done address, which I've included in Cc.

live well,
  vagrant

> On Tue, Oct 29, 2024 at 9:43 PM Tomas Volf <~@wolfsden.cz> wrote:
>
>> Adam <adam.quandour@gmail.com> writes:
>>
>> > The main reason I wrote the patch - I cannot build gnutls@3.8.3 from
>> source
>> > code.
>> > This command
>> > ```
>> > guix build gnutls@3.8.3 --no-substitutes
>> > ```
>> > returns me this
>> > ```
>> >   expected hash: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp
>> >   actual hash:   0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa
>> > hash mismatch for store item
>> > '/gnu/store/9zh4mcmwp2afyl4ig56943w64czdz2kp-gnutls-3.8.3.tar.xz'
>> > ```
>> > Guix I'm using
>> > ```
>> >     guix:
>> >       repository URL: https://git.savannah.gnu.org/git/guix.git
>> >       branch: master
>> >       commit: 4009d1de954d694cb11af391d4113d29c5c1379d
>> > ```
>> > Am I getting it right - you are suggesting I
>> > replace "mirror://gnupg/gnutls/v" with
>> > "https://gnutls.org/" or "ftp://gnutls.org" ?
>> > I'm asking because I'm not the original author of this package, so it's
>> not
>> > obvious to me,
>> > what will be the right decision here?
>>
>> I suspect this might have been fixed by
>> a9c33e9f688fce88aed610ab04c650efb71b4ce6.  So I would recommend pulling
>> current guix and trying the build once more.  It is likely it will work
>> now.
>>
>> If yes, just close this issue, if no, please provide the new error (the
>> URL should be different).
>>
>> Have a nice day,
>> Tomas
>>
>> --
>> There are only two hard things in Computer Science:
>> cache invalidation, naming things and off-by-one errors.
>>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]