From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +O8zNCryJGfVeAAA62LTzQ:P1 (envelope-from ) for ; Fri, 01 Nov 2024 15:22:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id +O8zNCryJGfVeAAA62LTzQ (envelope-from ) for ; Fri, 01 Nov 2024 16:22:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=sH7qYe4m; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b="0 irbx7g"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730474538; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MBzi53V6YUWwx7WFlKJsGWvqFlPYhq32Y8ZzlQBe7JE=; b=CcHo1rlkij9qYdY7eYfPAsTIzdURC0gY/oYlhaxNdNOEI8xBvaL1A7dnvS7jHBMVGcyW11 t5cBNEFq1VYlem8h34mAG51aZly1ODY0SvRBU1TdiBMpV9GaNAMmL/ZevITcccvJT/SZYM gXCUs2fEbDURuE9bzhp7LGXq6+52D1jiXtiZacNNcrDqYjjaNVJX5FI8Em65G0NbYb8BX7 ycr+slfH8O4XPqJTUNxGD0ifs+hNRU4OngX58q2FQKBN7s8eMrK0PpDpKDyJqC165I4cPz 26jh2WCO5VyE3JJQuhHshgvWI0n1yxXrPH33msa2ysQF6Q+Sl8o3W4GZt7YD5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=sH7qYe4m; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b="0 irbx7g"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730474538; a=rsa-sha256; cv=none; b=VTDAYBjp+9iHyrKyj8EcWEmGeMjKzXhzwL2JCoES2CoBHjEG9SZUD/kv8Lb8RNTfIUjo7B +bd0dre98R+Dt/Pmo7yb9Z/SpEq8/4IOlIneUVnKVHK7WuW7rYU1ASwPAzKCqJ1YxbWT6c s6CDYGkvyuDN8i5hTK/gXAio2EpV0AC+fTbujECQfsL/fASgV7Nb9/zcbsqyHrh2yknHZH M5eAYzP7HPlkeYuk6pLj4xWdNE/BgtjgbQfIOoBxSQymlxTz3nNQ41BpOxeQVuToINL143 4zEDb6ADUYDzctlBcNsutqVPgHz3ml/7sm6nfBajeBl8UaiuuIqOD3b2cJ08xg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9983680485 for ; Fri, 01 Nov 2024 16:22:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6tTS-0007Di-R8; Fri, 01 Nov 2024 11:22:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6tTO-0007DJ-Nf for guix-patches@gnu.org; Fri, 01 Nov 2024 11:22:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6tTO-0002T6-FN for guix-patches@gnu.org; Fri, 01 Nov 2024 11:22:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:In-Reply-To:From:To:References:Subject; bh=MBzi53V6YUWwx7WFlKJsGWvqFlPYhq32Y8ZzlQBe7JE=; b=sH7qYe4mWB0Rc6e/HdOh7UjkfGKgt+wmBHjIGsU+sG71zUKxlwHpjrEyOr2afiJBYpegtRyBTSrzmU+vMiD38NIuHHUOckmB5jXCz+6aUN5t+I/EBeXGuZ2u+p84h97OhdEUaldYgogXZHojxERU3ybwJC5L/2RqAfS8TikB3HZs8ek5jGZP2htUk0br1z0Ob7t4wFzPBaJV2sni3HGAgTd9J7AkQkAWU8EE+L7UUIPZufBFgS8St/2lG3VqI1wKNjqZUoLgXX9fIkcWVxqg4lX0ILx6QNZq9kz9qqFhJOXelUBXiyRsrWmco4KcVhI2bPIxaAg2Y2yzawJQc3Kgsw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6tTO-0004he-5x for guix-patches@gnu.org; Fri, 01 Nov 2024 11:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73842] [PATCH v2 2/3] pack: Add support for AppImage pack format. References: Resent-From: =?UTF-8?Q?No=C3=A9?= Lopez Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Nov 2024 15:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73842 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: dev@jpoiret.xyz, 73842@debbugs.gnu.org, zimon.toutoune@gmail.com, othacehe@gnu.org, noelopez@free.fr, me@tobias.gr, code@sam-d.com, guix@cbaines.net, ludo@gnu.org Received: via spool by 73842-submit@debbugs.gnu.org id=B73842.173047448518067 (code B ref 73842); Fri, 01 Nov 2024 15:22:02 +0000 Received: (at 73842) by debbugs.gnu.org; 1 Nov 2024 15:21:25 +0000 Received: from localhost ([127.0.0.1]:50117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6tSn-0004hL-I9 for submit@debbugs.gnu.org; Fri, 01 Nov 2024 11:21:25 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:53881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6tSj-0004hD-Ln for 73842@debbugs.gnu.org; Fri, 01 Nov 2024 11:21:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:In-Reply-To:Subject:Cc:To:From:From:Sender: Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=MBzi53V6YUWwx7WFlKJsGWvqFlPYhq32Y8ZzlQBe7JE=; b=0 irbx7g+AosAuaH/uAn8sdIftzPAZxZxS+rbdWw9rYFz2lne3wSv7r4jKzHwtxtZMgq0asAIWogQ6V I9Hyr0AxSk4rQ+Pvjf3dFu1qGFAIBRHeHhvoitEdCmqwtviHBZ2V7dEqSEp2LCDQwqJoubQ+CHwAc HLCrL6OcOGSlI6ClB9d8oPMhr9iQF6jotTuLFWS1hZB2Wde9fyCz4Ui81GkG5cstnb3hJ81rfzS+T dZ43XsjCm1ooYsaVqXpdltq8UDJuCIg565ba3MK4BebEYyV4+LRNwiO4DqXCyIG8sgTegbQ1d/Kkj wtAnYCWsOIpL/q7D6xUPBZ24dhhj5ORYA==; Received: from [2a01:e0a:990:a960:b4f3:8f44:ec4:5af5] (port=35616 helo=lignux) by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t6tSd-00411V-7m; Fri, 01 Nov 2024 16:21:15 +0100 In-Reply-To: <87frob147v.fsf@gmail.com> (message from Maxim Cournoyer on Fri, 01 Nov 2024 22:19:32 +0900) Date: Fri, 01 Nov 2024 16:22:17 +0100 Message-ID: <87r07vou6u.fsf@xn--no-cja.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: =?UTF-8?Q?No=C3=A9?= Lopez X-ACL-Warn: , =?utf-8?q?No=C3=A9_Lopez_via_Guix-patches?= From: =?utf-8?q?No=C3=A9_Lopez_via_Guix-patches?= via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 1.54 X-Spam-Score: 1.54 X-Migadu-Queue-Id: 9983680485 X-TUID: yXE4jAG2yvpe Maxim Cournoyer writes: > Instead of a warning, could we just make it always -RR by default and > document that these are always relocatable, by design? The no > relocatable flags would be treated as an implicit -RR, and otherwise a > single -R would be treated as a single -R (and -RR as -RR, eh). I think it would be confusing to have default options change between pack formats, additionaly I=E2=80=99m not sure the -RR option has any effect compared to -R as we already use a runtime that requires fuse. The command will output a warning when the -R option is not used though: =C2=AB guix pack: warning: AppImages should be built with the --relocatable flag =C2=BB > Are there plans to add support for .DirIcon in the future? It was originally planned but with the added complexity it was kept for a later version. Notably, you need a full XDG icon structure inside your AppImage for the specification, that means multiple resolutions of your image and other icon stuff I don=E2=80=99t know about. It=E2=80=99s w= orth retrying though, as a single 256x256 png might work. > The rest looks good to me, from a quick read. If you could send a v3, > I'll then give it a real try. I=E2=80=99ve applied the rest of your suggestions, sending the v3 just after this. Thanks for reviewing, No=C3=A9