From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uObjHXFOfmdscgAAe85BDQ:P1 (envelope-from ) for ; Wed, 08 Jan 2025 10:07:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id uObjHXFOfmdscgAAe85BDQ (envelope-from ) for ; Wed, 08 Jan 2025 11:07:45 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=S0uJmwtF; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HaDqkP2B; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736330865; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bc8WIUY9RRfrAp1Vj8VDuzZB4S99BoR2JAIWLcWX7q4=; b=fG+np2itQY9mm2o4fG9CbZ37+9jlmvZIO3NfuDlN+NeoFZL+RvXYTGm7OmbnhcsJf1CrOL lDQu/LJPWlY/Cq+K6/AuK9v1Czp5PrpybFu18bZjR/Qq0XpicPnBXNZJN68KxqTa3/UtRG T2yh+BxdZ9hoXVGlS56GUZrJHpgMh+CSDl9Ae27q7q9b1kibB4hxjk0QvFFFskJCVwipZ0 ybk7NcV4TaV6QRJHG7MFB8iT/Z7d1uqo5P6TPM/5oqKldyqsgofZa8VYYUyLebyTJIy7kZ cXIJdXFHXbdtAAnF32tSvt9rG71JeLa0TsGri0AzvisHVMnjCQ28XcDLjHs47A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=S0uJmwtF; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=HaDqkP2B; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736330865; a=rsa-sha256; cv=none; b=FOCTZyBYsVsOxlMp8IjnO+TkrqpJY+3XqbVlEMBU6FUuVOwRwj4C/+lRRHuMbc501MQvyz U8mjS95AHQdwm+vkjjC9/e55UAwMjmgvCatz1pgGFgkLPHa7jDNbKgcQDz1D7MIEzOCjBI DLMDH7JQxQTfla7O6CmJBt4I+9NBrX3lNIvV7RdHapShpc/ych8z8pwFSUxpx7f8xRXk63 9qEOCkBmEqX843hMVNbPaGmtuEDbLsez0I5ZmG8Lx/dk3iirKRrhYrXoqcaOYpA3kCe5iX xiK/RGdUtru59tfyWYTOs0iplvFOu3eISUdhlNZ1GJYg+KCWJ4xcOIkvp3ZsrA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC3B745746 for ; Wed, 08 Jan 2025 11:07:44 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVSy5-0004Fr-Vp; Wed, 08 Jan 2025 05:07:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVSxq-0004Eb-FH for guix-patches@gnu.org; Wed, 08 Jan 2025 05:07:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVSxq-0000Wy-5s for guix-patches@gnu.org; Wed, 08 Jan 2025 05:07:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=bc8WIUY9RRfrAp1Vj8VDuzZB4S99BoR2JAIWLcWX7q4=; b=S0uJmwtFD4OdBMWXJKalqN3u1z/2GruB8Vd26DofVOvfwNOJNkpPxoCn5UfBgtJh9PNtGk+JXS93BrylqFdKN1Ac+G5kpxOS4oF1XtFX+4a1zec5LALRdXDPlmDN9eJXo3RF79EvDW26bqiQT32Xv0ZgwQXUECfz2LTo0XYywmOMhbUT8oEsbMoYfMI7En5QicV2r29LTYN4XU8KeeK24+sMDUdkZFt44CuuXnEvkouR2zl9sqG79k61lc8DUitqnNwlYBrzT6EkraDpa6UZKGltH1/sTdbeYCGzmWyVzw3nbBvTcsEA4wwwHob+iPHGRJ3d61wHI1+Zj9PWXf6OkQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVSxp-000298-Pn for guix-patches@gnu.org; Wed, 08 Jan 2025 05:07:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75302] [PATCH] packages: Match renamed origin fields. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Jan 2025 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75302 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Herman Rimm Cc: 75302@debbugs.gnu.org Received: via spool by 75302-submit@debbugs.gnu.org id=B75302.17363307818191 (code B ref 75302); Wed, 08 Jan 2025 10:07:01 +0000 Received: (at 75302) by debbugs.gnu.org; 8 Jan 2025 10:06:21 +0000 Received: from localhost ([127.0.0.1]:46041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVSxA-000283-VD for submit@debbugs.gnu.org; Wed, 08 Jan 2025 05:06:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56690) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVSxA-00027r-4S for 75302@debbugs.gnu.org; Wed, 08 Jan 2025 05:06:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVSx2-0000Hb-1b; Wed, 08 Jan 2025 05:06:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=bc8WIUY9RRfrAp1Vj8VDuzZB4S99BoR2JAIWLcWX7q4=; b=HaDqkP2B96UMB1jWc+R9 wQeo4zKylVF2nrMavEJXV7taF5nG3dKj7AWHxVBPE6jc6zAhtn5xy8Dr8omwZKBxuPwUMwXRnSiK1 asSodFsQupHI3bJhGBk9/DYkPB0P4WTcY984vTTYVHt54NwRLJz+c/CjamERHg59SVgXCBecmv/+h ozl7KR9LmV9Gj0DZovl4wxj5mN0FFaFDkLfE4gsmiCF5owrmtKYiUuQ8ROC4oRR6IqSkHL2SZ4OuA d6ewBweYjSAjht4/wJnzNBlaz4COfLODpvRHbegi+xNWXOtFWQq1mL7SNkWS623YBbpPZZdc28awd 50o//YZSRcWb4w==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Herman Rimm's message of "Mon, 6 Jan 2025 19:48:46 +0100") References: <18c0be606434165893e9566caa34aff0f3776a0e.1735851535.git.herman@rimm.ee> <87h66epa72.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 19 =?UTF-8?Q?Niv=C3=B4se?= an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Marbre X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 08 Jan 2025 11:06:08 +0100 Message-ID: <87r05dvcvj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: CC3B745746 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -5.17 X-Spam-Score: -5.17 X-TUID: pr+jajQKD8p1 Hi, Herman Rimm skribis: > On Sat, Jan 04, 2025 at 09:59:13PM +0100, Ludovic Court=C3=A8s wrote: >> The patch LGTM but, (1) fields haven=E2=80=99t been renamed recently, an= d=E2=80=A6 > > I misunderstood how (match _ (($ _) _)) works. Can you amend the commit > to start like: 'packages: Replace match with match-record.', instead? OK. > In a checkout at b8858d8b1344525d0d7ac78d8fb9dc1a577b85d3 with this > patch applied, running: > > guix shell -CPWN > ./pre-inst-env guix repl < tests/packages.scm If you really wanted to do this, try: ./pre-inst-env guile --no-auto-compile tests/packages.scm I recommend sticking to the documented procedure though. > I get the three errors mentioned, see attached log. I run the tests > like this because running: > > guix shell -CPWN > make check TESTS=3D"tests/packages.scm" > > returns: [...] > [ 77%] LOAD gnu.scm > ice-9/eval.scm:293:34: error: diff: unbound variable > hint: Did you forget a `use-modules' form? > make[2]: *** [Makefile:7518: make-system-go] Error 1 Well, it definitely builds here. Could it be that you have local changes in your tree? Or perhaps you need =E2=80=98make clean-go=E2=80=99 = first? > source-form: (test-assert "package-source-derivation, local-file" (let*= ((file (local-file "../guix/base32.scm")) (package (package (inherit (dumm= y-package "p")) (source file))) (source (package-source-derivation %store (= package-source package)))) (and (store-path? source) (string-suffix? "base3= 2.scm" source) (valid-path? %store source) (equal? (call-with-input-file so= urce get-bytevector-all) (call-with-input-file (search-path %load-path "gui= x/base32.scm") get-bytevector-all))))) > Test end: > result-kind: fail > actual-value: #f > actual-error: (system-error "canonicalize-path" "~A: ~S" ("No such file= or directory" "../guix/base32.scm") (2)) Probably has to do with running the test through standard input =E2=80=98gu= ix repl=E2=80=99: in that case it cannot correctly determine what the current = file name is, and so relative file name resolution fails. Ludo=E2=80=99.