From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40418)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxhGB-0007Cc-Ax
	for guix-patches@gnu.org; Mon, 10 Apr 2017 17:54:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxhG6-00006r-S4
	for guix-patches@gnu.org; Mon, 10 Apr 2017 17:54:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43436)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cxhG6-00006n-Ob
	for guix-patches@gnu.org; Mon, 10 Apr 2017 17:54:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxhG6-0003un-2U
	for guix-patches@gnu.org; Mon, 10 Apr 2017 17:54:02 -0400
Subject: bug#26275: [PATCH] build: perl-build-system: Add `wrap' phase.
Resent-Message-ID: <handler.26275.B26275.149186119314989@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170327193850.12655-1-arunisaac@systemreboot.net>
	<f5525e2f.AEAAIZKx6N0AAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2nQ0@mailjet.com>
Date: Mon, 10 Apr 2017 23:53:00 +0200
In-Reply-To: <f5525e2f.AEAAIZKx6N0AAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2nQ0@mailjet.com>
	(Arun Isaac's message of "Tue, 28 Mar 2017 20:03:13 +0530")
Message-ID: <87pogkdj5v.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26275@debbugs.gnu.org

Hi,

And sorry for the delay.

Arun Isaac <arunisaac@systemreboot.net> skribis:

>> +(define* (wrap #:key inputs outputs #:allow-other-keys)
>> +  (define (list-of-files dir)
>> +    (map (cut string-append dir "/" <>)
>> +         (or (scandir dir (lambda (f)
>> +                            (let ((s (stat (string-append dir "/" f))))
>> +                              (eq? 'regular (stat:type s)))))
>> +             '())))
>> +
>> +  (define bindirs
>> +    (append-map (match-lambda
>> +                  ((_ . dir)
>> +                   (list (string-append dir "/bin")
>> +                         (string-append dir "/sbin"))))
>> +                outputs))
>> +
>> +  (let* ((out  (assoc-ref outputs "out"))
>> +         (var `("PERL5LIB" prefix
>> +                ,(search-path-as-string->list
>> +                  (or (getenv "PERL5LIB") "")))))
>> +    (for-each (lambda (dir)
>> +                (let ((files (list-of-files dir)))
>> +                  (for-each (cut wrap-program <> var)
>> +                            files)))
>> +              bindirs)))
>
> I copied this wrap function from the python build system, and modified
> it a little to suite perl. Is there any reason `list-of-files' and
> `bindirs' are initialized using `define' rather than a `let' binding?
> This is probably a very basic Guile question, but still...

It=E2=80=99s purely cosmetic in this case: it makes them more visible and f=
its
within the 80-column limit.  :-)

Technically:

  (define (proc x y)
    (define a =E2=80=A6)
    (define b =E2=80=A6)
    body =E2=80=A6)

is equivalent to:

  (define (proc x y)
    (letrec ((a =E2=80=A6)
             (b =E2=80=A6))
      body =E2=80=A6))

See <https://gnu.org/software/guile/manual/html_node/Local-Bindings.html>.

HTH!

Ludo=E2=80=99.