From: "Clément Lassieur" <clement@lassieur.org>
To: Andy Wingo <wingo@igalia.com>
Cc: 26684@debbugs.gnu.org
Subject: bug#26684: let nginx configs reference the store
Date: Thu, 04 May 2017 00:58:34 +0200 [thread overview]
Message-ID: <87pofp7dk5.fsf@lassieur.org> (raw)
In-Reply-To: <cucr30dehqa.fsf@igalia.com>
Andy Wingo <wingo@igalia.com> writes:
> Hi,
>
> Is this the right way to do things? Passing lists around seems to be an
> intermediate point between strings and proper configuration values -- as
> such it seems like a useful intermediate step. The context is that I
> need to be able to extend the nginx configuration with a server config
> that references a store path.
>
> Andy
>
> From b56b797e2ca26619485d874110d3f1f0ae96fba4 Mon Sep 17 00:00:00 2001
> From: Andy Wingo <wingo@igalia.com>
> Date: Thu, 27 Apr 2017 19:49:02 +0200
> Subject: [PATCH 1/5] gnu: services: Nginx configs can reference store
>
> * gnu/services/web.scm (config-domain-strings, config-index-strings): Emit
> lists instead of strings.
> (emit-nginx-location-config, emit-nginx-server-config)
> (emit-nginx-upstream-config): Rename from nginx-location-config,
> default-nginx-server-config, and nginx-upstream-config. Emit lists instead of
> strings.
> (flatten): New helper.
> (default-nginx-config): Use flatten helper to write nginx conf. This allows
> location configs to reference store values.
> ---
> gnu/services/web.scm | 150 +++++++++++++++++++++++++--------------------------
> 1 file changed, 74 insertions(+), 76 deletions(-)
Hi Andy,
I tested it successfully (with a reference to the store), and it looks
good to me as well. Thanks you! You'll have some rebasing work to do
though with (lstat ssl-cert...).
Clément
next prev parent reply other threads:[~2017-05-03 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 20:08 bug#26684: let nginx configs reference the store Andy Wingo
2017-05-03 12:43 ` Ludovic Courtès
2017-05-03 22:58 ` Clément Lassieur [this message]
2017-07-24 13:01 ` [bug#26684] " Ludovic Courtès
2017-07-24 13:11 ` Clément Lassieur
2017-08-02 7:45 ` Christopher Baines
2017-08-02 9:31 ` Ludovic Courtès
2017-08-02 15:20 ` [bug#26684] [PATCH 1/2] gnu: services: Nginx configs can reference store Christopher Baines
2017-08-02 15:20 ` [bug#26684] [PATCH 2/2] web: Check for the existance of SSL related files Christopher Baines
2017-08-02 15:23 ` [bug#26684] let nginx configs reference the store Christopher Baines
2017-08-17 17:35 ` bug#26684: " Christopher Baines
2017-08-21 10:31 ` [bug#26684] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pofp7dk5.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=26684@debbugs.gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).