From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d71Zz-0007kg-2G for guix-patches@gnu.org; Sat, 06 May 2017 11:25:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d71Zu-0002wi-Vg for guix-patches@gnu.org; Sat, 06 May 2017 11:25:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60013) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d71Zu-0002wd-Jr for guix-patches@gnu.org; Sat, 06 May 2017 11:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d71Zu-0001zE-96 for guix-patches@gnu.org; Sat, 06 May 2017 11:25:02 -0400 Subject: bug#26713: [PATCH] gnu: Move netsurf to web-browsers.scm. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87lgqaghsh.fsf@openmailbox.org> References: <20170429220942.26880-1-kei@openmailbox.org> <20170430191306.GA26169@jasmine> <87shkpoehf.fsf@openmailbox.org> <87o9vdo805.fsf@openmailbox.org> <87lgqaghsh.fsf@openmailbox.org> Date: Sat, 06 May 2017 17:24:17 +0200 Message-ID: <87pofmypni.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau , Leo Famulari Cc: 26713@debbugs.gnu.org --=-=-= Content-Type: text/plain Kei Kebreau writes: > Kei Kebreau writes: > >> Kei Kebreau writes: >> >>> Leo Famulari writes: >>> >>>> On Sat, Apr 29, 2017 at 06:09:42PM -0400, Kei Kebreau wrote: >>>>> * gnu/packages/web.scm: Move netsurf... >>>>> * gnu/packages/web-browsers.scm: ...here. >>>> >>>> This caused building Guix to fail because the glib-or-gtk build-system >>>> module was not imported in (gnu packages web-browsers). >>>> >>> >>> Oh no! :( >>> >>>> I planned to add that module in a followup commit, but I realized that >>>> several other variables from (gnu packages web) need to be imported in >>>> (gnu packages web-browsers) along with this change, and I decided to >>>> revert the change for now. >>>> >>>> Can you take another look at moving this package? >>> >>> Will do. I'll have to adjust the qutebrowser patch for corrections to >>> this one. >> >> Try the attached patch. I'm not sure that copying the definition of >> netsurf-buildsystem is the best way to handle the move, but I'm not sure >> this is worth making netsurf-buildsystem a publicly-defined package. >> >> Thoughts? > > If you have no objections, I'd like to push this. AFAICT, the latest patch (id:87o9vdo805.fsf@openmailbox.org) does not actually move netsurf-build-system. Am I missing something? There are other things using netsurf-build-system as well, so I would just leave it for now. Also some copyright information is missing in the patch. As a side note, make sure to run `make` after moving code around like this. And `make clean-go` when deleting modules. I've been bitten before by Guix picking up code from stale .go files. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkN6qEACgkQoqBt8qM6 VPovYAgAwG3dlUagjrz3qy/T22Cc/kzvjpSMkE7gbUSqen6j23o0D6UImy3xv7Px 7b1O6EjMdvQPtJ8eBocgfskvqxgm75wol0AgJMm6qhZvH/Tk/TJu/9LkmSkIoJ+G TfE0GwBk9+CMCSlobVjvsOjQI6ZnXB8fDbibQdfM2fdQ3W957kaUVg2FNHFsgPah fsMUW3jzCLfzZGElZC3dpx9ZroPVBw+MaCpqDaqap9PzsISYrJ6HSl36sNj+H280 jor3BRt3XTHfgGtcfbuKPvZAyjb3+nEn/s4ZpZeDHZLujPYW5EaOipo7OHGPcDzE OcgZ5oePAuTpKXJ5Hbr4PFJiJVxwZA== =FjDl -----END PGP SIGNATURE----- --=-=-=--