From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33260)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dIXj4-0003Pr-7X
	for guix-patches@gnu.org; Wed, 07 Jun 2017 05:58:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dIXj0-0004mc-Uv
	for guix-patches@gnu.org; Wed, 07 Jun 2017 05:58:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57685)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dIXj0-0004mX-QK
	for guix-patches@gnu.org; Wed, 07 Jun 2017 05:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dIXj0-0003Nt-F3
	for guix-patches@gnu.org; Wed, 07 Jun 2017 05:58:02 -0400
Subject: bug#27225: [PATCH] artwork: Use a descriptive name for the source
	directory.
Resent-Message-ID: <handler.27225.B27225.149682942712937@debbugs.gnu.org>
From: Alex Kost <alezost@gmail.com>
References: <eefa4a48d87df42906e27c5f56f52e117ad59e4f.1496534039.git.leo@famulari.name>
Date: Wed, 07 Jun 2017 12:56:56 +0300
In-Reply-To: <eefa4a48d87df42906e27c5f56f52e117ad59e4f.1496534039.git.leo@famulari.name>
	(Leo Famulari's message of "Sat, 3 Jun 2017 19:54:01 -0400")
Message-ID: <87poeg86jb.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 27225@debbugs.gnu.org

Leo Famulari (2017-06-03 19:54 -0400) wrote:

> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.
> ---
>  gnu/artwork.scm | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/artwork.scm b/gnu/artwork.scm
> index 94c89143a..204845bd6 100644
> --- a/gnu/artwork.scm
> +++ b/gnu/artwork.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright =C2=A9 2014, 2015 Ludovic Court=C3=A8s <ludo@gnu.org>
> +;;; Copyright =C2=A9 2017 Leo Famulari <leo@famulari.name>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -28,13 +29,15 @@
>  ;;; Code:
>=20=20
>  (define %artwork-repository
> -  (origin
> -    (method git-fetch)
> -    (uri (git-reference
> -          (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> -          (commit "6998d30")))
> -    (sha256
> -     (base32
> -      "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
> +  (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +             (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> +             (commit commit)))
> +      (file-name (string-append "guix-artwork-" (string-take commit 7) "=
-checkout"))

As for me, this line is too long, I would make it:

       (file-name (string-append "guix-artwork-" (string-take commit 7)
                                 "-checkout"))

> +      (sha256
> +       (base32
> +        "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
>=20=20
>  ;;; artwork.scm ends here

--=20
Alex