From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXF4c-0006rR-9F for guix-patches@gnu.org; Mon, 17 Jul 2017 19:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXF4Z-00028Q-2d for guix-patches@gnu.org; Mon, 17 Jul 2017 19:05:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXF4Y-00027j-P2 for guix-patches@gnu.org; Mon, 17 Jul 2017 19:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dXF4Y-0001oC-FR for guix-patches@gnu.org; Mon, 17 Jul 2017 19:05:02 -0400 Subject: [bug#27637] [PATCH 2/2] gnu: Add conda Resent-Message-ID: From: Marius Bakke In-Reply-To: References: <20170713014726.21093-1-fredmanglis@gmail.com> <20170713014726.21093-2-fredmanglis@gmail.com> <87bmok6qd6.fsf@fastmail.com> Date: Tue, 18 Jul 2017 01:04:48 +0200 Message-ID: <87pocy64xb.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Frederick Muriithi Cc: 27637@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Frederick Muriithi writes: >> The previous patch also creates "$out/bin/conda". Does that executable >> not work? Why do we need both packages? >> > > Conda has two forms: > > * a python library form, that can be included in python programs, and > * an executable form that can be run on the cli > > I defined python-conda to provide the library form, whereas conda was > to provide the executable form. My question was more whether it made sense to provide two different packages, if they both have the same files. Does the `conda` executable from 'python-conda' work differently? Maybe we should rename or remove it to avoid conflicts? >> There are a few phases that messes with the tests, yet they are >> disabled. Why? > > My bad. I will reactivate them. Must have left that in by mistake. My apo= logies. Great, thanks! >> Wooow. What happens with the default 'python setup.py install'? >> > > The default setup.py builds the python library form, whereas the > utils/setup-testing.py builds the executable version Ahh okay. Having read both scripts it looks like 'setup.py' only installs "conda.cli.pip_warning:main" instead of the real thing. Sorry for the confusion! >> Unless there exists a good reason to both have a "conda" package and a >> 'python-conda', I think we should consolidate these two. The previous >> patch (from PyPi) did not have tests either, so I suppose we should use >> this release (but we should really figure out why setup.py is broken). > > I don't think setup.py is broken, I think the conda team built it that > way, so that one is explicit on what they want to do, at least that is > what I could gather from my reading on it. I will redefine the > packages to make it cleaner, and simply use the release/url that has > the tests to define both. Sounds good. I still think it's worth investigating if this "official" (quotes since it's still explicitly unsupported) build method also can be used as a library so we can avoid maintaining three variants of nearly the same package. Let us know what you find :-) Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlltQpAACgkQoqBt8qM6 VPo/aAgAsvibtH9Bj/cYPZ4gpwdVjjfo1ll2/OAsBauHYn8bk+aG8XV4t/YIX5JC WwGDGnPUd7aFvH4Ol87c+HOoYDzpgKNkaDIf8mJ0F5+lCO7yWYYZT0Lzan2wysCg ns/4FlwNvsIDUnjkcQVQfbg4ICUYfwBwUo4GSttQxIwTwauyQxbMijizjGx3WWqX UsO4u+fpYwB8SplO2tx3o1oOSSQ69DxYKnC7pnF/scXaIdxp092a511PpE57Tlwg MAkNWhSdCRRNMBpp+EPrLP1Hz/8Keo1oBIrI45YBh/O6xXc8WszTeDQ+TczDZDqR vTbQQwNv5LCAWFi5jFGn6qg18/wm8A== =NEZb -----END PGP SIGNATURE----- --=-=-=--