From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Baines <mail@cbaines.net>
Cc: 27249@debbugs.gnu.org
Subject: [bug#27249] [PATCH] gnu: gnome: Add deja-dup.
Date: Thu, 20 Jul 2017 11:28:11 +0200 [thread overview]
Message-ID: <87pocvwj84.fsf@gnu.org> (raw)
In-Reply-To: <eb9303e5-0306-357d-e18d-6230d7b80479@cbaines.net> (Christopher Baines's message of "Thu, 8 Jun 2017 21:50:25 +0100")
Heya Christopher,
Christopher Baines <mail@cbaines.net> skribis:
> On 07/06/17 14:01, Ludovic Courtès wrote:
>> Christopher Baines <mail@cbaines.net> skribis:
>>
>>> * gnu/packages/gnome.scm (deja-dup): New variable.
>>
>> There’s a couple of lint warnings fixed by the patch below:
[...]
>> Regarding propagated inputs:
>>
>>> + (propagated-inputs
>>> + `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
>>> + ("gobject-introspection" ,gobject-introspection)
>>> + ("duplicity" ,duplicity)
>>> + ("python" ,python2-minimal)
>>> + ("python-pygobject" ,python2-pygobject)))
>>
>> Could you add a comment explaining why all this needs to be propagated?
>> If there’s a way to avoid it, it’s even better (for instance, if
>> deja-dup execs duplicity, we could hard-code the absolute file name of
>> duplicity.)
>
> Thanks for your review Ludo, hopefully I can get around to looking at
> deja-dup again at the weekend :)
It’s been a long week-end. ;-) Could you take a look again so we can
save this patch from bitrot?
TIA!
Ludo’.
next prev parent reply other threads:[~2017-07-20 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 7:12 bug#27249: [PATCH] gnu: gnome: Add deja-dup Christopher Baines
2017-06-07 13:01 ` Ludovic Courtès
2017-06-08 20:50 ` Christopher Baines
2017-07-20 9:28 ` Ludovic Courtès [this message]
2017-07-22 9:33 ` [bug#27249] " Christopher Baines
2017-07-22 9:30 ` Christopher Baines
2017-07-24 12:50 ` bug#27249: " Ludovic Courtès
2017-07-24 12:50 ` [bug#27249] " Ludovic Courtès
2017-07-24 20:00 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pocvwj84.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27249@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).