From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dceaD-0004jc-HI for guix-patches@gnu.org; Tue, 01 Aug 2017 17:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dceaA-00088T-Bz for guix-patches@gnu.org; Tue, 01 Aug 2017 17:20:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34707) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dceaA-00088J-4O for guix-patches@gnu.org; Tue, 01 Aug 2017 17:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dcea9-00057P-SS for guix-patches@gnu.org; Tue, 01 Aug 2017 17:20:01 -0400 Subject: [bug#27911] 3 more qt modules Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170801193111.GP2406@macbook42.flashner.co.il> References: <20170801193111.GP2406@macbook42.flashner.co.il> Date: Tue, 01 Aug 2017 23:19:09 +0200 Message-ID: <87pocfvvea.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner , 27911@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Efraim Flashner writes: > This has qtnetworkauth, qtremoteobjects, qtspeech. > > After this we have qt3d, qtvirtualkeyboard, qtwebengine and qtwebview. Great, thanks for keeping up with Qt! [...] =20=20 > +(define-public qtspeech > + (package (inherit qtsvg) > + (name "qtspeech") > + (version "5.9.1") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://download.qt.io/official_releas= es/qt/" > + (version-major+minor version) "/" versi= on > + "/submodules/" name "-opensource-src-" > + version ".tar.xz")) > + (sha256 > + (base32 > + "00daxkf8iwf6n9rhkkv3isv5qa8wijwzb0zy1f6zlm3vcc8fz75c")))) > + (inputs > + `(("qtbase" ,qtbase))) > + (native-inputs > + `(("perl" ,perl) > + ("qtdeclarative" ,qtdeclarative) > + ("qtmultimedia" ,qtmultimedia) > + ("qtxmlpatterns" ,qtxmlpatterns))))) Does this package not keep references to these inputs? Can you add a comment about why they are only needed at build-time? I'd guess tests, but it's not obvious. These packages also need separate synopses and descriptions from 'qtsvg', but other than that looks good to me. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmA8E0ACgkQoqBt8qM6 VPo1dAf/WyjmF7oB1SBg00k0YH/gVlN99uEuwZyamhF01fGrN1pwgWAdNitzkZMW rmHbZdcN17Z+YI/Y8xhP8XNPaDMVIIxqjFZhWBQKu/pIHzdYiZoCpWSIjTiqb0ly eEtD2EeWCMa29FVDYzbEwKXFODbnkkN6HrPjkuFFJudXFmI8waweFp4Ehvx/7tMA Xm33bODCIMpeuhaZQ2pfg/GMR6uh1gkwfoBxtNjIS29sAnEbpiO9HyLVWKddHvWQ v2HuJ+MU1PJjUlqogDrdYEJOq2lPp6p/p+hyuu0TICq62sv6cV3ZBxKEJpqvhX1c 5bJv+zKty5rp5ecU48uN+6FH66tx4w== =/ql2 -----END PGP SIGNATURE----- --=-=-=--