From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgZil-0001y2-0B for guix-patches@gnu.org; Sat, 12 Aug 2017 12:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgZig-0005NF-5j for guix-patches@gnu.org; Sat, 12 Aug 2017 12:57:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgZig-0005N9-0H for guix-patches@gnu.org; Sat, 12 Aug 2017 12:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgZif-0003SY-Pd for guix-patches@gnu.org; Sat, 12 Aug 2017 12:57:01 -0400 Subject: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode. Resent-Message-ID: From: Oleg Pykhalov References: <87shgx2rql.fsf@gmail.com> <7a592bd0.ADkAACozouwAAAAAAAAAAAPfggsAAAACwQwAAAAAAAW9WABZjxmB@mailjet.com> Date: Sat, 12 Aug 2017 19:56:00 +0300 In-Reply-To: <7a592bd0.ADkAACozouwAAAAAAAAAAAPfggsAAAACwQwAAAAAAAW9WABZjxmB@mailjet.com> (Arun Isaac's message of "Sat, 12 Aug 2017 20:36:28 +0530") Message-ID: <87poc0zpwf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 28060@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Arun, thank you for supporting this patch. Arun Isaac writes: > Thanks for the patch! > > Oleg Pykhalov writes: =E2=80=A6 >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'chdir-elisp >> + (lambda _ >> + (chdir "misc/emacs")))))) > > It is kinda obvious, but do add a short comment explaining why we are > changing directory. DONE. >> + (synopsis "Emacs major mode for editing Nix expressions") >> + (description "@code{nixos-mode} provides an Emacs major mode for ed= iting >> +Nix expressions.") > > Could you add the following line to the description? > > "It supports syntax highlighting, indenting and refilling of comments." > > I have taken the above sentence from > https://github.com/NixOS/nix/blob/master/misc/emacs/README DONE. >> + (license license:gpl3+))) > > Nix is under the LGPL 2.1 license. So, nix-mode should also be under the > same license, right? DONE. > Could you send an updated patch? Thanks! --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-emacs-nixos-mode.patch Content-Description: [PATCH] gnu: Add emacs-nixos-mode. >From 796f6a09c9464812f85c77641473ac9c85ac9654 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Sat, 12 Aug 2017 09:48:53 +0300 Subject: [PATCH] gnu: Add emacs-nixos-mode. * gnu/packages/emacs.scm (emacs-nixos-mode): New variable. --- gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index bb5d2349f..cdee59858 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -5331,3 +5331,31 @@ enables you to easily define search engines, bind them to keybindings, and query them from the comfort of your editor.") (home-page "https://github.com/hrs/engine-mode") (license license:gpl3+))) + +(define-public emacs-nixos-mode + (package + (name "emacs-nixos-mode") + (version "1.11.13") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/NixOS/nix/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "12110drl51r9bi45ql865jwvax1gladb5hfpwk0vi5bjybns6c9b")))) + (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'chdir-elisp + ;; Elisp directory is not in root of the source. + (lambda _ + (chdir "misc/emacs")))))) + (synopsis "Emacs major mode for editing Nix expressions") + (description "@code{nixos-mode} provides an Emacs major mode for editing +Nix expressions. It supports syntax highlighting, indenting and refilling of +comments.") + (home-page "https://github.com/NixOS/nix") + (license license:lgpl2.1+))) -- 2.14.1 --=-=-= Content-Type: text/plain -- Best regards, Oleg. --=-=-=--