From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr24l-0004Cz-2Z for guix-patches@gnu.org; Sun, 10 Sep 2017 09:15:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr24k-0006Qb-AB for guix-patches@gnu.org; Sun, 10 Sep 2017 09:15:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49887) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dr24k-0006QU-6n for guix-patches@gnu.org; Sun, 10 Sep 2017 09:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dr24j-0006xY-W9 for guix-patches@gnu.org; Sun, 10 Sep 2017 09:15:02 -0400 Subject: [bug#28272] [PATCH] Improve and upgrade signing-party. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170829070739.7a836a20@cbaines.net> <87377x8996.fsf@gnu.org> <20170910120348.41543079@cbaines.net> Date: Sun, 10 Sep 2017 15:14:30 +0200 In-Reply-To: <20170910120348.41543079@cbaines.net> (Christopher Baines's message of "Sun, 10 Sep 2017 12:03:48 +0100") Message-ID: <87poay7l1l.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 28272@debbugs.gnu.org Christopher Baines skribis: > On Fri, 08 Sep 2017 18:07:01 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Christopher Baines skribis: >>=20 >> > Add several missing dependencies, particularly for the caff tool. It >> > now runs, but I've been unable to get it working fully yet, possibly >> > due to problems with the actual sending of the emails. >> > >> > Christopher Baines (12): >> > gnu: Add perl-moox. >> > gnu: Add perl-data-perl. >> > gnu: Add perl-moox-handlesvia. >> > gnu: Add perl-moox-late. >> > gnu: Add perl-convert-binhex. >> > gnu: Add perl-mailtools. >> > gnu: Add perl-mime-tools. >> > gnu: Add perl-net-idn-encode. >> > gnu: Add perl-text-template. >> > gnu: Add perl-gnupg-interface. >> > gnu: Add libmd. >> > gnu: Update signing-party.=20=20 >>=20 >> At first sight this looks good to me. > > Great, thanks for reviewing :) > >> Please use =E2=80=98license:perl-license=E2=80=99 instead of (package-li= cense perl). > > Within (gnu packages perl), it doesn't use a prefix for the licenses > module. I could switch it to use the license: prefix, or use just > perl-license within that module. Do you have a preference? Either way is fine. My point is: use the =E2=80=98perl-license=E2=80=99 bi= nding of (guix licenses), not (package-license perl). See the rationale in (guix licenses). Thanks! Ludo=E2=80=99.